From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 0C07F11DE for ; Wed, 18 Jan 2017 00:19:51 +0100 (CET) Received: by mail-wm0-f51.google.com with SMTP id f73so42708016wmf.1 for ; Tue, 17 Jan 2017 15:19:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ng46ZbnlMlnhwKZhrqruoT86CDAA7qYpdGvijoq2vrc=; b=g3O2MsHtia4w2djztD4iMbGNZeDTs7B7N0uTQTglToMEvmlY7+p4rspVuKy+CAX93L Ki8GhxQ8K/gYy2jxtZUVr5JLfKMldnReOHovGGK8EqfWB+GJgtp9JLTXF8De7SjlBeRc W0k0E/DUEGVZeTThsndO4PFzeNCFvZN8YD0Gf3UyxMY7Jqdpzij+v7i9JUJ+MT93UQQh kHitamwPY2UOD/m5fGiHVK+HsRQA5Ja7nbfv33DwtY0kZxvZxS61rqWNx/XYuxZmyAmj qHUP6IzHoMwbgQ+1pWPMS1CWSHG42zuN8mz+LWqfPO0nV+hrqm4EsmMFhktRXegZ13pm V5+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Ng46ZbnlMlnhwKZhrqruoT86CDAA7qYpdGvijoq2vrc=; b=kfgQ6XkZ9ZVbcWQkwMIr83H22ktEDms31hJ5hIu86KeLvSHKALa+QK2s7jpdHFumML M9pXGLPjG5lLWrwieyYxKBXmhXn+gCxZIHc0BphAYkVmh0UR3FNTLIRksHZLkpn9JklI JzfKCtQ37ObwuyyFeZuMN1kPsDLAmyiAfMgxMutQ/nG3AdZBIG3W8KRwe8duGuZMKryI m+5tHocr3gteAZi4AwPjvofkzDwx8v7YXFvb4PI8YZqGpc11ryFPEtfCLXxb81Lyb9ka 31tCOsuynGPuK9KOkNOBFIE/z4lbNYhiCxUEoY3N3ir8ARdaO6nViZRKatKI/rsecuU9 Nzxw== X-Gm-Message-State: AIkVDXLRU0EwZmtF/0a0utBcW8FNjC6f+VsIsLwHibUL280fbRY510cuHoesYYYLugDEhqt0 X-Received: by 10.223.165.138 with SMTP id g10mr102586wrc.157.1484695190753; Tue, 17 Jan 2017 15:19:50 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id u81sm22354wmu.10.2017.01.17.15.19.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Jan 2017 15:19:50 -0800 (PST) From: Thomas Monjalon To: Shreyansh Jain Cc: dev@dpdk.org Date: Wed, 18 Jan 2017 00:19:49 +0100 Message-ID: <4512536.CCfCtgmVzb@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1484660264-6531-2-git-send-email-shreyansh.jain@nxp.com> References: <1484647774-28984-1-git-send-email-shreyansh.jain@nxp.com> <1484660264-6531-1-git-send-email-shreyansh.jain@nxp.com> <1484660264-6531-2-git-send-email-shreyansh.jain@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 1/9] eal/bus: introduce bus abstraction X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2017 23:19:51 -0000 2017-01-17 19:07, Shreyansh Jain: > +void > +rte_bus_register(struct rte_bus *bus) > +{ > + RTE_VERIFY(bus); > + RTE_VERIFY(bus->name && strlen(bus->name)); > + > + TAILQ_INSERT_TAIL(&rte_bus_list, bus, next); > + RTE_LOG(INFO, EAL, "Registered [%s] bus.\n", bus->name); I think it should be a debug log. > +/* unregister a bus */ > +void > +rte_bus_unregister(struct rte_bus *bus) I appreciate the effort for commenting, but I think the function name is self describing. > +/** > + * @file > + * > + * RTE PMD Bus Abstraction interfaces RTE PMD? I would say "DPDK device bus interface" > +DPDK_17.02 { > + global: > + > + rte_bus_list; Why the bus list is exported? If it is for testing purpose, I wonder wether it is worth to do it.