From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 7A6E6F1F
 for <dev@dpdk.org>; Wed, 11 Oct 2017 15:11:05 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id E51F821A97;
 Wed, 11 Oct 2017 09:11:04 -0400 (EDT)
Received: from frontend1 ([10.202.2.160])
 by compute1.internal (MEProxy); Wed, 11 Oct 2017 09:11:04 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=SsK2yy849t49nXgHxGRY+GGGfa
 8Iy3XinK7zpXCSG0w=; b=bCBtj1RCwRA3IkKS6sTRjYAITOQ6A9YTVnuvltmRTK
 WYZGaZqWHO3W3LftIi+oH/kIHkWLwEA/3fRkf6hrKFWJo4mmJfp+OT3uIpY/6A8D
 Q+bnZA7FFXMNslniJTQ84oyfv74ZSuqsSFVaTaaXPKO51LJ/4SuaajT7ZZBaUQ6C
 0=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=SsK2yy
 849t49nXgHxGRY+GGGfa8Iy3XinK7zpXCSG0w=; b=gRWXZnzmlw9aVDdAsYqCMe
 eyjr9j6m+aVg8z6iGfYehdEXQRRjYgCeVn6emhkOYlyvpotgXPk46UHVJZ4rc27e
 7dzdasVVNQc4PbS6Ew1wnwSe3+kDNPFG/K398jfqs/eXQEJcI916/A/+v2isR/Iv
 Y+cUP99xwNV6XwaeZARZIHoU5aszD1W1jlF6OE9wEm8kKAj40+eFAxaHxlbAK7Ec
 6s6g4uMWrvxJ8YQ5Z4A4bPsT1dfE/r9mEVWWjE1iOrC1FOJ111P1VSgd0W3YCJlC
 Aqiu7hRvTjFSrUd3iu5ul5lMzZvrdGPt/13yDhHKJx4vKx9aiJ9pWMSwZgUNPPmg
 ==
X-ME-Sender: <xms:aBjeWfRQtewO3D-TgShrg9SGW6ARI7aNpDAuObRDbOdlYu7i2hlO1A>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 8BB257F96D;
 Wed, 11 Oct 2017 09:11:04 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Jingjing Wu <jingjing.wu@intel.com>
Cc: dev@dpdk.org, jianfeng.tan@intel.com, shreyansh.jain@nxp.com,
 hemant.agrawal@nxp.com, santosh.shukla@caviumnetworks.com,
 Tomasz Duszynski <tdu@semihalf.com>, Jacek Siuda <jck@semihalf.com>,
 jerin.jacob@caviumnetworks.com
Date: Wed, 11 Oct 2017 15:11:03 +0200
Message-ID: <4513487.fCd9laRvq9@xps>
In-Reply-To: <1503540656-104421-1-git-send-email-jingjing.wu@intel.com>
References: <1502636600-46889-1-git-send-email-jingjing.wu@intel.com>
 <1503540656-104421-1-git-send-email-jingjing.wu@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v3] eal: add counter size for efd clean
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Oct 2017 13:11:05 -0000

Hi,

24/08/2017 04:10, Jingjing Wu:
>         } else if (intr_handle->type == RTE_INTR_HANDLE_VDEV) {
> -               /* do nothing, and let vdev driver to initialize this struct */
> +               /* only check, initialization would be done in vdev driver.*/
> +               if (intr_handle->efd_counter_size >
> +                   sizeof(union rte_intr_read_buffer)) {
> +                       RTE_LOG(ERR, EAL, "the efd_counter_size is oversized");
> +                       return -EINVAL;
> +               }

How interrupts are working with other buses?

Is it something we should manage in bus drivers code?