From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id A0FABC320 for ; Tue, 28 Jul 2015 10:12:30 +0200 (CEST) Received: by wicgb10 with SMTP id gb10so144761891wic.1 for ; Tue, 28 Jul 2015 01:12:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=jOfhYhOf7By6zjjhUOBkJJSz76qWaHaJ0pGSw+Lllgk=; b=Ej++jlAOuhDzOVbPy/CyCIWcP6QQg4q1f6A01DOJrjK+4hJjt5aSk2/0/v2Cehae0/ Zf9cwl/nMvY/Zv5gMNdethCvxQzQR+x9RsSRx1LXqE99SqrfvrIarwY8OcBssq7fg7Nj eM50fDbV8cYPUhdx8YhMW//deLAjOc8pD3l1Bl+pqNE0vRiZtjnFOWBsUcFaKF0fGTAQ 578i3beISfhcacbKhsRVmZNBiaVjKqbX0aSnl9+9w30ZunuD8HVQJ8mZ346Ov6v/Z037 i7IW9v3kHN8gyDYzJWfwLkny1z0nc2OkOrHLr2c56S8529vh9zaBMXv9sHb7ILDMjpYH lXdw== X-Gm-Message-State: ALoCoQnR2HdPagQrZi/xIJXE2mLMIYs/Xd9V2GRzntAV+OVBk64pxHzmGfc5NwWh8Gf3zvy4cRSG X-Received: by 10.194.21.230 with SMTP id y6mr36443572wje.132.1438071150501; Tue, 28 Jul 2015 01:12:30 -0700 (PDT) Received: from xps13.localnet (228.202.154.77.rev.sfr.net. [77.154.202.228]) by smtp.gmail.com with ESMTPSA id iy4sm17685769wic.24.2015.07.28.01.12.29 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Jul 2015 01:12:29 -0700 (PDT) From: Thomas Monjalon To: Jingjing Wu Date: Tue, 28 Jul 2015 10:11:13 +0200 Message-ID: <4517043.MQg1LVTXME@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1438046019-30149-1-git-send-email-jingjing.wu@intel.com> References: <1438046019-30149-1-git-send-email-jingjing.wu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] i40e: correct the private data size for i40e vf driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jul 2015 08:12:30 -0000 Hi Jingjing, Few comments about the patch message. The title must tell what issue is fixed, e.g. "fix crash when...". the end "for i40e vf driver" is useless if it starts with "i40evf:". 2015-07-28 09:13, Jingjing Wu: > The patch fixes the i40e VF crash issue. The issue's root cause is that > the dev_private_size in i40e virtual function driver struct > rte_i40evf_pmd was set incorrectly. Please explain what are the conditions of the crash and give a reference to the commit introducing the error with "Fixes: ...". > Signed-off-by: jingjing.wu Thanks