From: Thomas Monjalon <thomas@monjalon.net>
To: "Kumar, Ravi1" <Ravi1.Kumar@amd.com>,
"Sardar, Shamsher singh" <Shamshersingh.Sardar@amd.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Akhil Goyal <akhil.goyal@nxp.com>,
david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH v2 1/2] crypto/ccp: sha3 support enabling in ccp
Date: Wed, 05 Feb 2020 23:22:17 +0100 [thread overview]
Message-ID: <45170712.MN2xkq1pzW@xps> (raw)
In-Reply-To: <VE1PR04MB6639F8EC0193429DF644D503E6020@VE1PR04MB6639.eurprd04.prod.outlook.com>
05/02/2020 13:24, Akhil Goyal:
> > For series,
> > Acked-by: Ravi Kumar <ravi1.kumar@amd.com>
> >
> > >
> > >From: Sardar Shamsher Singh <Shamshersingh.Sardar@amd.com>
> > >
> > >sha3 support enabled in AMD-CCP crypto controller
> > >
> > >Signed-off-by: Sardar Shamsher Singh <Shamshersingh.Sardar@amd.com>
> > >---
> Change patch title and description as below
> cryptodev: fix missing SHA3 algo strings
>
> SHA3 support was added earlier but algo strings were
> missing. This patch add the missing strings.
>
> Fixes: 1df800f89518 ("crypto/ccp: support SHA3 family")
> Cc: stable@dpdk.org
>
> Signed-off-by: Sardar Shamsher Singh <Shamshersingh.Sardar@amd.com>
> Acked-by: Ravi Kumar <ravi1.kumar@amd.com>
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
>
> Applied to dpdk-next-crypto
Sorry I must drop this patch because it triggers an ABI warning:
[C]'const char* rte_crypto_auth_algorithm_strings[]' was changed at rte_crypto_sym.h:320:1:
size of symbol changed from 168 to 232
I don't understand how the size of this array can impact the application,
but I prefer to stay on the safe side for now.
Please let's discuss this patch in 20.02-rc3 timeframe.
next prev parent reply other threads:[~2020-02-05 22:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 10:52 ssardar
2020-01-22 10:52 ` [dpdk-dev] [PATCH v2 2/2] examples/crypto: crypto test application ssardar
2020-01-28 6:35 ` Akhil Goyal
2020-01-30 8:45 ` Sardar, Shamsher singh
2020-01-30 8:52 ` Akhil Goyal
2020-01-30 9:08 ` Sardar, Shamsher singh
2020-01-22 11:11 ` [dpdk-dev] [PATCH v2 1/2] crypto/ccp: sha3 support enabling in ccp Kumar, Ravi1
2020-02-05 12:24 ` Akhil Goyal
2020-02-05 22:22 ` Thomas Monjalon [this message]
2020-02-06 9:34 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45170712.MN2xkq1pzW@xps \
--to=thomas@monjalon.net \
--cc=Ravi1.Kumar@amd.com \
--cc=Shamshersingh.Sardar@amd.com \
--cc=akhil.goyal@nxp.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).