From: Thomas Monjalon <thomas@monjalon.net>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org, Jerin Jacob <jerinj@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
david.marchand@redhat.com
Subject: Re: [PATCH] eal: provide trace point register macro for MSVC
Date: Sun, 12 Nov 2023 13:04:28 +0100 [thread overview]
Message-ID: <4522485.LvFx2qVVIh@thomas> (raw)
In-Reply-To: <1698878822-17099-1-git-send-email-roretzla@linux.microsoft.com>
01/11/2023 23:47, Tyler Retzlaff:
> Provide an alternate RTE_TRACE_POINT_REGISTER macro when building with
> MSVC that allocates segments for the trace point using MSVC specific
> features
>
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> ---
> +#ifdef RTE_TOOLCHAIN_MSVC
> +#define RTE_TRACE_POINT_REGISTER(trace, name) \
> +rte_trace_point_t \
> +__pragma(data_seg("__rte_trace_point")) \
> +__declspec(allocate("__rte_trace_point")) \
> +__##trace; \
You could indent lines which are part of the define.
> +static const char __##trace##_name[] = RTE_STR(name); \
> +RTE_INIT(trace##_init) \
> +{ \
> + __rte_trace_point_register(&__##trace, __##trace##_name, \
> + (void (*)(void)) trace); \
> +}
This part is common to both implementation.
It would be clearer to define a private macro for the trace point allocation
which is what differs, so it can be reused in a single common macro.
next prev parent reply other threads:[~2023-11-12 12:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 22:47 Tyler Retzlaff
2023-11-06 16:40 ` Thomas Monjalon
2023-11-06 17:30 ` Tyler Retzlaff
2023-11-12 12:04 ` Thomas Monjalon [this message]
2024-02-12 20:51 ` [PATCH v2] eal: provide macro to allocate and name a section or segment Tyler Retzlaff
2024-02-13 8:51 ` Morten Brørup
2024-02-13 11:28 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4522485.LvFx2qVVIh@thomas \
--to=thomas@monjalon.net \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=roretzla@linux.microsoft.com \
--cc=skori@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).