DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Thierry Herbelot <thierry.herbelot@6wind.com>,
	dev@dpdk.org, stable@dpdk.org
Cc: stable@dpdk.org, Ori Kam <orika@nvidia.com>,
	"Min Hu (Connor)" <humin29@huawei.com>
Subject: Re: [dpdk-stable] [PATCH] app/regex: avoid division by zero
Date: Sun, 26 Jun 2022 19:41:57 +0200	[thread overview]
Message-ID: <4523188.AxlXzFCzgd@thomas> (raw)
In-Reply-To: <08f29f81-5368-8c19-b688-029f3ab100d5@huawei.com>

24/05/2021 14:09, Min Hu (Connor):
> Hi, Thierry,
> 	This bug has been fixed in my earlier patch, please refer to:
> https://patches.dpdk.org/project/dpdk/patch/1618839289-33224-5-git-send-email-humin29@huawei.com/

Your patch is doing
+       if (!nb_jobs) {
+               job_len = data_len / nb_jobs;

It looks wrong.
I am for taking Thierry's patch.

> 在 2021/5/24 16:57, Thierry Herbelot 写道:
> > Check that nb_jobs is not zero before using it for a division.
> > 
> > Fixes: f5cffb7eb7fb6 ("app/regex: read data file once at startup")
> > Cc: stable@dpdk.org
> > Cc: Ori Kam <orika@nvidia.com>
> > 
> > Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> > ---
> >   app/test-regex/main.c | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/app/test-regex/main.c b/app/test-regex/main.c
> > index 8e665df73ce0..8f48cab11924 100644
> > --- a/app/test-regex/main.c
> > +++ b/app/test-regex/main.c
> > @@ -714,6 +714,8 @@ main(int argc, char **argv)
> >   		rte_exit(EXIT_FAILURE, "Number of QPs must be greater than 0\n");
> >   	if (nb_lcores == 0)
> >   		rte_exit(EXIT_FAILURE, "Number of lcores must be greater than 0\n");
> > +	if (nb_jobs == 0)
> > +		rte_exit(EXIT_FAILURE, "Number of jobs must be greater than 0\n");
> >   	if (distribute_qps_to_lcores(nb_lcores, nb_qps, &qps_per_lcore) < 0)
> >   		rte_exit(EXIT_FAILURE, "Failed to distribute queues to lcores!\n");
> >   	ret = init_port(&nb_max_payload, rules_file,




  reply	other threads:[~2022-06-26 17:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-24  8:57 [dpdk-dev] " Thierry Herbelot
2021-05-24 12:09 ` [dpdk-dev] [dpdk-stable] " Min Hu (Connor)
2022-06-26 17:41   ` Thomas Monjalon [this message]
2022-07-05 20:16 ` [dpdk-dev] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4523188.AxlXzFCzgd@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=humin29@huawei.com \
    --cc=orika@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=thierry.herbelot@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).