From: Ferruh Yigit <ferruh.yigit@intel.com>
To: <20220126063016.2384393-1-jie1x.wang@intel.com>, <dev@dpdk.org>
Cc: <stevex.yang@intel.com>, <orika@nvidia.com>,
<aman.deep.singh@intel.com>, <thomas@monjalon.net>,
<andrew.rybchenko@oktetlabs.ru>, <jingjing.wu@intel.com>,
<beilei.xing@intel.com>, <qi.z.zhang@intel.com>,
<olivier.matz@6wind.com>, Jie Wang <jie1x.wang@intel.com>
Subject: Re: [PATCH v3 1/6] ethdev: add L2TPv2 RSS offload type
Date: Tue, 1 Feb 2022 12:19:33 +0000 [thread overview]
Message-ID: <452340e8-ecf8-c759-9667-5cce98c2d0d8@intel.com> (raw)
In-Reply-To: <20220129062434.2455711-2-jie1x.wang@intel.com>
On 1/29/2022 6:24 AM, Jie Wang wrote:
> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
> index 147cc1ced3..29e6091bc8 100644
> --- a/lib/ethdev/rte_ethdev.h
> +++ b/lib/ethdev/rte_ethdev.h
> @@ -651,6 +651,13 @@ struct rte_eth_rss_conf {
> #define RTE_ETH_RSS_L4_CHKSUM RTE_BIT64(35)
> #define ETH_RSS_L4_CHKSUM RTE_DEPRECATED(ETH_RSS_L4_CHKSUM) RTE_ETH_RSS_L4_CHKSUM
>
> +/*
> + * Below macro is defined for RSS offload type, it can be used to
> + * fill rte_eth_rss_conf.rss_hf or rte_flow_action_rss.types.
> + */
> +#define RTE_ETH_RSS_L2TPV2 RTE_BIT64(36)
> +#define ETH_RSS_L2TPV2 RTE_ETH_RSS_L2TPV2
Perhaps I wasn't clear, don't have 'ETH_RSS_L2TPV2' at all.
Old macros were missing 'RTE_' prefix, so new ones added with prefix,
and old ones marked as deprecated.
When you are adding a new macro that already starts with 'RTE_' prefix
no need to add old/deprecated style of macro.
Please keep existing acks in next version of the patch.
next prev parent reply other threads:[~2022-02-01 12:19 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 6:24 [PATCH v3 0/6] support L2TPv2 for AVF RSS hash and FDIR Jie Wang
2022-01-29 6:24 ` [PATCH v3 1/6] ethdev: add L2TPv2 RSS offload type Jie Wang
2022-01-30 9:15 ` Ori Kam
2022-02-01 12:19 ` Ferruh Yigit [this message]
2022-01-29 6:24 ` [PATCH v3 2/6] net: fix L2TPv2 common header Jie Wang
2022-01-30 9:17 ` Ori Kam
2022-02-01 12:20 ` Ferruh Yigit
2022-01-29 6:24 ` [PATCH v3 3/6] app/testpmd: add 6 types of L2TPv2 message Jie Wang
2022-01-30 9:19 ` Ori Kam
2022-01-29 6:24 ` [PATCH v3 4/6] common/iavf: add session ID fields for L2TPv2 Jie Wang
2022-01-29 6:24 ` [PATCH v3 5/6] net/iavf: support L2TPv2 for AVF HASH Jie Wang
2022-01-29 6:24 ` [PATCH v3 6/6] net/iavf: support L2TPv2 for AVF FDIR Jie Wang
2022-02-01 12:22 ` [PATCH v3 0/6] support L2TPv2 for AVF RSS hash and FDIR Ferruh Yigit
2022-02-08 8:38 ` [PATCH v4 " Jie Wang
2022-02-08 8:38 ` [PATCH v4 1/6] ethdev: add L2TPv2 RSS offload type Jie Wang
2022-02-08 13:13 ` Ferruh Yigit
2022-02-08 14:43 ` Ferruh Yigit
2022-02-08 8:38 ` [PATCH v4 2/6] net: fix L2TPv2 common header Jie Wang
2022-02-08 8:38 ` [PATCH v4 3/6] app/testpmd: add 6 types of L2TPv2 message Jie Wang
2022-02-08 8:38 ` [PATCH v4 4/6] common/iavf: add session ID fields for L2TPv2 Jie Wang
2022-02-08 8:38 ` [PATCH v4 5/6] net/iavf: support L2TPv2 for AVF HASH Jie Wang
2022-02-09 7:01 ` Xing, Beilei
2022-02-09 7:43 ` Wang, Jie1X
2022-02-09 8:17 ` Zhang, Qi Z
2022-02-08 8:38 ` [PATCH v4 6/6] net/iavf: support L2TPv2 for AVF FDIR Jie Wang
2022-02-09 7:30 ` Xing, Beilei
2022-02-09 7:45 ` Wang, Jie1X
2022-02-08 14:44 ` [PATCH v4 0/6] support L2TPv2 for AVF RSS hash and FDIR Ferruh Yigit
2022-02-09 8:20 ` Zhang, Qi Z
2022-02-09 9:38 ` [PATCH v5 " Jie Wang
2022-02-09 9:38 ` [PATCH v5 1/6] ethdev: add L2TPv2 RSS offload type Jie Wang
2022-02-09 20:42 ` Ferruh Yigit
2022-02-09 9:38 ` [PATCH v5 2/6] net: fix L2TPv2 common header Jie Wang
2022-02-09 9:38 ` [PATCH v5 3/6] app/testpmd: add 6 types of L2TPv2 message Jie Wang
2022-02-09 9:38 ` [PATCH v5 4/6] common/iavf: add session ID fields for L2TPv2 Jie Wang
2022-02-11 1:37 ` Zhang, Qi Z
2022-02-09 9:38 ` [PATCH v5 5/6] net/iavf: support L2TPv2 for AVF HASH Jie Wang
2022-02-09 12:21 ` Xing, Beilei
2022-02-09 9:38 ` [PATCH v5 6/6] net/iavf: support L2TPv2 for AVF FDIR Jie Wang
2022-02-09 20:44 ` [PATCH v5 0/6] support L2TPv2 for AVF RSS hash and FDIR Ferruh Yigit
2022-02-10 2:13 ` Wang, Jie1X
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=452340e8-ecf8-c759-9667-5cce98c2d0d8@intel.com \
--to=ferruh.yigit@intel.com \
--cc=20220126063016.2384393-1-jie1x.wang@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jie1x.wang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=olivier.matz@6wind.com \
--cc=orika@nvidia.com \
--cc=qi.z.zhang@intel.com \
--cc=stevex.yang@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).