From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D02B1A00C2; Mon, 26 Sep 2022 16:02:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AFDE840DF7; Mon, 26 Sep 2022 16:02:15 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id E02B74069B for ; Mon, 26 Sep 2022 16:02:14 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 78BBF5C00A0; Mon, 26 Sep 2022 10:02:14 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 26 Sep 2022 10:02:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1664200934; x= 1664287334; bh=IiOJXTFpq6kU8Rf2DnjyjxWmLBKKr123R0AoTMp9oPM=; b=l 1IhTxLb3pAY2xJhEDo+HDI+3nuP5ZXuuJnM6COdSxqN1Y4nNQ8Tuqekn5EotEL3l oQHGR0srw17+226m4+Q0oHucmdF6kjJFDQbE+teRjN4DWOQNoT5dH6ytplobzKrB 2GwmbjokxPyc9dkysYo47phA04JsyN0CWnvaGc4z5byH37qvC748RK9LAkMLaNWi IN4SH3LVTzl2+P13C8cecXF5fVAzSQEdafuaLL28K9LBtHLy+WI5OlsTOyZeO6xa Hni4w0VJLmZlNCAlA8Gh7RA6PwH2hI/OXi9CZ71xYu/zFssbj9QFiiL86jhRDO+P X31yN2BCxRPVBIVJLYbPg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1664200934; x= 1664287334; bh=IiOJXTFpq6kU8Rf2DnjyjxWmLBKKr123R0AoTMp9oPM=; b=I ZVLox6DjQLvQ7pP4DySawx8tUbIb/912LmfbkEtZjHjPT7ZGYWxtIHT1Xchdf9pm 515iTldw0sYdUpz9cDPvZIjYbbWI+h94cDbsxopRZ4xrWRdsnuVaKkGrbdeDmle1 nWyaNkTsOUf4fqxfqXBdWdKhfOChir9oUjyO+mJzNiH0gPWDfBxvQ/SbI8EwMGhc gEsAYixLgKEmSuJ6+efvhAz5qr6H94d0X91fTNyOV7iExT1K9xZhWieU9NuhEKUe vV04JafSxdFurzri4nM5QaZw9iAA2BVrJLPvm3RPvJ8sgMM08GwAuZ+h2O6Nm9/4 bBV9zr26V9kCYaIMpg05w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeegvddgjeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 26 Sep 2022 10:02:11 -0400 (EDT) From: Thomas Monjalon To: Akhil Goyal Cc: dev@dpdk.org, david.marchand@redhat.com, hemant.agrawal@nxp.com, vattunuru@marvell.com, ferruh.yigit@xilinx.com, andrew.rybchenko@oktetlabs.ru, konstantin.v.ananyev@yandex.ru, jerinj@marvell.com, adwivedi@marvell.com, anoobj@marvell.com, ndabilpuram@marvell.com Subject: Re: [PATCH v5 1/3] ethdev: add IPsec SA expiry event subtypes Date: Mon, 26 Sep 2022 16:02:09 +0200 Message-ID: <4523612.CvnuH1ECHv@thomas> In-Reply-To: <20220924135758.3402392-2-gakhil@marvell.com> References: <20220416192530.173895-8-gakhil@marvell.com> <20220924135758.3402392-1-gakhil@marvell.com> <20220924135758.3402392-2-gakhil@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 24/09/2022 15:57, Akhil Goyal: > From: Vamsi Attunuru > > Patch adds new event subtypes for notifying expiry > events upon reaching IPsec SA soft packet expiry and > hard packet/byte expiry limits. > > Signed-off-by: Vamsi Attunuru > Signed-off-by: Akhil Goyal > --- > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -3875,8 +3875,26 @@ enum rte_eth_event_ipsec_subtype { > RTE_ETH_EVENT_IPSEC_ESN_OVERFLOW, > /** Soft time expiry of SA */ > RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY, > - /** Soft byte expiry of SA */ > + /** > + * Soft byte expiry of SA determined by @ref bytes_soft_limit > + * defined in @ref rte_security_ipsec_lifetime > + */ > RTE_ETH_EVENT_IPSEC_SA_BYTE_EXPIRY, > + /** > + * Soft packet expiry of SA determined by @ref packets_soft_limit > + * defined in @ref rte_security_ipsec_lifetime > + */ > + RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY, > + /** > + * Hard byte expiry of SA determined by @ref bytes_hard_limit > + * defined in @ref rte_security_ipsec_lifetime > + */ > + RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY, > + /** > + * Hard packet expiry of SA determined by @ref packets_hard_limit > + * defined in @ref rte_security_ipsec_lifetime > + */ > + RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY, > /** Max value of this enum */ > RTE_ETH_EVENT_IPSEC_MAX I would prefer we remove this MAX value, but it would be another patch. Acked-by: Thomas Monjalon You can merge this patch in the crypto tree.