From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5130DA0A03; Tue, 19 Jan 2021 09:34:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37DC0140D5B; Tue, 19 Jan 2021 09:34:06 +0100 (CET) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by mails.dpdk.org (Postfix) with ESMTP id 68A9B140D44 for ; Tue, 19 Jan 2021 09:34:04 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id B82115807AF; Tue, 19 Jan 2021 03:34:02 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 19 Jan 2021 03:34:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= vfCc7OppN+gQxoybNWAAUn8olBvXt97OjaNBFFVCWcI=; b=GfFl4AGwz/8rYaw+ DTNvSlZH7hvD4lK+PUDeo7PeakiPANbzPUbFx5jcGW17/NfGhOIWbEpucHqwzU05 CgZGTB9RvtmCgBV1zdf50gwSwmx1kBWgYDzpCriggjm41kwSRFvqMKtVfYQ3sL8c WulAffVUEBnJmBIWeTQokObEyMTgBHEpyYzJPSCQlTE2dL0rqfSeczG/03NHXMhC xRo/UTgCxFUyg6xPpDH9ypTvgmpNfEaXfu3o1XJ51uaesssF1tI4RU368ittlpCS JLMa6snBMDVwCULMscSWRJn9/7IhjnQJiL8JqgO9T3/8QmL6CRyIsLW8fdH7u0NK 4aDXEw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=vfCc7OppN+gQxoybNWAAUn8olBvXt97OjaNBFFVCW cI=; b=oElSvUajF2u4edFPz4KDwHtutOe2NZw8ys4cABjRfdnaTC82NeVFaHI0/ sqobfphYtasHbm+rOym35jEABloCrPXUeg1zUtOcLBzy/fe/t5AMh5wwLNDrIN/J eQMThqGJleqmBDDEPB1G23yjAYKnCs6pZZmcXobML9IDfnDTzLe/qUrjIxy3WI7h 9G88kPrmDch1s+aOMUk85WoR04b6PXOEwn/yDuoJ11WWogq30dZTCWPlGny/oDnt BmTCleaYAHToaBYUzSGN+CHZVGse9ZVC8pEYnHzJ+LGri4BqyXFk3aOVErIN0E/S TDDGoNnto1MwQUiK38aXSkeCVAwFQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrtdelgdduvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id BF42E1080059; Tue, 19 Jan 2021 03:33:59 -0500 (EST) From: Thomas Monjalon To: Xueming Li , Andrew Rybchenko Cc: dev@dpdk.org, Viacheslav Ovsiienko , Asaf Penso , Ajit Khaparde , Somnath Kotur , John Daley , Hyong Youb Kim , Beilei Xing , Jeff Guo , Haiyue Wang , Matan Azrad , Shahaf Shuler , Ferruh Yigit , Ray Kinsella , Neil Horman Date: Tue, 19 Jan 2021 09:33:58 +0100 Message-ID: <45243341.lbXXbIBvcf@thomas> In-Reply-To: <7309bfb0-63bb-e0c6-bd0d-2258cc94ad74@oktetlabs.ru> References: <1611040501-11666-1-git-send-email-xuemingl@nvidia.com> <1611040501-11666-7-git-send-email-xuemingl@nvidia.com> <7309bfb0-63bb-e0c6-bd0d-2258cc94ad74@oktetlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 7/9] devarg: change representor ID to bitmap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/01/2021 09:20, Andrew Rybchenko: > On 1/19/21 10:14 AM, Xueming Li wrote: > > --- a/lib/librte_ethdev/version.map > > +++ b/lib/librte_ethdev/version.map > > @@ -257,6 +257,8 @@ INTERNAL { > > rte_eth_dev_release_port; > > rte_eth_dev_internal_reset; > > rte_eth_devargs_parse; > > + rte_eth_representor_id_encode; > > + rte_eth_representor_id_parse; > > The place looks wrong. It must be sorted or added at bottom > with the comment with version number. I'd prefer to have > it simply alphanumberically sorted. We add a version number for experimental symbols to help moving old ones to stable. In this case, they are internal symbols, so we don't need version, but you're right it must be alphabetically sorted.