From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id D9E602E81 for ; Wed, 30 May 2018 12:30:30 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 79B0F21B8A; Wed, 30 May 2018 06:30:30 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 30 May 2018 06:30:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=lzG2Vom3DyaNo5MCGgQzH9i9nd 4o0mzLL9ob/k/EeUE=; b=EmwGKstms2OaiAZPS/CrNtEsZX3Aw//UD+ytJYxhOt myGC0m9SxYN3ZTm6z5pX9Tni+reMrI9unwJwTVY9YaqALtnnPUNPMKnGQIyYSABH p8Yi3VzOIo+qx7bCQ4EmMRnePbv1+PTA1jGKKaxvmgmGnJ6MyCSuqNbHmbAmNww3 0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=lzG2Vo m3DyaNo5MCGgQzH9i9nd4o0mzLL9ob/k/EeUE=; b=Xim20ITIMBP1BRkYIY81Vw +XzjSLSRSaTJsk11gI0vZRkz1mHM6BZ+UdDBMDEBkXEP1V25IM3f9BakHsl6otsB wCdiqrYAzcscxjdvuG5JOXIkZiaU7IIEnit6l6pgp4WUORuEdXNeZYEexgXvL/FL yg2K+INwVn0qQ7UDblSSjyNSue7WsJlakEaMHsR4tMjuF4RZNNbiIoaa5loBvWiM /2AybVpo9SVw2nF98435n3VZEZunD1lCJydXoSGein3pW5sccrT8NYUe0lOSeH2w NyiXe2FzV1eVw9eIw3EhGr0ZQuF7+nVcqKa6IdcngSkwKDAXVN2DZD1lLd8UATFg == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id BB98BE4412; Wed, 30 May 2018 06:30:29 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko Cc: dev@dpdk.org, Ferruh Yigit Date: Wed, 30 May 2018 12:30:28 +0200 Message-ID: <4525103.1gb9Ugr6pG@xps> In-Reply-To: References: <1527490247-23324-1-git-send-email-arybchenko@solarflare.com> <54455a54-fef1-8ad7-0bea-6c864bc4cbbe@solarflare.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/sfc: add missing Rx descriptor status callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 May 2018 10:30:31 -0000 30/05/2018 11:42, Ferruh Yigit: > On 5/30/2018 7:44 AM, Andrew Rybchenko wrote: > > Thomas, Ferruh, > > > > I've found out that the following patch is deferred in patchwork: > > https://dpdk.org/dev/patchwork/patch/40455/ > > > > It is critical under certain conditions since fix application crash. > > The patch is net/sfc local and just few lines - absolutely harmless. > > The only potential DPDK-wide effect is build, but the patch is really > > trivial and it is hard to imagine how it could affect the build. > > I'd like it to be included in 18.05, if possible. > > > > I understand that 18.05 is really very-very late already and it > > could be too late even for such patch. Just would like to > > double-check it. > > Hi Andrew, > > I did mark it as deferred and I overlooked that this fixes a crash. > > Agree that scope is local and only effect should be build, I confirmed the build > but to be sure I suggest get the patch and trigger an Intel daily build, and > include the patch into release if only that build also returns success. > > > > > Thanks, > > Andrew. > > > > On 05/28/2018 09:50 AM, Andrew Rybchenko wrote: > >> Rx descriptor status callback was lost and request of the Rx > >> descriptor status crashes application if equal stride super-buffer > >> Rx mode is used. > >> > >> Fixes: 390f9b8d82c9 ("net/sfc: support equal stride super-buffer Rx mode") > >> > >> Signed-off-by: Andrew Rybchenko Applied, thanks for the heads up.