[dpdk-dev] 答复: [PATCH v3] net/i40e: fix return value check issue

[caihe <caihe@huawei.com>]

Do you have any idea to fix the patch check warning, this is already the perfect way?

-----邮件原件-----
发件人: Zhang, Helin [mailto:helin.zhang@intel.com] 
发送时间: 2017年4月5日 23:34
收件人: caihe
抄送: dev@dpdk.org; Wu, Jingjing; Zhoujingbin
主题: RE: [PATCH v3] net/i40e: fix return value check issue



> -----Original Message-----
> From: henry [mailto:caihe@huawei.com]
> Sent: Wednesday, April 5, 2017 9:20 PM
> To: Zhang, Helin
> Cc: dev@dpdk.org; Wu, Jingjing; zhoujingbin@huawei.com; henry cai
> Subject: [PATCH v3] net/i40e: fix return value check issue
> 
> From: henry cai <caihe@huawei.com>
> 
> function i40evf_add_del_all_mac_addr without check return value of 
> rte_zmalloc
> 
> Fixes: 97ac72aa71a9 ("i40e: support setting VF MAC address ")
> 
> Signed-off-by: henry cai <caihe@huawei.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>
> ---
>  drivers/net/i40e/i40e_ethdev_vf.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
> b/drivers/net/i40e/i40e_ethdev_vf.c
> index d3659c9..3e0e2e1 100644
> --- a/drivers/net/i40e/i40e_ethdev_vf.c
> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> @@ -2016,6 +2016,10 @@ static int i40evf_dev_xstats_get(struct 
> rte_eth_dev *dev,
>  		}
> 
>  		list = rte_zmalloc("i40evf_del_mac_buffer", len, 0);
> +		if (!list) {
> +			PMD_DRV_LOG(ERR, "fail to allocate memory");
> +			return;
> +		}
> 
>  		for (i = begin; i < next_begin; i++) {
>  			addr = &dev->data->mac_addrs[i];
> --
> 1.8.3.1
>