From: dwilder <dwilder@us.ibm.com>
To: David Christensen <drc@linux.vnet.ibm.com>
Cc: rosen.xu@intel.com, grive@u256.net, dev@dpdk.org,
bruce.richardson@intel.com, drc@ibm.com
Subject: Re: [dpdk-dev] [PATCH] pci: restore access to RTE_VERIFY for Power builds
Date: Mon, 16 Mar 2020 16:14:47 -0700 [thread overview]
Message-ID: <453485806058cc744401186ae6154e46@linux.vnet.ibm.com> (raw)
In-Reply-To: <20200316204749.28066-1-drc@linux.vnet.ibm.com>
On 2020-03-16 13:47, David Christensen wrote:
> The include file rte_debug.h is pulled into x86 builds through the
> following callchain:
>
> lib/librte_eal/common/include/generic/rte_cycles.h:17,
> lib/librte_eal/common/include/arch/x86/rte_cycles.h:13,
> lib/librte_eal/common/include/arch/x86/rte_spinlock.h:18,
> lib/librte_eal/common/include/arch/x86/rte_rwlock.h:13,
>
> The PPC specific version of the same callchain does not include
> rte_debug.h. Add rte_debug.h back into the C files that require it.
>
> Fixes: 0dcba5256287 ("pci: remove unneeded includes in public header
> file")
> Cc: bruce.richardson@intel.com
>
> Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
> ---
...
Ran ci against this patch (with my ppc64le ci patches included), it ran
clean. Results are here:
https://travis-ci.org/github/djlwilder/dpdk/builds/663247710
Tested-by: David Wilder <dwilder@us.ibm.com>
next prev parent reply other threads:[~2020-03-16 23:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 20:47 David Christensen
2020-03-16 23:14 ` dwilder [this message]
2020-03-17 13:21 ` David Marchand
2020-03-17 19:39 ` David Marchand
2020-03-19 1:26 ` Xu, Rosen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=453485806058cc744401186ae6154e46@linux.vnet.ibm.com \
--to=dwilder@us.ibm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=drc@ibm.com \
--cc=drc@linux.vnet.ibm.com \
--cc=grive@u256.net \
--cc=rosen.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).