From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 14778A0559; Tue, 17 Mar 2020 00:14:55 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 60EA61C067; Tue, 17 Mar 2020 00:14:53 +0100 (CET) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id BE3861C065 for ; Tue, 17 Mar 2020 00:14:51 +0100 (CET) Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 02GN3Zcn147410; Mon, 16 Mar 2020 19:14:50 -0400 Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0a-001b2d01.pphosted.com with ESMTP id 2yrutk5bea-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Mar 2020 19:14:50 -0400 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id 02GNAbVd029857; Mon, 16 Mar 2020 23:14:49 GMT Received: from b01cxnp22033.gho.pok.ibm.com (b01cxnp22033.gho.pok.ibm.com [9.57.198.23]) by ppma01wdc.us.ibm.com with ESMTP id 2yrpw63pd9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Mar 2020 23:14:49 +0000 Received: from b01ledav001.gho.pok.ibm.com (b01ledav001.gho.pok.ibm.com [9.57.199.106]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 02GNEnwC46072250 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Mar 2020 23:14:49 GMT Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ED91728058; Mon, 16 Mar 2020 23:14:48 +0000 (GMT) Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 67AB928059; Mon, 16 Mar 2020 23:14:48 +0000 (GMT) Received: from ltc.linux.ibm.com (unknown [9.16.170.189]) by b01ledav001.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 16 Mar 2020 23:14:48 +0000 (GMT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 16 Mar 2020 16:14:47 -0700 From: dwilder To: David Christensen Cc: rosen.xu@intel.com, grive@u256.net, dev@dpdk.org, bruce.richardson@intel.com, drc@ibm.com In-Reply-To: <20200316204749.28066-1-drc@linux.vnet.ibm.com> References: <20200316204749.28066-1-drc@linux.vnet.ibm.com> Message-ID: <453485806058cc744401186ae6154e46@linux.vnet.ibm.com> X-Sender: dwilder@us.ibm.com User-Agent: Roundcube Webmail/1.0.1 X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.645 definitions=2020-03-16_10:2020-03-12, 2020-03-16 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 clxscore=1011 phishscore=0 mlxlogscore=502 bulkscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 spamscore=0 priorityscore=1501 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003160094 Subject: Re: [dpdk-dev] =?utf-8?q?=5BPATCH=5D_pci=3A_restore_access_to_RTE=5FV?= =?utf-8?q?ERIFY_for_Power=09builds?= X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2020-03-16 13:47, David Christensen wrote: > The include file rte_debug.h is pulled into x86 builds through the > following callchain: > > lib/librte_eal/common/include/generic/rte_cycles.h:17, > lib/librte_eal/common/include/arch/x86/rte_cycles.h:13, > lib/librte_eal/common/include/arch/x86/rte_spinlock.h:18, > lib/librte_eal/common/include/arch/x86/rte_rwlock.h:13, > > The PPC specific version of the same callchain does not include > rte_debug.h. Add rte_debug.h back into the C files that require it. > > Fixes: 0dcba5256287 ("pci: remove unneeded includes in public header > file") > Cc: bruce.richardson@intel.com > > Signed-off-by: David Christensen > --- ... Ran ci against this patch (with my ppc64le ci patches included), it ran clean. Results are here: https://travis-ci.org/github/djlwilder/dpdk/builds/663247710 Tested-by: David Wilder