From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 1A6871B069 for ; Mon, 17 Sep 2018 16:36:17 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id AE2FE20E73; Mon, 17 Sep 2018 10:36:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 17 Sep 2018 10:36:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=lMXzmFKHH8eZNlcBJoj7Vhrrzm PeQVt25CeAjtikfjA=; b=i81SMdoyekMzkCqGrUugBfziWrQiFy449bSBBntkoi XfYKqYQ3cclE4kSlRcsCIsx1+Ou3CpPc8KCIJN0hmB9JgN2rVV1ZfIJiOnhIvo5t y2dj5y5zk4Xvp3wNwWEnuE8fzKNueO5jqXeGZuttcQOrIdBqpx5S+iWXgOzWuGVr E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=lMXzmF KHH8eZNlcBJoj7VhrrzmPeQVt25CeAjtikfjA=; b=A32tJUyjEpIXaNIEwo4cYm GmjIyvze5YFijLpqdGhzHLhqbN8mTikRXS5lwkMVJ8oknf9B6dDI2EW69WnLLmid t1HccdHoIEciOv5UQuUamcD7gziKPWnyn0lITgWZ2qquiKfgsl0AlHfisoJL8p6x J3wDnhDaWR//QDSHeeeKTXSNyCpvNuYxjgT24xqBVfwhi4fQ7YUfvSR08xMexqcK jRmkWZwBruMja7Iw/OtFiPOVv2mJYl2pca9DK+2tPZDRMmdsSi5ofvchF5w4S8bf PPWadGdFw0pmn4rTpuHzjZnE0vbV0MS2Wo9ilMQ+VxThAsyk6vZ2QnOik8kscBDg == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7AD44E49EC; Mon, 17 Sep 2018 10:36:11 -0400 (EDT) From: Thomas Monjalon To: "Joseph, Anoob" Cc: dev@dpdk.org, Akhil Goyal , Anoob Joseph , Pablo de Lara , Ankur Dwivedi , Jerin Jacob , Narayana Prasad , Murthy NSSR , Nithin Dabilpuram , Ragothaman Jayaraman , Srisivasubramanian S , Tejasree Kondoj Date: Mon, 17 Sep 2018 16:36:10 +0200 Message-ID: <4535314.c5AgpL1HhT@xps> In-Reply-To: <23e3b8a8-32f9-cd91-bef9-c03eff0d4e46@caviumnetworks.com> References: <1528476325-15585-1-git-send-email-anoob.joseph@caviumnetworks.com> <06b2d39f-5d9a-d1e2-f3bb-5238e40e6406@nxp.com> <23e3b8a8-32f9-cd91-bef9-c03eff0d4e46@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2018 14:36:17 -0000 17/09/2018 16:13, Joseph, Anoob: > On 17-09-2018 17:50, Akhil Goyal wrote: > > On 9/17/2018 5:12 PM, Joseph, Anoob wrote: > >> On 17-09-2018 16:07, Akhil Goyal wrote: > >>>>> I think it would be better to squash the makefile related changes in > >>>>> the 3/33 patch as the code > >>>>> is actually added in that and here the code is not getting compiled > >>>>> here. > >>>> So the changes in the following files has to be moved to patch 3/33? > >>>> drivers/crypto/Makefile > >>>> drivers/crypto/meson.build > >>>> drivers/crypto/octeontx/Makefile > >>>> drivers/crypto/octeontx/meson.build > >>>> mk/rte.app.mk > >>>> I think this patch will just have MAINTAINER edit (even that might be > >>>> required to be moved to 3/33?) & changes to config/common_base, after > >>>> that. Is that fine? > >>> In my opinion, you do not need this patch as separate one. > >>> config/common_base can also be added in the 3/33. > >> In that case 02/33 patch would become the first patch right? The same > >> problem would be there too, I guess. The macros added in that patch gets > >> used only in 03/33 patch. Is that fine? > > > > I think that would be fine. Better to have a 03/33 patch before 02/33 > > if it doesn't have dependencies. > 03/33 patch is dependent on 02/33 patch. Shall I proceed with merging > 01/33 to 03/33 and make 02/33 the first patch? You should start by introducing common code directory. Then you introduce the PMD directory with minimal code in it. Question: what means "cpt"? Why it is not an "octeontx" common directory?