From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6062F45DAF; Wed, 27 Nov 2024 01:03:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC9C540EE3; Wed, 27 Nov 2024 01:03:01 +0100 (CET) Received: from fout-a6-smtp.messagingengine.com (fout-a6-smtp.messagingengine.com [103.168.172.149]) by mails.dpdk.org (Postfix) with ESMTP id 71688402A7 for ; Wed, 27 Nov 2024 01:03:00 +0100 (CET) Received: from phl-compute-04.internal (phl-compute-04.phl.internal [10.202.2.44]) by mailfout.phl.internal (Postfix) with ESMTP id E6C47138069C; Tue, 26 Nov 2024 19:02:59 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Tue, 26 Nov 2024 19:02:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1732665779; x=1732752179; bh=4ffm6fXFvRjUyZ6T5HUcoQgO+PCtPFxy6SIi2RrBFlQ=; b= bn5eBLSGuu9jIH0802erGV+KAg3J39R45X4hTyOqzVagVg3jubc2ZUuGxpWHdCDH obXlMQUlkGf23KBAV32bEuJnxW82vbhDsRTViSgrbEhCLp+oAnlhLI5fWLomCv/B K7j9XWI54FiDAR3Pp2zJLydDjbND4fwGxQVomCGAmM3RyeTKUUgicGyweHmAqkhw un72blqdl29H7FgLFbnkVHabZrOicPdgI6/JsWrCsBPhAvcAJwTmPCEeN+Sh/faz DwEXHxy/21QwZp9XyLioB7OMU6Wz48BaTsp3pYG/tJ7SvcnKfmrfDHGRqER+OGI8 oC1SsHD27UJvaoNhJeUYGg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1732665779; x= 1732752179; bh=4ffm6fXFvRjUyZ6T5HUcoQgO+PCtPFxy6SIi2RrBFlQ=; b=U +MWCXdzM3Kx6p4aUCqglGBpvezGHLycEZ+T1E9b16QB/YsJ49mwmX/88NxMDEUjn TWyAa5vMNvFTYjNBlpqP7pC96GHhL5hcKD730sl6zmR3IgDxw2pdfxgH+tLDd+le zd/w+iXLEWLSFXY3GPBAL8xcgQgkkbhbFrB58wFzNl+PpMfx5k1pTmaxb3CKFpd3 cgX6H0UUhAbRZJwvA3+gxl3e5JJ6ZF2tQQReqXyiAbq+g56aDIZQ4S4ClW2pvOMJ eSD8ZnFUhbWUfbm3D8IkxS063d3Zvat1SmrJQ4Ltb2/l7+Nzn7kiuAjOybYq0mja wpWjXaUELxgOzDypTrHpw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrgeekgdduiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecu hfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlh honhdrnhgvtheqnecuggftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdegkeeu veejffejgedtgeegkefgvdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthdpnhgs pghrtghpthhtohepfedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepphgruhhlrd hsiigtiigvphgrnhgvkhesrghrmhdrtghomhdprhgtphhtthhopeguvghvseguphgukhdr ohhrghdprhgtphhtthhopehluhgtrgdrvhhiiiiirghrrhhosegrrhhmrdgtohhm X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 26 Nov 2024 19:02:58 -0500 (EST) From: Thomas Monjalon To: Paul Szczepanek Cc: dev@dpdk.org, Luca Vizzarro Subject: Re: [PATCH] dts: remove html dir from dts doc path Date: Wed, 27 Nov 2024 01:02:57 +0100 Message-ID: <4540133.OBFZWjSADL@thomas> In-Reply-To: <20241126162506.1074550-1-paul.szczepanek@arm.com> References: <20241126162506.1074550-1-paul.szczepanek@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 26/11/2024 17:25, Paul Szczepanek: > To facilitate deploying docs to the website > and make paths more consistent remove the html > directory from the dts doc path. > > Signed-off-by: Paul Szczepanek > Reviewed-by: Luca Vizzarro > --- > # run sphinx, putting the html output in a "html" directory > with open(join(dst, 'sphinx_html.out'), 'w') as out: > - process = run(sphinx_cmd + ['-b', 'html', src, join(dst, 'html')], > - stdout=out) > + # dts is a special case which doesn't require an html dir in destination path The comment could be simpler like: # DTS API doc is already located in the API html dir > + html_dst = dst if 'dts' in src else join(dst, 'html') This check is too weak. It would be better to check for /html/dts in dst or for /html/ in 1 of the last 2 path children. > + process = run(sphinx_cmd + ['-b', 'html', src, html_dst], stdout=out)