From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id F24702E81 for ; Tue, 8 Dec 2015 01:50:59 +0100 (CET) Received: by wmec201 with SMTP id c201so9687136wme.1 for ; Mon, 07 Dec 2015 16:50:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=viPLo/YfaYXvREsDSHpODcaxViGhBK8A++uk2ti0ZqY=; b=ByGh/oVnmpBvTtDbFnYS9Oaw9kiEoJ93kS7WSTc6p3hYx/fbJdeNi62680drIIbl5+ eglFG981ag6XErn0qT9YU4d6wL4fgR1uiMsF/fq+nF7xqczcWWE9wQt/NGJ68DIuYQuQ XNvkuffOEB2+dWM1FDItK8H1CFzRqxEbhoG2IZ00jTywOnqS5QmFpT2nB4TmLlhsOH/5 0HbQSYh5wpp/8AwTm5R4TthrVU5kP5WTDggsMaAzKEW8V8rOUZ3XOiHWQ8SVoUZaLKeR iX0RDk7vOkDcXwnoUSMUapooeLZ9IjzQqPxnd/R9pmretWwvHFrOuuaaq9rSAfiyRIJG DP5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=viPLo/YfaYXvREsDSHpODcaxViGhBK8A++uk2ti0ZqY=; b=WrqH87pwqhhh+cgeM7RfQXALSIxjxcQdJ122zXpG7BraM42+EKyuNf8NR39IngvAaX jH4Aoay8GEyvU7xZIJmuYMg3ChBBO5s/BPn1U2vBi+BBw/56L2Bud80KGrMYqVcfyrNL 4d40WhM0LhN2Dm7wSIrkaPzMeSUXzEV6GutaTyY4+gsScAzYE/kSXv0rFQpY4+lopqrV GOgCxHkBAhiTjSIPpNWZpUTLclYml4+oDhGLi358uiSbej21YbqVx5B1GeOeKx389tmY cakqHBWYg+fvqc1ntMrQ+7HuJNkda02ECHM1xIekwMzdeocsmjsAUcc305Mtvzz8n/le KxnQ== X-Gm-Message-State: ALoCoQm+I/i9+FPQUCIvRTuYDUj0sIrb0Jg3NyX0JXDzftHaI5THE/daPHNImxPYsAopkrY6nCEV9cA8KzV9Md40PtGgrQFljQ== X-Received: by 10.28.0.149 with SMTP id 143mr25786747wma.48.1449535859845; Mon, 07 Dec 2015 16:50:59 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id cw3sm523130wjb.26.2015.12.07.16.50.58 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 07 Dec 2015 16:50:59 -0800 (PST) From: Thomas Monjalon To: Remy Horton Date: Tue, 08 Dec 2015 01:49:47 +0100 Message-ID: <4540150.cJ2HfHJFer@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1449496140-11758-3-git-send-email-remy.horton@intel.com> References: <1449496140-11758-1-git-send-email-remy.horton@intel.com> <1449496140-11758-3-git-send-email-remy.horton@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v10 2/4] mk: Fix missing directory with combined extlib build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Dec 2015 00:51:00 -0000 2015-12-07 13:48, Remy Horton: > Signed-off-by: Remy Horton > --- > mk/rte.extlib.mk | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/mk/rte.extlib.mk b/mk/rte.extlib.mk > index 4d459e4..47023a3 100644 > --- a/mk/rte.extlib.mk > +++ b/mk/rte.extlib.mk > @@ -42,11 +42,17 @@ export NOT_FIRST_CALL > > all: > $(Q)mkdir -p $(RTE_OUTPUT) > +ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),y) > + $(Q)mkdir -p $(RTE_OUTPUT)/build/lib > +endif This directory is created to copy an object file which is not never used. I suggest this approach instead: --- a/mk/rte.lib.mk +++ b/mk/rte.lib.mk @@ -136,7 +136,7 @@ endif $(depfile_newer)),\ $(O_TO_S_DO)) -ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),y) +ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS)$(EXTLIB_BUILD),yn) $(if $(or \ $(file_missing),\ $(call cmdline_changed,$(O_TO_C_STR)),\ @@ -159,7 +159,7 @@ $(LIB): $(OBJS-y) $(DEP_$(LIB)) FORCE $(depfile_missing),\ $(depfile_newer)),\ $(O_TO_A_DO)) -ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),y) +ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS)$(EXTLIB_BUILD),yn) $(if $(or \ $(file_missing),\ $(call cmdline_changed,$(O_TO_C_STR)),\ The combine lib is not prepared for external lib objects.