DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Radha Mohan Chintakuntla <radhac@marvell.com>
Cc: David Marchand <david.marchand@redhat.com>,
	dev@dpdk.org, Veerasenareddy Burru <vburru@marvell.com>,
	dpdk-dev <dev@dpdk.org>, Satananda Burla <sburla@marvell.com>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	Radha Mohan <mohun106@gmail.com>
Subject: Re: [dpdk-dev] [PATCH RESEND v4 2/2] drivers/raw: remove octeontx2-ep driver
Date: Wed, 25 Aug 2021 09:20:44 +0200	[thread overview]
Message-ID: <4542053.PkaVf6zlbM@thomas> (raw)
In-Reply-To: <CAC8NTUUfoxPinVET8SCjy_i9t77gKdYc0YSM=etT10Q_cR-Tug@mail.gmail.com>

23/08/2021 18:27, Radha Mohan:
> >  MAINTAINERS                               |   6 -
> >  doc/guides/rawdevs/index.rst              |   1 -
> >  doc/guides/rawdevs/octeontx2_ep.rst       |  82 ---
> >  drivers/raw/meson.build                   |   1 -
> >  drivers/raw/octeontx2_ep/meson.build      |  11 -
> >  drivers/raw/octeontx2_ep/otx2_ep_enqdeq.c | 846 ----------------------
> >  drivers/raw/octeontx2_ep/otx2_ep_enqdeq.h |  52 --
> >  drivers/raw/octeontx2_ep/otx2_ep_rawdev.c | 362 ---------
> >  drivers/raw/octeontx2_ep/otx2_ep_rawdev.h | 499 -------------
> >  drivers/raw/octeontx2_ep/otx2_ep_test.c   | 172 -----
> >  drivers/raw/octeontx2_ep/otx2_ep_vf.c     | 475 ------------
> >  drivers/raw/octeontx2_ep/otx2_ep_vf.h     |  10 -
> >  drivers/raw/octeontx2_ep/version.map      |   3 -
> >  13 files changed, 2520 deletions(-)

I see you missed updating the section "Removed Items"
of the current release notes.

> hi Thomas,
> 
> http://mails.dpdk.org/archives/test-report/2021-August/211681.html

doc/guides/rel_notes/release_19_08.rst:207:unknown document: ../rawdevs/octeontx2_dma

> This time it's failing in building release notes guide for 19.08 where
> this driver was introduced first.

It is failing on octeontx2_dma but should fail on octeontx2_ep in 20.02.

> Wouldn't release notes be built for current ?

No we have all release notes, and all are generated and published on dpdk.org.

> It would be odd to remove something from old release notes.

I suggest a simple fix in the old 20.02 release notes:
You can simply remove this line:
	See the :doc:`../rawdevs/octeontx2_ep` for more details on this new PMD.

Or if you want to keep it for completeness,
you can replace the link with a raw text ``rawdevs/octeontx2_ep``.




  reply	other threads:[~2021-08-25  7:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-12 12:37 [dpdk-dev] [PATCH v2 1/2] drivers/raw: remove octeontx2-dma driver Radha Mohan Chintakuntla
2021-08-13  7:00 ` [dpdk-dev] [PATCH v3 " Radha Mohan Chintakuntla
2021-08-19  7:57   ` [dpdk-dev] [PATCH v4 " Radha Mohan Chintakuntla
2021-08-20  3:38     ` Radha Mohan
2021-08-23 15:21     ` [dpdk-dev] [PATCH RESEND " Radha Mohan Chintakuntla
2021-08-23 15:21       ` [dpdk-dev] [PATCH RESEND v4 2/2] drivers/raw: remove octeontx2-ep driver Radha Mohan Chintakuntla
2021-08-23 16:27         ` Radha Mohan
2021-08-25  7:20           ` Thomas Monjalon [this message]
2021-08-26 10:50       ` [dpdk-dev] [PATCH v5 1/2] drivers/raw: remove octeontx2-dma driver Radha Mohan Chintakuntla
2021-08-26 10:50         ` [dpdk-dev] [PATCH v5 2/2] drivers/raw: remove octeontx2-ep driver Radha Mohan Chintakuntla
2021-08-26 11:10           ` Radha Mohan
2021-10-18 16:36         ` [dpdk-dev] [PATCH v5 1/2] drivers/raw: remove octeontx2-dma driver Thomas Monjalon
2021-08-13  7:01 ` [dpdk-dev] [PATCH v3 2/2] drivers/raw: remove octeontx2-ep driver Radha Mohan Chintakuntla
2021-08-19  7:59   ` [dpdk-dev] [PATCH v4 " Radha Mohan Chintakuntla
2021-08-23 12:19     ` Radha Mohan
2021-08-23 12:31       ` David Marchand
2021-08-23 12:41         ` Radha Mohan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4542053.PkaVf6zlbM@thomas \
    --to=thomas@monjalon.net \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=mohun106@gmail.com \
    --cc=radhac@marvell.com \
    --cc=sburla@marvell.com \
    --cc=vburru@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).