From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C6E4CA0A03; Mon, 18 Jan 2021 23:26:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 43B92140D2C; Mon, 18 Jan 2021 23:26:34 +0100 (CET) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by mails.dpdk.org (Postfix) with ESMTP id 0F5F2140D2B for ; Mon, 18 Jan 2021 23:26:31 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 780415806ED; Mon, 18 Jan 2021 17:26:30 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 18 Jan 2021 17:26:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= UnPGhUT+y9TzOceVSa6ETb+nB6qgr5H14/hbx2hxrFk=; b=P7iOOOr735ksu0Hz /xv5z3YG+I/9usbCVpK4BnpZEBYWvgf4Hi6hb/8olaXXbU8yDMQh4S04XZuYBXdr Or2gm3/dNSkfTwb7DyYZ7Kd5BV2GcUC1KNh0BUh2LDQBkw+PCzueN1hrDaz2CSAD t3pPrL0tsbW+TPoiJqa0YPYcugz+A8Wuq0qFvVQLtOxm2zU1shSzLM9JooP79irc emyI9GYq8iq00yM2FqOzEIuBx+jj2Lr2TPKsUQHZQ0QJ6b1hJa/0g63MxEIS23PB BGp07DFjcj7ATiwRSkMXJ1K9io3qSdt/ro6AC3JBWGOJ47GjLXyL+9wQNyUoYviq sIfLSw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=UnPGhUT+y9TzOceVSa6ETb+nB6qgr5H14/hbx2hxr Fk=; b=QJmTRV38uLOqjeGSAhxDB8cUyKIE6S/LgDkI2eXmeJkMn/iSRu7Q8KrET Um+UwORlV58OrC2OuCaHai7PFPCbxDEpEkvb9jMiw36Owdpd3xzbL7umFBAHqLTQ rgpeSm00nRTr2aTIrRgQYQBd8M0RZXkZe/bhgqFyPBg92gBD/qxpqjHfwKBt5o1f x+sr9tHLts6LytKXGk7uIUzaoH0N0mFMETkGvdVHVSl87AxB8P0zf9BBa3j1n/H0 h+ExKnuDEAGbTxnvP2OVPzlrhyNixMNnpb7T7MOUQV6HafEQ2usouK32zFY4h35j NqybIIfQB8l8zjFfrnJwCqT9X2QEg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrtdekgdduieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4BC921080066; Mon, 18 Jan 2021 17:26:28 -0500 (EST) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, Timothy McDaniel , Jan Viktorin , Ruifeng Wang , Jerin Jacob , David Christensen , Bruce Richardson , Konstantin Ananyev , david.hunt@intel.com, chris.macnamara@intel.com Date: Mon, 18 Jan 2021 23:26:27 +0100 Message-ID: <4544999.HkzO7cMdQl@thomas> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v17 03/11] eal: change API of power intrinsics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/01/2021 15:46, Anatoly Burakov: > +struct rte_power_monitor_cond { > + volatile void *addr; /**< Address to monitor for changes */ > + uint64_t val; /**< Before attempting the monitoring, the address > + * may be read and compared against this value. "may" be read and compared? Is there a case where there is no read and compare? > + **/ > + uint64_t mask; /**< 64-bit mask to extract current value from addr */ > + uint8_t data_sz; /**< Data size (in bytes) that will be used to compare > + * expected value with the memory address. Can be 1, > + * 2, 4, or 8. Supplying any other value will lead to > + * undefined result. */ Other parameters are not prefixed with "data_", so I think this field could be simply named "size". > +}; I understand this struct is a direct translation of what existed in 20.11 as function parameters and comments. If you agree, these comments could be addressed in a separate patch.