From: Thomas Monjalon <thomas@monjalon.net>
To: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/3] devargs: delay freeing previous devargs when overriding them
Date: Mon, 05 Nov 2018 08:30:31 +0100 [thread overview]
Message-ID: <4545148.O9CyC7tLm6@xps> (raw)
In-Reply-To: <20181105070447.67700-2-dariusz.stojaczyk@intel.com>
Hi,
05/11/2018 08:04, Darek Stojaczyk:
> -int __rte_experimental
> -rte_devargs_insert(struct rte_devargs *da)
> +void __rte_experimental
> +rte_devargs_insert(struct rte_devargs *da, struct rte_devargs **prev_da)
You should update the API section of the release notes.
> {
> - int ret;
> + struct rte_devargs *d;
> + void *tmp;
> +
> + *prev_da = NULL;
> + TAILQ_FOREACH_SAFE(d, &devargs_list, next, tmp) {
> + if (strcmp(d->bus->name, da->bus->name) == 0 &&
> + strcmp(d->name, da->name) == 0) {
> + TAILQ_REMOVE(&devargs_list, d, next);
> + *prev_da = d;
> + break;
> + }
> + }
>
> - ret = rte_devargs_remove(da);
> - if (ret < 0)
> - return ret;
Why not updating rte_devargs_remove instead of duplicating its code?
next prev parent reply other threads:[~2018-11-05 7:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 7:04 [dpdk-dev] [PATCH 1/3] bus/pci: update device devargs on each rescan Darek Stojaczyk
2018-11-05 7:04 ` [dpdk-dev] [PATCH 2/3] devargs: delay freeing previous devargs when overriding them Darek Stojaczyk
2018-11-05 7:30 ` Thomas Monjalon [this message]
2018-11-05 8:25 ` Stojaczyk, Dariusz
2018-11-05 9:46 ` Thomas Monjalon
2018-11-05 16:24 ` Gaëtan Rivet
2018-11-05 7:04 ` [dpdk-dev] [PATCH 3/3] eal: handle bus rescan failures during hotplug Darek Stojaczyk
2018-11-05 14:10 ` [dpdk-dev] [PATCH 1/3] bus/pci: update device devargs on each rescan Gaëtan Rivet
2018-11-05 14:52 ` Stojaczyk, Dariusz
2018-11-05 16:27 ` Gaëtan Rivet
2018-11-06 5:40 ` [dpdk-dev] [PATCH v2] " Dariusz Stojaczyk
2018-11-06 22:21 ` Zhang, Qi Z
2018-11-06 23:40 ` Gaëtan Rivet
2018-11-12 0:47 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4545148.O9CyC7tLm6@xps \
--to=thomas@monjalon.net \
--cc=dariusz.stojaczyk@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).