From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <remy.horton@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 1F5D8199B0
 for <dev@dpdk.org>; Wed, 10 Jan 2018 08:22:39 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 09 Jan 2018 23:22:39 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,339,1511856000"; d="scan'208";a="22835454"
Received: from rhorton-mobl1.ger.corp.intel.com (HELO [163.33.230.11])
 ([163.33.230.11])
 by orsmga001.jf.intel.com with ESMTP; 09 Jan 2018 23:22:37 -0800
To: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
References: <20180108143720.7994-1-remy.horton@intel.com>
 <20180108143720.7994-6-remy.horton@intel.com>
 <117e871e-faf8-a38e-8baa-59c01bc00ba4@intel.com>
Cc: John McNamara <john.mcnamara@intel.com>, Wenzhuo Lu
 <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>
From: Remy Horton <remy.horton@intel.com>
Organization: Intel Shannon Limited
Message-ID: <4547e589-e092-7019-72be-e0ec7f5076e2@intel.com>
Date: Wed, 10 Jan 2018 07:22:36 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <117e871e-faf8-a38e-8baa-59c01bc00ba4@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v4 5/5] app/test-pmd: add Port Representor
 commands
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Jan 2018 07:22:40 -0000


On 09/01/2018 22:10, Ferruh Yigit wrote:
[..]
>> +Adding a representor for a VF requires specifying the PF in
>> +``Bus_DomBDF`` format alongside the index number of the VF::
>> +
>> +   testpmd> add representor pci_0000:81:00.0 0
>
> I am for grouping port related commands under "port" command, these are all OK
> in their context, but when you look into all testpmd command it turns into mess.
>
> What do you think for:
> port representor add <pf_address> <vport_id>
> port representor del <pf_address> <vport_id>

Seems good to me - did notice some of the interactive help screens were 
a bit on the long side..