From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 3FA19DED for ; Mon, 23 Apr 2018 13:12:13 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 21F4F21B15; Mon, 23 Apr 2018 07:12:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 23 Apr 2018 07:12:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=RM/4tUX56752Yl5Ug5DOhWIuQh dDdxeUQZcEozSfsag=; b=MyKTR8mfKXAh7zig0weGdDJjctPpcAixNn8PC2BvRC K62chqjjyRGR8wqB7TTGDa0Rf9UCRq4ZMNSlpl7nhZW3U5hea+Mc5SdU0L71Hxx0 MrFLu/LnKVl8ofAOQfA3iZCtcA+nVANQIfqkRa45vwsJQJamFTxHIxobsTe8iZw5 s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=RM/4tU X56752Yl5Ug5DOhWIuQhdDdxeUQZcEozSfsag=; b=Whpgb6Xh3MwmUVkRo6y+ZD xZ+4KZISaFQ1p2TUAgx8tUJGMAn30WgZi1evezv7adLILIsgFG3qh4Nncwt3SN8P ZTHnFwAkZncBpjbr9gB1YaRGBJYkotblji5dydStkLgVxlsRcDF419VS/RQbqqDV +vVRGqBJBKKh+LBYtSXM5M0qNNyuVVMDSJvL9nf6e8qT8brnL+AMrjR6eNVcHB6a c7uh28H4Eorx7oEomb0O5ZPyHyjMEzihJk3HEh1QsUZRikLniTd3Zn8+pBBbWCai VRhPA24IICqSV3q3o21DJYAIPYVuWUnEsHu5ulY5X/95y5ZPv39idt+3iPoQGUVA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 74731E498D; Mon, 23 Apr 2018 07:12:11 -0400 (EDT) From: Thomas Monjalon To: "Mokhtar, Amr" Cc: "Chalupnik, KamilX" , "dev@dpdk.org" Date: Mon, 23 Apr 2018 13:12:10 +0200 Message-ID: <4551437.8ZCrZuEaxO@xps> In-Reply-To: <3D3765A8CDB52A4C8B410430AA19CB236ECAFFC8@IRSMSX101.ger.corp.intel.com> References: <20180404140602.9344-1-kamilx.chalupnik@intel.com> <2713250.YhKZBbbERd@xps> <3D3765A8CDB52A4C8B410430AA19CB236ECAFFC8@IRSMSX101.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc: update bbdev library documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2018 11:12:13 -0000 23/04/2018 12:56, Mokhtar, Amr: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 04/04/2018 16:05, KamilX Chalupnik: > > > From: "Chalupnik, KamilX" > > > > > doc/guides/prog_guide/bbdev.rst | 247 > > +++++++++++++++++++++++--- > > > doc/guides/prog_guide/img/turbo_tb_decode.png | Bin 0 -> 43552 > > bytes > > > doc/guides/prog_guide/img/turbo_tb_encode.png | Bin 0 -> 46944 > > bytes > > > 3 files changed, 222 insertions(+), 25 deletions(-) > > > create mode 100644 doc/guides/prog_guide/img/turbo_tb_decode.png > > > create mode 100644 doc/guides/prog_guide/img/turbo_tb_encode.png > > > > No, sorry, you cannot add binary file in this repository. > > It is an Open Source project, we provide sources. > > For figures, the SVG format is preferred. > > > > I'm sorry that your Intel colleagues did not warn you. > > > > I wasn't aware there is specific preference for figures, this can be fixed. > There is no specific reason for choosing .png except that there are files already > in prog_guide/img/* of type .png. So it was assumed that its ok. > And BTW, did I miss it somewhere in DPDK documentation what particular image > types should be submitted. Yes, it is in this doc: http://dpdk.org/doc/guides/contributing/documentation.html#images > Will get this fixed. Thanks. Thanks