From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13C44A0556; Thu, 20 Feb 2020 12:51:27 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D9F2A1C02A; Thu, 20 Feb 2020 12:51:25 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 8CC9A1C028 for ; Thu, 20 Feb 2020 12:51:24 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 233D021AB4; Thu, 20 Feb 2020 06:51:24 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 20 Feb 2020 06:51:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=YO5+i5s+k+tlJS1SVA+63w54Ngss5MoH2K6XLX2OAn8=; b=iCG+r1XiqdYf W2RlzaJYfI2nbhGnFojPUHTnqeGYgcxGUWiRjwTFjH4BWlHLEV7dtIXhtdSgGchP sKDvgxGb9YmMeOWpB54wwwZr8bb9QrPtoDjBXe43C7M9mailVLQZRIYpTecJ7ZiP 50R2TeI5fZHe870Z7XVSIYYp9EC3TDg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=YO5+i5s+k+tlJS1SVA+63w54Ngss5MoH2K6XLX2OA n8=; b=PXaM9aVstp+2wIR+eJThSVFmOqO9hlaiG7j3cuTlrV54UU25/kmVPPWND RJjpDlmieH804V9P5PRwduYqvBRYJwC1wqgcoioFwCN1sJZ6qXBjPy1pb6xjZLlU 7fJs9MhODV8eC1a1NxsHPMcZCVu84p8n8WCwIQVA7a73ADvwlvij6nLWbstRmbFk gR6vTClKbv9CPHJ7ExcL2O7Hzv7S1+8osrYTD8kC+tXFQYHQKMkNu2AbcpZ8J4wV bfcdf7i5e/PbYHuliX5CVjZ6TPoeq9soFmMqEyETLHaK40rrjmA9HreXJX6QIwQ9 9ozzUqKxpxgZOmgjJ33b+B7nWs4xQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrkedvgdeffecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 136753060D1A; Thu, 20 Feb 2020 06:51:22 -0500 (EST) From: Thomas Monjalon To: Nagadheeraj Rottela , Akhil Goyal Cc: dev@dpdk.org, "jsrikanth@marvell.com" Date: Thu, 20 Feb 2020 12:51:22 +0100 Message-ID: <4553285.yaVYbkx8dN@xps> In-Reply-To: References: <20200220110431.30074-1-rnagadheeraj@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] crypto/nitrox: fix coverity defects X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/02/2020 12:07, Akhil Goyal: > > > > Address the defects reported by coverity: Unintended sign extension > > and Out-of-bounds access. > > > > Coverity issue: 349899, 349905, 349911, 349921, 349923, 349926 > > > > Fixes: 32e4930d5a3b ("crypto/nitrox: add hardware queue management") > > Fixes: 9fdef0cc2385 ("crypto/nitrox: create symmetric cryptodev") > > > > Signed-off-by: Nagadheeraj Rottela > > --- > Thomas, > > Can you take this directly on master. No sorry, I can't because there is no review and test. And I think we should not have general patches for Coverity defects. Instead we must do one patch per issue. Here two: - sign of constants - out-of-bound access In each patch, we must have a description of the consequence of the issue. Thanks