From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id B53851B19 for ; Mon, 19 Feb 2018 17:18:54 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 64A5420910; Mon, 19 Feb 2018 11:18:54 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 19 Feb 2018 11:18:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=+Sn7YmQmMYxrsURKlA/DijsZxz yrkz1qTmymgwQM9W8=; b=Spe/x8JU4Bppuj6+UjB6rMjCxuefq/GQU4p0tJvT76 Od8b/laUY7Zu2ZGD0XzXiBHC0obHGj6UC2r9okeP3drkYuEuHOkzP4hdcTOAcqav Qp8KEfKrq8L9PWQ9xSWyNzQeL8yhGrWetuYTNAVxGwGK6aG/snSoxPGKg0N7hDc3 c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=+Sn7Ym QmMYxrsURKlA/DijsZxzyrkz1qTmymgwQM9W8=; b=AxUiXQcS0A+OxkurJZnrgL Q86m94nblM2nyRsy4j+8ZXoxi67CwsqfhuLUozGAoAV+h8+ZrSVcpi9Q2QrDYZFQ kaoYL/7X9xJwOlcMQbYX2Ed6uZsXZlUGMrLkV8IgLvpWJPAVbrnCTimnM+fRfon5 YZLqWsYtYkYbihD2AFmNLanZocwloyVY2dCHNdxirXHNCXZZhLdA/q5HaKePAjKW U607k9/SpCoJr/VhZjeN9rodnIypc6/oJ/2gBxHhC+r690BwTZxtlLMevJYTy7ZG 2GmQGmP5uj1KxP/acr5VazX0RUamyWZF19fzEVdtv8n4wgzNX5y+olnpDSOnC/VA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 19342240DD; Mon, 19 Feb 2018 11:18:54 -0500 (EST) From: Thomas Monjalon To: Matan Azrad , "Wiles, Keith" , Pavan Nikhilesh Cc: "jerin.jacob@caviumnetworks.com" , dev@dpdk.org Date: Mon, 19 Feb 2018 17:18:34 +0100 Message-ID: <4555376.PZvnTe3H9u@xps> In-Reply-To: References: <20180217104934.17291-1-pbhagavatula@caviumnetworks.com> <8522C580-BFB3-4D1B-A331-45DA05427D50@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/2] eal: add API to align integer to previous power of 2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Feb 2018 16:18:54 -0000 19/02/2018 15:13, Matan Azrad: > Hi Wiles > > From: Wiles, Keith, Monday, February 19, 2018 3:56 PM > > > On Feb 19, 2018, at 12:03 AM, Matan Azrad wrote: > > >> Is this the type of API that needs to be marked experimental, > > > > > > I think it is relevant to any exposed API(not only for internal libraries). > > > > > >> we should be able to prove these functions, correct? > > > > > > Don't we need to prove any function in DPDK? > > > What is your point? > > > > > > My point is this is a inline function and can not be placed in the .map file as a > > external API. > > Doesn't each API in .h file external? Why not? > If it shouldn't be external and should be in .h file, I think it should be marked as internal, no? > > > These simple type of APIs are easy to prove and making them > > experimental seems to just cause an extra step. > > As Thomas mentioned here: > https://dpdk.org/ml/archives/dev/2018-January/087719.html > > Any new API should be experimental. > > Thomas, Is it different for .h file inline APIs? No, it is not different for inline functions. If we are discussing the policy for every function, it is not a policy anymore :) It was agreed to notify the users of the new functions, so it gives time to confirm the function before making it "stable". Even if the function looks obvious, I think we should follow the policy. So, yes, please add the experimental tag.