From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40F55A0C57; Thu, 4 Nov 2021 17:17:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD2C441223; Thu, 4 Nov 2021 17:17:22 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id DB475411C9; Thu, 4 Nov 2021 17:17:18 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10157"; a="211787477" X-IronPort-AV: E=Sophos;i="5.87,209,1631602800"; d="scan'208";a="211787477" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2021 09:17:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,209,1631602800"; d="scan'208";a="561298230" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga004.fm.intel.com with ESMTP; 04 Nov 2021 09:17:17 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 4 Nov 2021 09:17:17 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 4 Nov 2021 09:17:16 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 4 Nov 2021 09:17:16 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 4 Nov 2021 09:17:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L+ceJuFLP14kH1Lq7p98t6u2s402rtsnZi99CZzGDm1lN4ucCu46UCj4KivayO2BoCzKa7doRctdfkvvlUkUwD+AjwOdKO1erRS2r+1iFfO+a50qHlLiVelzfgHiZjL5yYBUjlDdXyMpyiksMuwgnPcQN79AfnttFAG4F2KaTeC9FzYhPeyGiVUGA8oAhQHG4y1Yclj1l22r0/7UvDJXJR9U3lidFPPHZWChIQyDrPmsPVjDhw0m8XybClBCZQ1ILpdIUux0BjhZhbnO6YvIv5DXSI3hoUX+/mG6aMqB7ZEW80+WZr3Z+og3VRQjXRxMGFwTMzuBDWIgvA2ay8lzZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+E6f8ldEvb5X1vbPwQ5C19N3dayeKlAVoQpS1m0YAx0=; b=IBURVyfCc4xURAARr5HkMa12xljeeDIu1Gpu9tlt8De6e+vmOoUGkqvNcyViuul6ZUtiwUHIWLPhbkC+oic8L5OyDalyiWUqHywrW5s3YSjWrHhje7owXlbiNNnKo0Df1t/H4pxeNtcjZ5sXt0Y3Ux9R2DZFRZj4cl2RFtuFM0AS0JhJT0MBBPwQZa8kWHwkmOSMb/z03jjEZFETHC1B/+eTGO1FPdADutISqOQFk9AOVY+W6Qae9Vd1EPEIl/P2SDGU3jY/WNjVYbYHmSIJfIrxR5vxVHYAJOzqWLaKZ9O7ofADr7oFvXCjCc/Cm9GWBDW4izPPT1xp8RyVK5fdrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+E6f8ldEvb5X1vbPwQ5C19N3dayeKlAVoQpS1m0YAx0=; b=A9oWqbxqGFwzbYc3aC+dDe/hYaeyVMw+sRZVXY6gRy7hg2U19A+jzT+sK68t5+jKCC1X3lRBP+WvLgNfoZ+W/sV3jI947PxBAZrN8oKvLMjI58HjxRuOdFzCTsGzB9I/nYBMABVq6u7Qfsieg1l975q8xIADQsQwI1yH/tqEA28= Authentication-Results: trustnetic.com; dkim=none (message not signed) header.d=none;trustnetic.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4887.namprd11.prod.outlook.com (2603:10b6:510:30::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Thu, 4 Nov 2021 16:17:15 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%7]) with mapi id 15.20.4669.011; Thu, 4 Nov 2021 16:17:15 +0000 Message-ID: <455c9b4c-fbee-d91f-dffd-65df9324e688@intel.com> Date: Thu, 4 Nov 2021 16:17:09 +0000 Content-Language: en-US To: Jiawen Wu , CC: References: <20211102081026.22440-1-jiawenwu@trustnetic.com> <20211102081026.22440-2-jiawenwu@trustnetic.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211102081026.22440-2-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0118.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:192::15) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by LO4P123CA0118.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:192::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11 via Frontend Transport; Thu, 4 Nov 2021 16:17:14 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5278f0a0-a32b-44af-5aad-08d99fae90af X-MS-TrafficTypeDiagnostic: PH0PR11MB4887: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2803; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C6z/v+x8ReyHoBb/Y7muwRKJLUZYPjrR4fsGgCVph5Hi0FwnTte83PWwYKWsRCJpqoQj8XzY6e2MBZPYiO4VW9ViZ2hZ4mog9g79EesMFsf/SzG4B8gUb8l+CYZ6qG1rvmstHqZS5/TecVbMqfHvsaKCrlPAZB2HWF8HvXrx6YoO52VdLKB3O00G2dT5bHNPhY8Myb/qdptTR8DCzP5Ava7mhzs3EjaffcreMT2R0A4HNYHItgJusYqgIR3H0iZjFRTV3NjO5ELjUmMRu9gLxB5s8souNxt8c/InSeIUNOP67vYIedyqTfZoedROz+rf/gw9IXutzbonwt4y3JpF/89xBgz8NWiO23gMcJEdZNrBRQ4ZDCQJ8sJ2a3+urEh9f70hwNbLBiurJ+X9nLXFnhN6H7plO9oBPC06Cj/PGC3rmsxc9uJxvKQMQz4dstUdLhQFMojhTDiyjRFNtW6VxSC5rap3mURkYbZuhV7MLPE2guwfABMozB/j9foLsUXU7/Z17dBJqE0/617cIKpt5F2S6hq2PWumOqFb4mvkRUPpXrhfbOKr16A8ZeQw32vk13kOBzhm/QX6JGCpQQpDvpUnh6FitrgmNx456qe611SgXGCpLBy0BXmTgBGpVjGKfJwf4nQv48R4WxXSZWuFs+Ng+6KAKuusk65SpCC+Pd7hWm5tGIcrJGQWL7nbLRfgrT+wYpb32DHxxhQpqj7MMg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(31696002)(26005)(86362001)(6666004)(31686004)(508600001)(36756003)(186003)(83380400001)(53546011)(38100700002)(82960400001)(66476007)(66556008)(5660300002)(8676002)(8936002)(66946007)(4326008)(44832011)(2906002)(16576012)(6486002)(2616005)(316002)(956004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K2NoaStnRC9lblJnM0FuMENRcUNPMVRVekdRZXMvelNFMXNJcmRqTkEwMHU1?= =?utf-8?B?b1JyUjFsUlJlNGE5T0dlbG1qUFZNcFQvR09teEd0K0RtaEdKTUlTaGVSOHBi?= =?utf-8?B?WERwaEkwTEc0UDBRc24yVU5sd1AvcTIzVG9aVDRSaWx5NnZ5WEhWS3MvUXZ4?= =?utf-8?B?aTJIaFJGVlFsemJrV2Ftd3NTOGM4cEdQOWluRnAwYjBzVURibnZITWJtclJQ?= =?utf-8?B?T2VoblphcE4yRjJzTms4RUN2b00wNnhiWVdlNmpabVkweU1QRHV6OTlFQ3N4?= =?utf-8?B?Y3BReU9aNkJySFh4S1dJaWZVTjBwM2lzVTg3b01CeGhHRDJjVHkvWElqeGFm?= =?utf-8?B?MjkvOUJPUE1JOGUzeWg5SmhWeVJnUGZYay9ScnBsam9PemkyUEhGRWd6UTlW?= =?utf-8?B?TVlvQmJ1ajl6cmpIWGdzK0N5bDZqQysyR2QrcXlhb25hanA5M3ZwTnNXcjdL?= =?utf-8?B?WjRnbFVZejNMVnBGWFFINWwrbW1vMTUzZ1Z6QytaVUN4Tk9yQ2pJMVpuTm9a?= =?utf-8?B?RlJabFBlUnd5aXFoUDduQUt3aDdaRWVyTlhlRWVXd0FPKysvOVNENHl1bS90?= =?utf-8?B?ZmJac2Y3YkxsaWxFT2ZJbk9UQng3ajFqbVNjbU15WTBvQTdwM0dMVDM1UzBD?= =?utf-8?B?QmRoS0E4ampsTEc3UU1UcmtvUE11Q2RWc2UzRlErUEdHUDZjT1Nta1J5UHNQ?= =?utf-8?B?TjZhQ2lWQUZ4UUl6NTdTVys1OUZuZDRFSTVISFFaREsxelpzcVliUHFQdFda?= =?utf-8?B?aFlRVERLZ2FxMW1WZjkzaFpNeHh2U2wwcFFLblFoZWxRSlVseVlSTkdSK2tP?= =?utf-8?B?dlZGUkg5Q2tORXVDeU4yNHRPVGNtazNOQ1VyZ0F2R09FY0RKMUdFVFBnaXVP?= =?utf-8?B?UXdJRjZjSDM0blhxdmp5QWVTRHJoYTJDYTFMYWk0VVphY3M0Z2pLdU1aeWxE?= =?utf-8?B?bUFBTkx2Z1V5MUxxc3daNHZSYUdzeFhxekQ1alhkaGV5OTNkRFAwaE9wcjFm?= =?utf-8?B?WVBDc2VIWTI1NEVmME45ejRHM3U1eERIWUlwalNlbjlCckJ1VzBKQW8xc0sw?= =?utf-8?B?aWFPeVM4ekZXcEVReGI3SE95cVg4MXVZb1hHeHBRd3JOTnZJR0x3TEl1dUwz?= =?utf-8?B?WkZtTXZFc3FaTHN6R2Q5TVlsS0duQk5hREhjWFA1ZjlXWlNrQktxR285Uitz?= =?utf-8?B?cGcrTVpRTXJGYzE4MXU1L084OTFQcXlMMVRsZU9veTJaWkgxYU1CY1FNOHBy?= =?utf-8?B?WWxabnlZZTNCSVdFRTh0OWN4aUVnRmJqYVNhR2FVOVdGNkl2aHpUYXV5VFJS?= =?utf-8?B?QWkwWFVOb3QvbUxGYnFYMXJzRXFDSTVCTXVvZ2c3RnNYVnk5bWZCU25sck1m?= =?utf-8?B?TnQvMXdvZ2RzOHRnS3l6Ui9iRStrSEVCRjJMMWcxb1RwdUJxaW9MMFErclF5?= =?utf-8?B?U3RMMUlqRTl1Yk1QbVNWNHBXTStneHFSRG9rWmlHTXBGMEp6RGVDNmxWK09P?= =?utf-8?B?WTZ1US9oWHlDK2Q4UE1VNW1EWjBvYjVpR3V5TWErV2xzSENLbHBlQ200SlpR?= =?utf-8?B?YVJNandVblZEWU9veDZaa0ZRQ04yRlNJeHdKaHZxOHdVbXVUVUo1eHBFblY3?= =?utf-8?B?cEhJMGdSWk1IajZwa3FndEUyVklaMWRwemYwdWQvQThPNml5YWtxVjI1ZVMv?= =?utf-8?B?a2tWeTFQdUxnSXZiVm5WQXpYb1drdTRQSEFCcmszb0FMR3c5WFlrV3lTL0VG?= =?utf-8?B?d2s5eGZ3djNmMVpwMWRrMFJJdlFNekozcDJHTTZYcHk1WjFBMnBnaithclpH?= =?utf-8?B?SnI1TDZUYmQwUkFFQWFmNWIxYUhwR1RmNmpGMFFoK1J2T3NyOGVjYnRhUGly?= =?utf-8?B?cFJPaml3ai9IQVNDLzYvcUJ5MTl4MjU3ZkRpRElQUWt2Z1RuaE9rV0hzQThu?= =?utf-8?B?dTNtVUhUL05iQnhJS0lrOVEyQ20ybUF4MFdJSDVUOXJNdlVWOGdQa2g4S05Z?= =?utf-8?B?cUhhN0VSQkdZbXJDaFNtU0haVnNVaHJaMXprcVBqellkR05VY2V2L3FJc1M2?= =?utf-8?B?RnE3dVYrUVRlNlhUU0FpR0hyOVNMaXM4bG5JRFNnU09GVkt4MXZua0hPY2xq?= =?utf-8?B?aVR0T3JoOXY1QU12aytDcU43WmlUSGEwSjFMUjJVOFBDbndpeDVxbjQrSEZO?= =?utf-8?Q?7BK1R/4Pc35M/GdtDS5bX2Y=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5278f0a0-a32b-44af-5aad-08d99fae90af X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2021 16:17:15.4732 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XASS2MZrUQLB4Pyp1e7LqbVKIrvcaIVRhF8mnMUHTz4JSbt3RhNbm24jMiMO3g3xT7gclw0BMFAArn2Yvc0DfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4887 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] net/txgbe: fix link process in KR mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/2/2021 8:10 AM, Jiawen Wu wrote: > Set the 'present' parameter to 0 by default. It is configured by hardware, > users can set it to 1 for manual configuration. > > Fixes: f611dada1af8 ("net/txgbe: update link setup process of backplane NICs") > Cc: stable@dpdk.org > > Signed-off-by: Jiawen Wu > --- > drivers/net/txgbe/base/txgbe_phy.c | 2 +- > drivers/net/txgbe/txgbe_ethdev.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > Documentation also needs to be updated for this change. > diff --git a/drivers/net/txgbe/base/txgbe_phy.c b/drivers/net/txgbe/base/txgbe_phy.c > index 2db87ae0c5..3f5229ecc2 100644 > --- a/drivers/net/txgbe/base/txgbe_phy.c > +++ b/drivers/net/txgbe/base/txgbe_phy.c > @@ -1456,7 +1456,7 @@ txgbe_set_link_to_kr(struct txgbe_hw *hw, bool autoneg) > wr32_epcs(hw, SR_AN_CTRL, 0); > wr32_epcs(hw, VR_AN_KR_MODE_CL, 0); > } > - if (hw->devarg.present == 1) { > + if (hw->devarg.present == 1) { > value = rd32_epcs(hw, TXGBE_PHY_TX_EQ_CTL1); > value |= TXGBE_PHY_TX_EQ_CTL1_DEF; > wr32_epcs(hw, TXGBE_PHY_TX_EQ_CTL1, value); > diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c > index 169272ded5..8628ce455f 100644 > --- a/drivers/net/txgbe/txgbe_ethdev.c > +++ b/drivers/net/txgbe/txgbe_ethdev.c > @@ -495,7 +495,7 @@ txgbe_parse_devargs(struct txgbe_hw *hw, struct rte_devargs *devargs) > struct rte_kvargs *kvlist; > u16 auto_neg = 1; > u16 poll = 0; > - u16 present = 1; > + u16 present = 0; > u16 sgmii = 0; > u16 ffe_set = 0; > u16 ffe_main = 27; >