From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 75CAD4402B;
	Tue, 14 May 2024 13:30:34 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id BAA86402D1;
	Tue, 14 May 2024 13:30:33 +0200 (CEST)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mails.dpdk.org (Postfix) with ESMTP id 8E10840156
 for <dev@dpdk.org>; Tue, 14 May 2024 13:30:32 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DA4851007;
 Tue, 14 May 2024 04:30:56 -0700 (PDT)
Received: from [10.57.4.224] (unknown [10.57.4.224])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 344E13F641;
 Tue, 14 May 2024 04:30:31 -0700 (PDT)
Message-ID: <455e78ea-ad27-467e-ab3b-cfacb9de970e@arm.com>
Date: Tue, 14 May 2024 12:30:29 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] dts: update mypy static checker
Content-Language: en-GB
To: =?UTF-8?Q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>
Cc: dev@dpdk.org, Jeremy Spewock <jspewock@iol.unh.edu>,
 Paul Szczepanek <paul.szczepanek@arm.com>
References: <20240509105704.1162449-1-luca.vizzarro@arm.com>
 <20240509105704.1162449-2-luca.vizzarro@arm.com>
 <CAOb5WZaR0+Tj3uRVnxeA+OHMSotTWT4QNmsH_yiiMONepecUPg@mail.gmail.com>
From: Luca Vizzarro <Luca.Vizzarro@arm.com>
In-Reply-To: <CAOb5WZaR0+Tj3uRVnxeA+OHMSotTWT4QNmsH_yiiMONepecUPg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 13/05/2024 17:02, Juraj Linkeš wrote:
>>       def _filter_test_cases(
>>           self, test_suite_class: type[TestSuite], test_cases_to_run: Sequence[str]
>> -    ) -> tuple[list[MethodType], list[MethodType]]:
>> +    ) -> tuple[list[FunctionType], list[FunctionType]]:
> 
> Does changing inspect.getmembers(test_suite_class, inspect.isfunction)
> to use inspect.ismethod not work?

Nope, for some reason when running inspect.ismethod on the TestSuite 
class methods it returns False... I didn't investigate further, as just 
isfunction works and it's not a deal breaker.