From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 3745C1C4A for ; Mon, 1 May 2017 15:35:16 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6BBD4207C7; Mon, 1 May 2017 09:35:16 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 01 May 2017 09:35:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=sKitq3d1IdFuteA RmXmo3LSZVGdUmtVXLn3YaeYsq08=; b=HKJRWuDpwtRG1fEvj24I0ZOaTTytSrk WZQSaF+6iIYhKeRy9sM784h3y5n6Tld/rZ3Cjt7HlGMmCXgU06IM5qEyPu8z2dY6 yz/imIDNAm9MBc5q7HA+DkM7+20aiffQu7PgU6Tsh1wqrFc0ExYce5ypLRFRxNZx 9YXBZWMSb4tQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=sKitq3d1IdFuteARmXmo3LSZVGdUmtVXLn3YaeYsq08=; b=ARCqKy/e FSffOcKjmDimacRxSQjQVChoy+uWopFoO3tKvtH4/BJ5hfoSG2OKXAToMVQ49Sco jjfBLsEs5TeRQn21GW7zvn1qf5VK3XjdvKZE8pwOD8Dh45TahDUmThdnGlIDdEVA hexhZG3MJunRkxgUP570zShp1EpA8xbKxwhNua29VCjn8VWdcFME+HqsI+pYwW8d i5AnAtA0CTEOU1CLBJPNdlrMF4hxemcJoOO8nBUuDPOh4Ff9zsAxlrKA/kjJ8jlK wy6oy2Q1bgw4ZrcO42I2fx6EMYJHQjUo9Lqzsdgip8ewnb+y+ABaI40pi4oZc10D 3FAx+bdAqtrW2A== X-ME-Sender: X-Sasl-enc: dFW+vl+VadoeAl5G7pTMij6D9n43VO4efIOhFnUEJBnZ 1493645715 Received: from xps.localnet (245.114.118.80.rev.sfr.net [80.118.114.245]) by mail.messagingengine.com (Postfix) with ESMTPA id 931892473F; Mon, 1 May 2017 09:35:15 -0400 (EDT) From: Thomas Monjalon To: "Pei, Yulong" Cc: dev@dpdk.org, "Wu, Jingjing" Date: Mon, 01 May 2017 15:35:13 +0200 Message-ID: <4569052.iy7vOOdIzB@xps> In-Reply-To: <9BB6961774997848B5B42BEC655768F810D5A0CA@SHSMSX103.ccr.corp.intel.com> References: <1493344915-127542-1-git-send-email-yulong.pei@intel.com> <9BB6961774997848B5B42BEC655768F810D5A0CA@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] app/testpmd: initialize port_numa and ring_numa X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 May 2017 13:35:17 -0000 28/04/2017 10:30, Wu, Jingjing: > From: Pei, Yulong > > > > Previous numa_support = 0 by default, it need to add --numa to testpmd > > command line to enable numa, so port_numa and ring_numa were initialized at > > function launch_args_parse(), now testpmd change numa_support = 1 as default, > > so port_numa and ring_numa also need to initialize by default, otherwise port- > > >socket_id will be probed to wrong value. > > > > Fixes: 999b2ee0fe45 ("app/testpmd: enable NUMA support by default") > > > > Signed-off-by: Yulong Pei > > You forgot "fix" in title if the patch is fixing a problem. > Anyway, the change is OK. > Acked-by: Jingjing Wu Please rebase on top of http://dpdk.org/commit/3ab64341d and check if the patch needs to be reworked. The check of port_numa array below is weird. PS: please use --in-reply-to for v5.