[dpdk-dev] [PATCH] app/testpmd: fix testpmd initialization

[dpdk-dev] [PATCH] app/testpmd: fix testpmd initialization

[Anatoly Burakov]

Patch adding configurable locking has reshuffled some init stages, but
did not put them back in correct order. Fix order of init by moving
everything that was before arguments parsing into correct places.

Fixes: e505d84c64ab ("app/testpmd: make locking memory configurable")

Reported-by: Thomas Monjalon <thomas@monjalon.net>

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
 app/test-pmd/testpmd.c | 34 +++++++++++++++++-----------------
 1 file changed, 17 insertions(+), 17 deletions(-)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 664c435..6c3b64a 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -2646,6 +2646,23 @@ main(int argc, char** argv)
 		rte_panic("Cannot register log type");
 	rte_log_set_level(testpmd_logtype, RTE_LOG_DEBUG);
 
+#ifdef RTE_LIBRTE_PDUMP
+	/* initialize packet capture framework */
+	rte_pdump_init(NULL);
+#endif
+
+	nb_ports = (portid_t) rte_eth_dev_count_avail();
+	if (nb_ports == 0)
+		TESTPMD_LOG(WARNING, "No probed ethernet devices\n");
+
+	/* allocate port structures, and init them */
+	init_port();
+
+	set_def_fwd_config();
+	if (nb_lcores == 0)
+		rte_panic("Empty set of forwarding logical cores - check the "
+			  "core mask supplied in the command parameters\n");
+
 	/* Bitrate/latency stats disabled by default */
 #ifdef RTE_LIBRTE_BITRATE
 	bitrate_enabled = 0;
@@ -2671,23 +2688,6 @@ main(int argc, char** argv)
 			strerror(errno));
 	}
 
-#ifdef RTE_LIBRTE_PDUMP
-	/* initialize packet capture framework */
-	rte_pdump_init(NULL);
-#endif
-
-	nb_ports = (portid_t) rte_eth_dev_count_avail();
-	if (nb_ports == 0)
-		TESTPMD_LOG(WARNING, "No probed ethernet devices\n");
-
-	/* allocate port structures, and init them */
-	init_port();
-
-	set_def_fwd_config();
-	if (nb_lcores == 0)
-		rte_panic("Empty set of forwarding logical cores - check the "
-			  "core mask supplied in the command parameters\n");
-
 	if (tx_first && interactive)
 		rte_exit(EXIT_FAILURE, "--tx-first cannot be used on "
 				"interactive mode.\n");
-- 
2.7.4

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd initialization

[Ali Alnubani]

Tested-by: Ali Alnubani <alialnu@mellanox.com>

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Anatoly Burakov
> Sent: Monday, May 14, 2018 6:47 PM
> To: dev@dpdk.org
> Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>; Jingjing Wu
> <jingjing.wu@intel.com>; Thomas Monjalon <thomas@monjalon.net>;
> ferruh.yigit@intel.com
> Subject: [dpdk-dev] [PATCH] app/testpmd: fix testpmd initialization
> 
> Patch adding configurable locking has reshuffled some init stages, but did not
> put them back in correct order. Fix order of init by moving everything that
> was before arguments parsing into correct places.
> 
> Fixes: e505d84c64ab ("app/testpmd: make locking memory configurable")
> 
> Reported-by: Thomas Monjalon <thomas@monjalon.net>
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
>  app/test-pmd/testpmd.c | 34 +++++++++++++++++-----------------
>  1 file changed, 17 insertions(+), 17 deletions(-)
> 
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> 664c435..6c3b64a 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -2646,6 +2646,23 @@ main(int argc, char** argv)
>  		rte_panic("Cannot register log type");
>  	rte_log_set_level(testpmd_logtype, RTE_LOG_DEBUG);
> 
> +#ifdef RTE_LIBRTE_PDUMP
> +	/* initialize packet capture framework */
> +	rte_pdump_init(NULL);
> +#endif
> +
> +	nb_ports = (portid_t) rte_eth_dev_count_avail();
> +	if (nb_ports == 0)
> +		TESTPMD_LOG(WARNING, "No probed ethernet
> devices\n");
> +
> +	/* allocate port structures, and init them */
> +	init_port();
> +
> +	set_def_fwd_config();
> +	if (nb_lcores == 0)
> +		rte_panic("Empty set of forwarding logical cores - check the "
> +			  "core mask supplied in the command
> parameters\n");
> +
>  	/* Bitrate/latency stats disabled by default */  #ifdef
> RTE_LIBRTE_BITRATE
>  	bitrate_enabled = 0;
> @@ -2671,23 +2688,6 @@ main(int argc, char** argv)
>  			strerror(errno));
>  	}
> 
> -#ifdef RTE_LIBRTE_PDUMP
> -	/* initialize packet capture framework */
> -	rte_pdump_init(NULL);
> -#endif
> -
> -	nb_ports = (portid_t) rte_eth_dev_count_avail();
> -	if (nb_ports == 0)
> -		TESTPMD_LOG(WARNING, "No probed ethernet
> devices\n");
> -
> -	/* allocate port structures, and init them */
> -	init_port();
> -
> -	set_def_fwd_config();
> -	if (nb_lcores == 0)
> -		rte_panic("Empty set of forwarding logical cores - check the "
> -			  "core mask supplied in the command
> parameters\n");
> -
>  	if (tx_first && interactive)
>  		rte_exit(EXIT_FAILURE, "--tx-first cannot be used on "
>  				"interactive mode.\n");
> --
> 2.7.4

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd initialization

[Ananyev, Konstantin]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Anatoly Burakov
> Sent: Monday, May 14, 2018 4:47 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; thomas@monjalon.net; Yigit, Ferruh
> <ferruh.yigit@intel.com>
> Subject: [dpdk-dev] [PATCH] app/testpmd: fix testpmd initialization
> 
> Patch adding configurable locking has reshuffled some init stages, but
> did not put them back in correct order. Fix order of init by moving
> everything that was before arguments parsing into correct places.
> 
> Fixes: e505d84c64ab ("app/testpmd: make locking memory configurable")
> 
> Reported-by: Thomas Monjalon <thomas@monjalon.net>
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd initialization

[Thomas Monjalon]

> > Patch adding configurable locking has reshuffled some init stages, but did not
> > put them back in correct order. Fix order of init by moving everything that
> > was before arguments parsing into correct places.
> > 
> > Fixes: e505d84c64ab ("app/testpmd: make locking memory configurable")
> > 
> > Reported-by: Thomas Monjalon <thomas@monjalon.net>
> > 
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Tested-by: Ali Alnubani <alialnu@mellanox.com>

Applied, thanks