Re: [dpdk-dev] [PATCH v1 18/20] net/txgbe: hardware support for VF representor

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 1/22/2021 9:47 AM, Jiawen Wu wrote:
> Support to get link status and set mac address for VF representor.
> 
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>

<...>

> @@ -21,6 +21,7 @@ sources = files(
>   	'txgbe_rxtx.c',
>   	'txgbe_tm.c',
>   	'txgbe_vf_representor.c',
> +	'rte_pmd_txgbe.c'

This is adding PMD specific API, but with the port representor support, you 
should not need this API.

I can see some representor related funcitons are calling these APIs, but it is 
possible to move those functions and remove the 'rte_pmd_txgbe.[ch]' files.

>   )
>   
>   deps += ['hash', 'security']
> diff --git a/drivers/net/txgbe/rte_pmd_txgbe.c b/drivers/net/txgbe/rte_pmd_txgbe.c
> new file mode 100644
> index 000000000..c84233bd6
> --- /dev/null
> +++ b/drivers/net/txgbe/rte_pmd_txgbe.c
> @@ -0,0 +1,45 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2015-2020
> + */
> +
> +#include <rte_ethdev_driver.h>
> +

This header file renamed, it should be 'ethdev_driver'.