From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C0A9A052A; Tue, 2 Feb 2021 18:50:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 480B724038B; Tue, 2 Feb 2021 18:50:45 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 33E10240381 for ; Tue, 2 Feb 2021 18:50:44 +0100 (CET) IronPort-SDR: IflYwv6RW9xgzjAnjUvQ6s4A8RFJq7XT/vVoqp2W1s6sOINC14tlN/7I4bhUFErZ1nX/dKYJw+ DpoyqKx74dpQ== X-IronPort-AV: E=McAfee;i="6000,8403,9883"; a="199827207" X-IronPort-AV: E=Sophos;i="5.79,396,1602572400"; d="scan'208";a="199827207" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 09:50:39 -0800 IronPort-SDR: g82QbB9eCwx6OSrbWsmanknYfriOWD1em4lIyl5mkC6qZJvx38vnLwNCSqO72XhVQgkNazaVij bS9idmNc6u0A== X-IronPort-AV: E=Sophos;i="5.79,396,1602572400"; d="scan'208";a="391596224" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.226.112]) ([10.213.226.112]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 09:50:37 -0800 To: Jiawen Wu , dev@dpdk.org References: <20210122094800.197748-1-jiawenwu@trustnetic.com> <20210122094800.197748-19-jiawenwu@trustnetic.com> From: Ferruh Yigit Message-ID: <4578e6e0-284f-f416-7e4c-afca663766ed@intel.com> Date: Tue, 2 Feb 2021 17:50:36 +0000 MIME-Version: 1.0 In-Reply-To: <20210122094800.197748-19-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v1 18/20] net/txgbe: hardware support for VF representor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/22/2021 9:47 AM, Jiawen Wu wrote: > Support to get link status and set mac address for VF representor. > > Signed-off-by: Jiawen Wu <...> > @@ -21,6 +21,7 @@ sources = files( > 'txgbe_rxtx.c', > 'txgbe_tm.c', > 'txgbe_vf_representor.c', > + 'rte_pmd_txgbe.c' This is adding PMD specific API, but with the port representor support, you should not need this API. I can see some representor related funcitons are calling these APIs, but it is possible to move those functions and remove the 'rte_pmd_txgbe.[ch]' files. > ) > > deps += ['hash', 'security'] > diff --git a/drivers/net/txgbe/rte_pmd_txgbe.c b/drivers/net/txgbe/rte_pmd_txgbe.c > new file mode 100644 > index 000000000..c84233bd6 > --- /dev/null > +++ b/drivers/net/txgbe/rte_pmd_txgbe.c > @@ -0,0 +1,45 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2015-2020 > + */ > + > +#include > + This header file renamed, it should be 'ethdev_driver'.