From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D465A09E4; Thu, 28 Jan 2021 22:24:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B849140682; Thu, 28 Jan 2021 22:24:54 +0100 (CET) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by mails.dpdk.org (Postfix) with ESMTP id 88E7D4067A for ; Thu, 28 Jan 2021 22:24:53 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id BD21A5806A9; Thu, 28 Jan 2021 16:24:52 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 28 Jan 2021 16:24:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= punmB/AZtk2FQhifuhJrHzcjk5zLQjkfHSMR4v316WM=; b=qSk/OYJK/AOc1QvV vOy2+ehNSoynVMTkunAN4OR1p3P/dAPbdyMdkHWFrNvW33v5oGJWEZk+ZggPs0aE WqK3nWy7uIb03AocdObTR7dSZKJUABF6xn9XyvCRJQyaA17MvM8iexA6WYE+vMxQ hs2xoV5okjCqU2CwBW9jkD+PH+GtX0838N0DiSVGyOnlV0hIjJk8CwVN1tziR86t GluLAxV3oPfRvY7pO24PrPTW+tNsawAYesrFPQ6rwSLK9dCQuFJNnn8VonuntEuG nGwbI2yByHnOKLB0aXiOs7gw5rYN9sWhCkUamqhkYiwal0F17wjgBTbHT25JwtF3 zPOovg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=punmB/AZtk2FQhifuhJrHzcjk5zLQjkfHSMR4v316 WM=; b=WVw/mJyeTkJzRJcEKNL5B+w0hv2tFdQQgFRQCvAbMrWXnaOdLbp5QETfk SA0LV5cLMymKNGFwlqi79nfy6Xd7FX0lBkZmXcD+Fwt200RV6Yg8XhrQq0Dz1mO3 WAdjgTrb7c05VO0DSyC2rRshdOeLjU0TSXkKpp3wfWiA9eTUxY1oo7yJgycX8op5 qf9j6xU4C8ltHyxL9LFXc2VELpvrQQXKomJ95Q0lxPCX6ZgmbyCrxLpYrLG+3tdD qkLfWOJkfrZDewt5KKX4mv5u+rKC/3Sewa13g+JB09RD2kUryBcIH5LSXHE9szgY w5maysn8qtRR08jEdxRXljXujOJcw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedtgddugeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrd dvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 54D36108005B; Thu, 28 Jan 2021 16:24:50 -0500 (EST) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: Ferruh Yigit , dev@dpdk.org, "Rong, Leyi" , David Marchand , "Kadam, Pallavi" , dev@dpdk.org, Ali Alnubani , "Richardson, Bruce" , Tal Shnaiderman , Odi Assli , "Zhang, Qi Z" , "Lu, Wenzhuo" , "Xing, Beilei" , "Menon, Ranjit" , Raslan Darawsheh Date: Thu, 28 Jan 2021 22:24:48 +0100 Message-ID: <4580320.ODmCHreTiB@thomas> In-Reply-To: <20210128233522.0d803796@sovereign> References: <20201215021945.103396-1-leyi.rong@intel.com> <20210128233522.0d803796@sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 0/3] AVX512 vPMD on i40e X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/01/2021 21:35, Dmitry Kozlyuk: > On Tue, 26 Jan 2021 16:51:19 +0000, Ferruh Yigit wrote: > > On 1/26/2021 4:48 PM, Thomas Monjalon wrote: > > > 26/01/2021 17:39, Ferruh Yigit: > > >> On 1/26/2021 4:22 PM, Thomas Monjalon wrote: > > >>> 26/01/2021 17:17, Rong, Leyi: > > >>>>>> On 1/20/2021 11:21 PM, Ferruh Yigit wrote: > > >>>>>> > > >>>>>> And for the mingw, I have same result with Ali, I can reproduce with (Fedora > > >>>>> MinGW 9.2.1-6.fc32). > > >>>>>> > > >>>>>> But different from the CI, I am getting the error [1] for all following files: > > >>>>>> rte_random.c > > >>>>>> i40e_rxtx_vec_sse.c > > >>>>>> i40e_rxtx_vec_avx512.c > > >>>>>> i40e_rxtx_vec_avx2.c > > >>>>>> rte_ethdev.c > > >>> [...] > > >>>> Send patch https://patchwork.dpdk.org/patch/87349/ to disable avx512 on windows as the workaround. > > >>>> Pallavi also tested with this patch, and passed the mingw and clang build. Will try to see if has better way to fix. > > >>> > > >>> Ferruh mentioned errors with other files outside of i40e. > > >>> > > >> > > >> The patch globally disables the avx512 for windows cross build, not just for > > >> i40e, so I confirm it fixes the build errors in my environment. > > >> > > >> But disabling avx512 like this is not best option. > > > > > > Some may argue that AVX512 is not the best option ;) > > > > > > > flame war mode activated. > > I found the following fix working: > > --- a/drivers/net/i40e/meson.build > +++ b/drivers/net/i40e/meson.build > @@ -60,6 +60,9 @@ if arch_subdir == 'x86' > if cc.has_argument('-march=skylake-avx512') > avx512_args += '-march=skylake-avx512' > endif > + if is_windows and cc.get_id() == 'gcc' > + avx512_args += '-fno-asynchronous-unwind-tables' > + endif > i40e_avx512_lib = static_library('i40e_avx512_lib', > 'i40e_rxtx_vec_avx512.c', > dependencies: [static_rte_ethdev, > > It's admittedly from StackOverflow, but after reading about > -fno-asynchronous-unwind-tables I see no harm disabling it, at least for just > one file. Thanks, it will require some tests and approvals. For now, I take the patch proposing a simple disabling of AVX512 with MinGW.