From: Thomas Monjalon <thomas@monjalon.net>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ethdev: avoid usage of uninit device info in bad port case
Date: Tue, 23 Jul 2019 14:50:52 +0200 [thread overview]
Message-ID: <4582049.OHkX9IKj5f@xps> (raw)
In-Reply-To: <580e3eb6-6011-307c-5480-ffd9c7539b53@solarflare.com>
23/07/2019 14:16, Andrew Rybchenko:
> On 7/23/19 1:40 PM, Ferruh Yigit wrote:
> > On 7/23/2019 10:13 AM, Andrew Rybchenko wrote:
> >> rte_eth_dev_info_get() returns void and caller does know if the function
> >> does its job or not. Changing of the return value to int would be
> >> API/ABI breakage which requires deprecation process and cannot be
> >> backported to stable branches. For now, make sure that device info is
> >> initialized even in the case of invalid port ID.
> > +1 to return a status from function for long term.
>
> Thomas, what do you think? Should we finally fix it?
> I think it is almost harmless API/ABI breakage.
> If yes, I'll send deprecation notice to do it in v19.11.
Yes, generally speaking we should not have any void return in API.
next prev parent reply other threads:[~2019-07-23 12:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 9:13 Andrew Rybchenko
2019-07-23 10:40 ` Ferruh Yigit
2019-07-23 12:16 ` Andrew Rybchenko
2019-07-23 12:50 ` Thomas Monjalon [this message]
2019-07-23 12:11 ` [dpdk-dev] [PATCH v2] " Andrew Rybchenko
2019-07-23 13:14 ` Thomas Monjalon
2019-07-23 13:34 ` Andrew Rybchenko
2019-07-23 13:39 ` Thomas Monjalon
2019-07-23 18:45 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4582049.OHkX9IKj5f@xps \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).