From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ECE44425F3; Thu, 21 Sep 2023 11:36:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E7944026D; Thu, 21 Sep 2023 11:36:40 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 4AAB54014F for ; Thu, 21 Sep 2023 11:36:39 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 5C0565C0245; Thu, 21 Sep 2023 05:36:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 21 Sep 2023 05:36:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1695288996; x=1695375396; bh=54DhWK6Cq1U9r+WsLr3iIVLf/Y/767af/D7 +nCwiqoY=; b=Uzv+B0REuS3AETUdellIJCmV21/yxJR8w/kkbtbJaHS4HNRL8yt BFBONYpEraiy5GXTcQmEEUkgajLLvyDQQJKwlT5LTimt4pxOHkXOHOLP24RobQ/c c5Dz6SQcrlhE7xbMxdnw/bib7H4rIYsIubuUAEZiN+ffwgdIh9Il5n8WeV22qq1F ZzCcX9UmdAAYdcPH/3wpHMrYshBt7aCSeVovpUn/WPzWbyQQsfWaG0tdsARy+IaW cth8yY/Cr+FZtsdlpm4jPJFSn53t0t3bK9r2rt8FXLZ6pUqbzxwFQ8dZe2SPPRta OlQ+RwhycD9l1rKoHwH7k9UD4RotDVYeeDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1695288996; x=1695375396; bh=54DhWK6Cq1U9r+WsLr3iIVLf/Y/767af/D7 +nCwiqoY=; b=HkHm8H8mU3YMSXyd1P0BCxKuc5xuybLF10ow50J+V+SROXwDQMk MkOWQ5+3R9r/Ykmj6mQ72eePMfc1qWWbIZdR0khRq4qHxXEvGwiA8DlvRs92cPDb tFI8PgUuXceUqUEKeOSII5TRwxiuVMWfdwN6pqdJkgSvw/LL2JYPWaf0INKMxqlB ft6RykBkm/Yq3zVEJgGbPxCkd56+k4mhAVvi+Q5lztpRdqESwzINZSrnNwbqvqCr ChnhoDRDUB7D4HJypzOFF7hnuNzt0fkgjH9/xXjZ47aGkltcFl5uOS2HCiFBtGlf WSgS9AJU9pWv6sIBtqFEP+XCQq/LW1vr9Bw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudekiedgudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 21 Sep 2023 05:36:35 -0400 (EDT) From: Thomas Monjalon To: Tyler Retzlaff Cc: dev@dpdk.org, david.marchand@redhat.com, Stephen Hemminger Subject: Re: [PATCH v2] eal: provide per lcore macros for MSVC Date: Thu, 21 Sep 2023 11:36:32 +0200 Message-ID: <4582312.iZASKD2KPV@thomas> In-Reply-To: <20230831230812.GA31929@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1689024585-17303-1-git-send-email-roretzla@linux.microsoft.com> <2619168.k3LOHGUjKi@thomas> <20230831230812.GA31929@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 01/09/2023 01:08, Tyler Retzlaff: > On Thu, Aug 31, 2023 at 01:57:36PM +0200, Thomas Monjalon wrote: > > 11/07/2023 17:52, Tyler Retzlaff: > > > +#ifdef RTE_TOOLCHAIN_MSVC > > > /** > > > * Macro to define a per lcore variable "var" of type "type", don't > > > * use keywords like "static" or "volatile" in type, just prefix the > > > * whole macro. > > > */ > > > #define RTE_DEFINE_PER_LCORE(type, name) \ > > > - __thread __typeof__(type) per_lcore_##name > > > + __declspec(thread) typeof(type) per_lcore_##name > > > > > > /** > > > * Macro to declare an extern per lcore variable "var" of type "type" > > > */ > > > #define RTE_DECLARE_PER_LCORE(type, name) \ > > > + extern __declspec(thread) typeof(type) per_lcore_##name > > > +#else > > > +#define RTE_DEFINE_PER_LCORE(type, name) \ > > > + __thread __typeof__(type) per_lcore_##name > > > + > > > +#define RTE_DECLARE_PER_LCORE(type, name) \ > > > extern __thread __typeof__(type) per_lcore_##name > > > +#endif > > > > I'm afraid you damaged the doxygen document here. > > Please check what happens when generating doxygen. > > I suppose it does not take the RTE_TOOLCHAIN_MSVC path, > > so it does not find any comment. > > Thanks Thomas i will look into fixing it. Please can you send the fix?