From: Thomas Monjalon <thomas@monjalon.net>
To: Declan Doherty <declan.doherty@intel.com>
Cc: dev@dpdk.org, Jianbo Liu <jianbo.liu@linaro.org>,
Herbert Guan <herbert.guan@arm.com>
Subject: Re: [dpdk-dev] [PATCH] test: fix the parameter issue of test case
Date: Fri, 21 Jul 2017 09:42:26 +0300 [thread overview]
Message-ID: <4587531.0fQc3qA4qG@xps> (raw)
In-Reply-To: <CAP4Qi3-mOZVNXKErQQKhL0ra+aZS0sYAp77to5HHe2csHY_41A@mail.gmail.com>
Declan, you are the bonding maintainer, please confirm this fix.
13/07/2017 11:48, Jianbo Liu:
> On 13 July 2017 at 16:00, Herbert Guan <herbert.guan@arm.com> wrote:
> > When test case "test_balance_l23_tx_burst_ipv4_toggle_ip_addr" is
> > calling balance_l23_tx_burst(), the ip_addr instead of mac_addr
> > should be toggled according to the test name.
> >
> > Signed-off-by: Herbert Guan <herbert.guan@arm.com>
> > ---
> > test/test/test_link_bonding.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/test/test/test_link_bonding.c b/test/test/test_link_bonding.c
> > index aa2a1a2..12dd91d 100644
> > --- a/test/test/test_link_bonding.c
> > +++ b/test/test/test_link_bonding.c
> > @@ -2789,7 +2789,7 @@ struct rte_fdir_conf fdir_conf = {
> > static int
> > test_balance_l23_tx_burst_ipv4_toggle_ip_addr(void)
> > {
> > - return balance_l23_tx_burst(0, 1, 1, 0);
> > + return balance_l23_tx_burst(0, 1, 0, 1);
> > }
> >
> > static int
> > --
> > 1.8.3.1
> >
>
> Acked-by: Jianbo Liu <jianbo.liu@linaro.org>
>
next prev parent reply other threads:[~2017-07-21 6:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 8:00 Herbert Guan
2017-07-13 8:48 ` Jianbo Liu
2017-07-21 6:42 ` Thomas Monjalon [this message]
2017-07-25 9:46 ` Declan Doherty
2017-07-31 15:34 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4587531.0fQc3qA4qG@xps \
--to=thomas@monjalon.net \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=herbert.guan@arm.com \
--cc=jianbo.liu@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).