* [dpdk-dev] [PATCH] test: fix the parameter issue of test case
@ 2017-07-13 8:00 Herbert Guan
2017-07-13 8:48 ` Jianbo Liu
2017-07-25 9:46 ` Declan Doherty
0 siblings, 2 replies; 5+ messages in thread
From: Herbert Guan @ 2017-07-13 8:00 UTC (permalink / raw)
To: dev, declan.doherty, jianbo.liu; +Cc: Herbert Guan
When test case "test_balance_l23_tx_burst_ipv4_toggle_ip_addr" is
calling balance_l23_tx_burst(), the ip_addr instead of mac_addr
should be toggled according to the test name.
Signed-off-by: Herbert Guan <herbert.guan@arm.com>
---
test/test/test_link_bonding.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/test/test_link_bonding.c b/test/test/test_link_bonding.c
index aa2a1a2..12dd91d 100644
--- a/test/test/test_link_bonding.c
+++ b/test/test/test_link_bonding.c
@@ -2789,7 +2789,7 @@ struct rte_fdir_conf fdir_conf = {
static int
test_balance_l23_tx_burst_ipv4_toggle_ip_addr(void)
{
- return balance_l23_tx_burst(0, 1, 1, 0);
+ return balance_l23_tx_burst(0, 1, 0, 1);
}
static int
--
1.8.3.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] test: fix the parameter issue of test case
2017-07-13 8:00 [dpdk-dev] [PATCH] test: fix the parameter issue of test case Herbert Guan
@ 2017-07-13 8:48 ` Jianbo Liu
2017-07-21 6:42 ` Thomas Monjalon
2017-07-25 9:46 ` Declan Doherty
1 sibling, 1 reply; 5+ messages in thread
From: Jianbo Liu @ 2017-07-13 8:48 UTC (permalink / raw)
To: Herbert Guan; +Cc: dev, Declan Doherty
On 13 July 2017 at 16:00, Herbert Guan <herbert.guan@arm.com> wrote:
> When test case "test_balance_l23_tx_burst_ipv4_toggle_ip_addr" is
> calling balance_l23_tx_burst(), the ip_addr instead of mac_addr
> should be toggled according to the test name.
>
> Signed-off-by: Herbert Guan <herbert.guan@arm.com>
> ---
> test/test/test_link_bonding.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/test/test_link_bonding.c b/test/test/test_link_bonding.c
> index aa2a1a2..12dd91d 100644
> --- a/test/test/test_link_bonding.c
> +++ b/test/test/test_link_bonding.c
> @@ -2789,7 +2789,7 @@ struct rte_fdir_conf fdir_conf = {
> static int
> test_balance_l23_tx_burst_ipv4_toggle_ip_addr(void)
> {
> - return balance_l23_tx_burst(0, 1, 1, 0);
> + return balance_l23_tx_burst(0, 1, 0, 1);
> }
>
> static int
> --
> 1.8.3.1
>
Acked-by: Jianbo Liu <jianbo.liu@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] test: fix the parameter issue of test case
2017-07-13 8:48 ` Jianbo Liu
@ 2017-07-21 6:42 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2017-07-21 6:42 UTC (permalink / raw)
To: Declan Doherty; +Cc: dev, Jianbo Liu, Herbert Guan
Declan, you are the bonding maintainer, please confirm this fix.
13/07/2017 11:48, Jianbo Liu:
> On 13 July 2017 at 16:00, Herbert Guan <herbert.guan@arm.com> wrote:
> > When test case "test_balance_l23_tx_burst_ipv4_toggle_ip_addr" is
> > calling balance_l23_tx_burst(), the ip_addr instead of mac_addr
> > should be toggled according to the test name.
> >
> > Signed-off-by: Herbert Guan <herbert.guan@arm.com>
> > ---
> > test/test/test_link_bonding.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/test/test/test_link_bonding.c b/test/test/test_link_bonding.c
> > index aa2a1a2..12dd91d 100644
> > --- a/test/test/test_link_bonding.c
> > +++ b/test/test/test_link_bonding.c
> > @@ -2789,7 +2789,7 @@ struct rte_fdir_conf fdir_conf = {
> > static int
> > test_balance_l23_tx_burst_ipv4_toggle_ip_addr(void)
> > {
> > - return balance_l23_tx_burst(0, 1, 1, 0);
> > + return balance_l23_tx_burst(0, 1, 0, 1);
> > }
> >
> > static int
> > --
> > 1.8.3.1
> >
>
> Acked-by: Jianbo Liu <jianbo.liu@linaro.org>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] test: fix the parameter issue of test case
2017-07-13 8:00 [dpdk-dev] [PATCH] test: fix the parameter issue of test case Herbert Guan
2017-07-13 8:48 ` Jianbo Liu
@ 2017-07-25 9:46 ` Declan Doherty
2017-07-31 15:34 ` Ferruh Yigit
1 sibling, 1 reply; 5+ messages in thread
From: Declan Doherty @ 2017-07-25 9:46 UTC (permalink / raw)
To: Herbert Guan, dev, jianbo.liu
On 13/07/2017 9:00 AM, Herbert Guan wrote:
> When test case "test_balance_l23_tx_burst_ipv4_toggle_ip_addr" is
> calling balance_l23_tx_burst(), the ip_addr instead of mac_addr
> should be toggled according to the test name.
>
> Signed-off-by: Herbert Guan <herbert.guan@arm.com>
> ---
> test/test/test_link_bonding.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/test/test_link_bonding.c b/test/test/test_link_bonding.c
> index aa2a1a2..12dd91d 100644
> --- a/test/test/test_link_bonding.c
> +++ b/test/test/test_link_bonding.c
> @@ -2789,7 +2789,7 @@ struct rte_fdir_conf fdir_conf = {
> static int
> test_balance_l23_tx_burst_ipv4_toggle_ip_addr(void)
> {
> - return balance_l23_tx_burst(0, 1, 1, 0);
> + return balance_l23_tx_burst(0, 1, 0, 1);
> }
>
> static int
>
Acked-by: Declan Doherty <declan.doherty@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] test: fix the parameter issue of test case
2017-07-25 9:46 ` Declan Doherty
@ 2017-07-31 15:34 ` Ferruh Yigit
0 siblings, 0 replies; 5+ messages in thread
From: Ferruh Yigit @ 2017-07-31 15:34 UTC (permalink / raw)
To: Declan Doherty, Herbert Guan, dev, jianbo.liu
On 7/25/2017 10:46 AM, Declan Doherty wrote:
> On 13/07/2017 9:00 AM, Herbert Guan wrote:
>> When test case "test_balance_l23_tx_burst_ipv4_toggle_ip_addr" is
>> calling balance_l23_tx_burst(), the ip_addr instead of mac_addr
>> should be toggled according to the test name.
Fixes: 92073ef961ee ("bond: unit tests")
Cc: stable@dpdk.org
>>
>> Signed-off-by: Herbert Guan <herbert.guan@arm.com>
Acked-by: Jianbo Liu <jianbo.liu@linaro.org>
> Acked-by: Declan Doherty <declan.doherty@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-07-31 15:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-13 8:00 [dpdk-dev] [PATCH] test: fix the parameter issue of test case Herbert Guan
2017-07-13 8:48 ` Jianbo Liu
2017-07-21 6:42 ` Thomas Monjalon
2017-07-25 9:46 ` Declan Doherty
2017-07-31 15:34 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).