From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2BB10A00BE; Tue, 3 May 2022 21:06:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2104940E2D; Tue, 3 May 2022 21:06:07 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2089.outbound.protection.outlook.com [40.107.220.89]) by mails.dpdk.org (Postfix) with ESMTP id 4675640691 for ; Tue, 3 May 2022 21:06:05 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GsmzlKk0p0YsJwfiJDOsKFLIv9IEiNy1nCEUgzwBc8P5iGO7BB6X3ynpzHYPjiyNjSvUrIrkn7/zAHrwTjif83jp1nwTdIQ2bJgYNRm40LhbUqm91oWv7pw93IYbwTCzcQG9ZGx95reJLk4OD0UiUG3x0bJN7qNQch9ZCPT1mitjC3HOqz6EmuycCk5xFgZDVM0+CYzUWxQv5HqHYSnpUauQsUIMMA4vxiz+sLLS6LXKRvkqt4FwUyO9kQE7xNNj26lbi6h7KWNj2AZH/VJ4pDPvreGT1FtY7MaIx521HcKitZ1VQNz4JfoOjyKTsm/FPOqmhnNh7EQma32htSSkeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CLulsOuxTvAWUMf6E9tEQHmuQlQF8ztxvllDXP88m+4=; b=VByJTS06bAZ+cMuGE+MRfVpCTvckFtCVKuv1WArS8yhr7c8dZMr68tnzU8tGVanEhRaRiQJzFH7AOGkr+ATXIPTZL0Odp6jy8ttRVjrk4xDfeWJLuL7jFMrI08Pr1gSzHWTecMRiGqMuMl5/0rNQ57NrFWnquBI7Pvqru9vTAljO4F4Mrl3ZZPEkYgVBFdCjDd7ftWGP0RHcDtfaRn4ThRZ/wXbze6qf2nbsgsVZdTJ/o3JtQj69ZrRXVrvyIIHyrQS1VE7REgcTTa2oHtU+I8ti7J4CylKawRGaMYTdJTVAuNrm0m7d2bs/JS0J/Gfk+53raR3LCtzYLKAPt7cNZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=huawei.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CLulsOuxTvAWUMf6E9tEQHmuQlQF8ztxvllDXP88m+4=; b=IUL5Op/8QWXkLLZ+96RTv1jv4LnGjSirGkuM/fAemuGbwf/Y8+KSPXygNNpKG/Adlq1oMdGYcm+mfzZkb7DGJiIBjMklnND0n9fYrlmFN5oO85Kt4WSBa3+4BT3XoWl+RwqvXK9Nxh74EKtq4idufR7ybK6ZsS8T+vBhceuxt7Q= Received: from BN0PR03CA0033.namprd03.prod.outlook.com (2603:10b6:408:e7::8) by CY4PR02MB2853.namprd02.prod.outlook.com (2603:10b6:903:127::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Tue, 3 May 2022 19:06:03 +0000 Received: from BN1NAM02FT054.eop-nam02.prod.protection.outlook.com (2603:10b6:408:e7:cafe::79) by BN0PR03CA0033.outlook.office365.com (2603:10b6:408:e7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12 via Frontend Transport; Tue, 3 May 2022 19:06:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by BN1NAM02FT054.mail.protection.outlook.com (10.13.2.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5206.12 via Frontend Transport; Tue, 3 May 2022 19:06:00 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 3 May 2022 20:06:00 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Tue, 3 May 2022 20:06:00 +0100 Envelope-to: humin29@huawei.com, dev@dpdk.org, thomas@monjalon.net Received: from [10.71.119.91] (port=63440) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nlxqR-00010T-6v; Tue, 03 May 2022 20:06:00 +0100 Message-ID: <458f5e55-8e3f-c319-22bd-a4d941ab0cc3@xilinx.com> Date: Tue, 3 May 2022 20:05:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 5/7] net/hns3: fix RSS disable Content-Language: en-US To: "Min Hu (Connor)" , CC: References: <20220406092240.52900-1-humin29@huawei.com> <20220406092240.52900-6-humin29@huawei.com> From: Ferruh Yigit In-Reply-To: <20220406092240.52900-6-humin29@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 07928061-0e83-41d1-500b-08da2d37f6a7 X-MS-TrafficTypeDiagnostic: CY4PR02MB2853:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vPDmb9kvjJWF0Fblzjxmt0nZRdl91RLI+yk0KLO/a0R9J1wjfLIb6SFIl5D+ylaiAvzfQur0D0F7cnAB0XvgMDSM8fQ9BJbOKGtI/lDy6Jxh6sWxp9dv64KhUvoFBiJjrM/k2Q1Z/OVVDCZjFx6uADvMwmO4ig+ANyGDqdVqoSMi3D3HO18iPsu6ApxqRnAcwvMI4Ir/wuQZPuSzfZnCcVSPzRwi0Rrk7l8rOAYCD3ooD8SbxGmCqhLjhha5VUBnShLIAeFcXBvf9MiojAiXbggKzbSODmj3i2rQgSv1OB39YT6daT5U5BtI+rHyvpxYUKacZ57xJm4vxN4LgFtql9CtMjU53+Z41i29rJ3ccdcN1ds60oIj6D1gntUl6W8xjrWSfTKdYTrPvc+DFh2a1oaa/jNqiAAEiGLhdwYlRL3iQQ3ml7++ef/jjdOApLRFTPDIiuQnN989C2kz55ARA3T1+U1UUXV7b/DTcAkg8Oq62bogTGReTogfVi14ecZYTYil5PaTXJbuNISLay1E63Nwo4ZRU8STnl9tJurMWxmkrfYO0Cgx6cB7lcS5PoIbDR1zI3I6pgw9dMVmHMMiYo4S85D3geQrUmzoIglCLj/qKB9f/sSpItds/8pWGDBH5+Uyl/4qJC2Vygs/1vUWnsIbcfITBLhqz8tOHVnfaxkqvdCCQyxIgEPJEu7lS433HQ28i9HZlXcPsCCNJZLXSexiybp+lP0Xyj/n9N/kfCk= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(7636003)(44832011)(508600001)(5660300002)(26005)(356005)(4326008)(8676002)(83380400001)(36860700001)(31686004)(82310400005)(31696002)(2616005)(426003)(4744005)(186003)(316002)(9786002)(53546011)(36756003)(8936002)(336012)(40460700003)(47076005)(70586007)(70206006)(110136005)(2906002)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 19:06:00.9239 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 07928061-0e83-41d1-500b-08da2d37f6a7 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT054.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR02MB2853 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/6/2022 10:22 AM, Min Hu (Connor) wrote: > From: Huisong Li > > Currently, hns3 PMD disable RSS by resetting redirection table when user > set rss_hf to 0 so as to all packets go to queue 0. The implementation may > cause following problems: > 1) the same type packet may go to different queue on the case of disableing typo, disabling > all tuples and partial tuples. The problem is determined by hardware > design. > 2) affect the configuration of redirection table and user experience. > > For hns3 hardware, the packets with RSS disabled are always go to the queue > corresponding to first entry of the redirection table. Genernally, disable typo, generally > RSS should be implemented by disabling all tuples, This patch fix the > implementation. > ack > Fixes: c37ca66f2b27 ("net/hns3: support RSS") > Cc: stable@dpdk.org > > Signed-off-by: Huisong Li > Signed-off-by: Min Hu (Connor) <...>