From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 057884326D; Thu, 2 Nov 2023 11:48:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8205540282; Thu, 2 Nov 2023 11:48:59 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 592FA40262; Thu, 2 Nov 2023 11:48:58 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9DD245C01A6; Thu, 2 Nov 2023 06:48:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 02 Nov 2023 06:48:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1698922137; x=1699008537; bh=2f2HWLx90PRa4M9NZ7kYPyp2tbu4+R2rThK sjm8s1AQ=; b=SDC30IbZiFE1ssCCUaOoXss5Szz7AaWUnOLe3gxtJ069yR6QzDy 7TKMo5zEW1XEN01ef9vZ8/prujZGs9cq0uV8FF/KuwoBI8GdY7ZjhUJCOXV5uITm pPfQ5Uo62W5yuUxsQRx2x/CWD0ZMRVoBmBcUhh2mDihpH3iBuYOJPhidBgcK1o3F j7l2fk4OwfqUnCRGSl8xEyDv/hv/ludQRNuu0lM1LlTriTD0fi6yeFqdkz5Rk4qM kp3yuufayfx4QOtGQ6dR/gIT6Kkoqmn67ydF6nHBCIH6+oUnPQYs3jv4BHeZms9u JFq/mCZ9al+rS+PtKZ6vqky4igxVipjVBkQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1698922137; x=1699008537; bh=2f2HWLx90PRa4M9NZ7kYPyp2tbu4+R2rThK sjm8s1AQ=; b=bemN6kGmrBnejvXbHuyP/L7lyNqGr/n+UZKneL22HbLAmeVJZ+F TztxJroMurTo8B3JXVNQ8DoRQXm7EfZw9CvDPbSS31kUrE2KJyBxVaZe8XNxPmkw QSBVy/+5m2ug3d7BVnYDglxJr9gepK0YWvpH1U+A60UEesElWKPGP6lMT5oPFH7i uPYKxc1t2EhdpKbE3g8REGqALeYygBEuYgQqJUUrWZd12qhgqdISAMdsV9G5IWnT OuzQgiRht2Ce2cJLi/R5MTeqVOI5Ps3MxuO/0BQ8Lb93Nw9izv8Yl3xFLm5utUMM 5/JH0VIO9tkLeWwd/SYEzLQNWwg8KMiWLMQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddtiedgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeejjefffffgffekfefflefgkeelteejffelledugefhheelffet heevudffudfgvdenucffohhmrghinhepughpughkrdhorhhgnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 2 Nov 2023 06:48:55 -0400 (EDT) From: Thomas Monjalon To: "Sevincer, Abdullah" , Bruce Richardson Cc: Jerin Jacob , "dev@dpdk.org" , "jerinj@marvell.com" , "Chen, Mike Ximing" , "stable@dpdk.org" , "Marchand, David" , "Xia, Chenbo" , "nipun.gupta@amd.com" Subject: Re: [PATCH v3] event/dlb2: fix disable PASID for kernel 6.2 Date: Thu, 02 Nov 2023 11:48:52 +0100 Message-ID: <45918392.fMDQidcC6G@thomas> In-Reply-To: References: <20230607210050.107944-1-abdullah.sevincer@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 02/11/2023 11:23, Bruce Richardson: > On Wed, Nov 01, 2023 at 07:05:54PM +0000, Sevincer, Abdullah wrote: > > > > >++ PCIe maintainers. > > > > >+I will leave this up to @David Marchand / @Thomas as this patch has common code changes and needs to come via main tree. > > > > >+Also in this case, The comment was given very early(Back in June 7) for the same. > > >+https://patches.dpdk.org/project/dpdk/patch/20230607210050.107944-1-abdullah.sevincer@intel.com/ > > > > Thanks Jerrin and Bruce for the comments. > > I will wait for opinion of PCI maintainers. > > Thinking on this more, any API for enable/disable pasid would be > internal-only, so therefore would not be subject to ABI/API change rules > AFAIK. This gives us more freedom to change it as more discovery > capabilities become available. > Therefore, an initial version of the function can take the offset as > parameter, and we can update it without API/ABI concerns later. I was > previously worried about trying to get the API correct first time, but for > internal functions, we don't need to. It looks a good option. Better to add an internal PCI function than doing it in a PMD. > WDYT, Jerin, Abdullah.