From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id 823E0C3DC for ; Sun, 2 Aug 2015 22:45:57 +0200 (CEST) Received: by wicmv11 with SMTP id mv11so112693615wic.0 for ; Sun, 02 Aug 2015 13:45:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=ZIk5WRUdD5BLTmUno3gmk+ZQnUpdRvacwTlY5APEwws=; b=dr6N2wbH0+UKw6elhY7HUU0TwXGWEd+IoLe4PYrMNmx+9VxboIwCrH8aRhSVj7Gu0n Jrhwr6GBOJlkspnRn1YJ3z6cTaQnIzQTQKADtnm2Tl2EPlzuX9moa9Ju9OdKpUac4/Su DVI49pZxz+hlL/YHXmMzodTSv8YhYmUway20gx26ekTGVA1Zwf1dbWCV3eVUTIGq/9m/ 5EOQ5DDHmKkCv20pLQgGFqnZB5BqDa+PaoQfQJRGQq5Rt/aKgDBVQWr7BYrh70RTYy2U SEGVbXMV7vINsszE+xTAa3uhD1KtlWMD7te78WkSzTHDNIfP/ojbMzaIvTGJf+qlpu0X zGLA== X-Gm-Message-State: ALoCoQnUnEcN/eV9IHPuuBwftfbYT1cxVTM7Hf0FuTgGOPhHJHwfDoIjep5SX+geE/iCuCMT+9DF X-Received: by 10.194.203.138 with SMTP id kq10mr29279155wjc.124.1438548356362; Sun, 02 Aug 2015 13:45:56 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id fb3sm9896002wib.21.2015.08.02.13.45.53 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 02 Aug 2015 13:45:55 -0700 (PDT) From: Thomas Monjalon To: "Wiles, Keith" Date: Sun, 02 Aug 2015 22:44:39 +0200 Message-ID: <4594355.leWO83I6KL@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: References: <1433635446-78275-1-git-send-email-keith.wiles@intel.com> <6687423.9WN7KrYfak@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] log:Change magic number on RTE_LOG_LEVEL to a define X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Aug 2015 20:45:57 -0000 2015-08-02 19:10, Wiles, Keith: > On 8/2/15, 12:15 PM, "Thomas Monjalon" wrote: > >2015-06-06 19:04, Keith Wiles: > >> +# Log level use: RTE_LOG_XXX > >> +# XXX = NOOP, EMERG, ALERT, CRIT, ERR, WARNING, NOTICE, INFO or DEBUG > >> +# Look in rte_log.h for others if any. > >> +# > > > >I think this comment is useless. > > I do not think the comment is useless as some may not understand what > values the Log level can be set too in the future. Not commenting the > change would be a problem IMO. This is also why the line was moved. It is already documented in the API doc. I agree having some comments in the config files would be convenient but: - this one is 3 lines long - currently comments are only used to separate sections Maybe you can do a oneline: # Minimum log level compiled: DEBUG, INFO, NOTICE, WARNING or ERR I think it is important to tell it is a minimum log level, i.e. compiled logs. And probably it is not needed to suggest a minimum level higher than ERR. > >> +enum { > >> + RTE_LOG_NOOP = 0, /**< Noop not used (zero entry) */ > > > >NOOP is useless: EMERG may be = 1 > > Does it really matter if I used RTE_LOG_NOOP, just to make sure someone > did not try to use zero here. Instead of setting the RTE_LOG_EMERG=1, I > can change it to be the way you suggest, but I think it does not hurt > anything does it? We avoid adding code without real use which could cause confusion. > >> + RTE_LOG_EMERG, /**< System is unusable. */ > >> + RTE_LOG_ALERT, /**< Action must be taken immediately. */ > >> + RTE_LOG_CRIT, /**< Critical conditions. */ > >> + RTE_LOG_ERR, /**< Error conditions. */ > >> + RTE_LOG_WARNING, /**< Warning conditions. */ > >> + RTE_LOG_NOTICE, /**< Normal but significant condition. */ > >> + RTE_LOG_INFO, /**< Informational. */ > >> + RTE_LOG_DEBUG /**< Debug-level messages. */ > >> +}; > > > >What is the benefit of this change? > > The change is to use a enum in place of using magic numbers, plus you get > the benefit of seeing the enum name in the debugger instead of a number. > It makes the code more readable IMHO. OK so a comment in the commit message could give the debugger justification.