From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id B244FC49A for ; Fri, 24 Jun 2016 16:19:35 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id a66so27608801wme.0 for ; Fri, 24 Jun 2016 07:19:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=RexYMUpHhC9p+br0OVb+VYrRjm8uUlo/eWpJYk7fxPo=; b=YW0GsIqpX3lbD3E9h+Skr0L2C+N7m7BCLULuDRbxTbloq+chBsP2WfEPZuMJ9S7yKM 3+Ny5omciKHZYTORJ2BNtDxFWcF4/gv7CaHZtrF7pny0/sl0L9oHo1r70uukNLs8Xmkc Y6qE5oaIyCDpzOrbDz6FKO/ea8Ni6J4duDOZAmTPPwVtLmdqvCunsoRE2p0zydVwUJ6W OT5y/6NBCu8ZqK8f3gnyCuSscosTePDJ6Cu48+2TW1wPd4vE52xRwez+9jvjOPrxb91p Lo7lXEub2a1UHBfYpzG/Wc2ul3e1/EQ3kRPH/sS0lUIPJrgOYchmR1cJOudqiNa1VOAz ZAww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=RexYMUpHhC9p+br0OVb+VYrRjm8uUlo/eWpJYk7fxPo=; b=Ze+kBKDiBSqSFdrfNI8aIug+Cl7kVT61kCzsCotQEUpFzMlrT/fIaa96HPThG5zhlf LX/Zb+iPl/wz55dLvrLmO/cD6R6n0zj8KiYu/oiEXIMHDrU/pakvVBJfSdt0Vw8MWfRy Y6gXsXnjybGbfbUC5RbHK2gcuEVsdZJ0dc3VknM+CR7x1k8HxmDm5EQlCX6ZTnpWivu7 TKi9hQL4wUrLmBzze8f4CfeIt6LWAwLWkfguTP+9vbPUQrX5eYXlVoUAaWy3ABb//XxW 2CX486QtiPqhk2ivySy4p2M+Sf2smNSif+5ZIffp9eCdlaoaHASzZSElw7wFpgwKdYZw +Scw== X-Gm-Message-State: ALyK8tIDRDvFeltGJ9Bxmtjeb/ajNc2CySnb6GCN12Nxyrvrkw4zIwJi7/pFexPS8YNb2XPa X-Received: by 10.28.43.2 with SMTP id r2mr6153879wmr.33.1466777975518; Fri, 24 Jun 2016 07:19:35 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id r16sm3328329wmb.23.2016.06.24.07.19.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Jun 2016 07:19:34 -0700 (PDT) From: Thomas Monjalon To: Olivier Matz Cc: dev@dpdk.org Date: Fri, 24 Jun 2016 16:19:34 +0200 Message-ID: <4598761.R2uGCUsYnI@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <576D3E5A.6060108@6wind.com> References: <1466721363-24546-1-git-send-email-thomas.monjalon@6wind.com> <1466767379-7552-1-git-send-email-thomas.monjalon@6wind.com> <576D3E5A.6060108@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] mk: fix parallel build of test resources X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2016 14:19:35 -0000 2016-06-24 16:06, Olivier Matz: > Hi Thomas, > > On 06/24/2016 01:22 PM, Thomas Monjalon wrote: > > --- a/app/test/Makefile > > +++ b/app/test/Makefile > > @@ -43,14 +43,14 @@ define linked_resource > > SRCS-y += $(1).res.o > > $(1).res.o: $(2) > > @ echo ' MKRES $$@' > > - $Q ln -fs $$< resource.tmp > > + $Q [ "$$( > Maybe the symbolic link file in the build directory could be prefixed > with "lnk_"... (see following below) yes... > > $Q $(OBJCOPY) -I binary -B $(RTE_OBJCOPY_ARCH) -O $(RTE_OBJCOPY_TARGET) \ > > --rename-section \ > > .data=.rodata,alloc,load,data,contents,readonly \ > > - --redefine-sym _binary_resource_tmp_start=beg_$(1) \ > > - --redefine-sym _binary_resource_tmp_end=end_$(1) \ > > - --redefine-sym _binary_resource_tmp_size=siz_$(1) \ > > - resource.tmp $$@ && rm -f resource.tmp > > + --redefine-sym _binary_$$(subst .,_,$$( > + --redefine-sym _binary_$$(subst .,_,$$( > + --redefine-sym _binary_$$(subst .,_,$$( > + $$( > endef > > > > ifeq ($(CONFIG_RTE_APP_TEST_RESOURCE_TAR),y) > > @@ -76,7 +76,9 @@ SRCS-$(CONFIG_RTE_LIBRTE_CMDLINE) := commands.c > > SRCS-y += test.c > > SRCS-y += resource.c > > SRCS-y += test_resource.c > > -$(eval $(call linked_resource,test_resource_c,resource.c)) > > +test_resource.res: test_resource.c > > + @ cp $< $@ > > +$(eval $(call linked_resource,test_resource_c,test_resource.res)) > > $(eval $(call linked_tar_resource,test_resource_tar,test_resource.c)) > > SRCS-$(CONFIG_RTE_APP_TEST_RESOURCE_TAR) += test_pci.c > > $(eval $(call linked_tar_resource,test_pci_sysfs,test_pci_sysfs)) > > ...this would avoid to rename the resource file and make the patch > easier to understand. ... but it would be harder to understand how are named the resources in the build directory ;) Ideally we should not use a source file (referenced in SRCS-y) as a test resource.