Re: [dpdk-dev] [PATCH] net/mlx: update C compliance standard

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 6/30/2017 7:25 PM, Yongseok Koh wrote:
> 
> Hi,
> 
> 
> 
> Thanks,
> Yongseok
> 
>> On Jun 30, 2017, at 11:14 AM, Yongseok Koh <yskoh@mellanox.com> wrote:
>>
>>
>>> On Jun 30, 2017, at 10:47 AM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>>
>>> On 6/30/2017 6:19 PM, Adrien Mazarguil wrote:
>>>> This commit addresses a compilation issue against Glibc >= 2.25, which
>>>> implements assert() through a nonstandard ({ }) construct. Such constructs
>>>> can normally not be used without __extension__ keyword when -pedantic is
>>>> enabled, as is the case when compiling mlx4 and mlx5 PMDs in debug mode.
>>>>
>>>> While assert.h checks for the compiler ability to support GNU extensions,
>>>> Clang, unlike GCC, does not allow the above syntax when combining
>>>> -std=gnu99 with -pedantic.
>>>>
>>>> Work around missing keyword by moving these PMDs to a stricter compliance
>>>> standard without GNU extensions but properly checked by Glibc. Doing so is
>>>> supported on the DPDK side since includes have been cleaned up.
>>>>
>>>> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
>>>
>>> Applied to dpdk-next-net/master, thanks.
>> This breaks debug-enabled build of mlx5 as mlx5 isn't ready yet!
> Specifically, the following errors happen. It might be better to later make the
> change for mlx5 with further cleanup.

I don't see build errors.
Patch is requested to fix mlx DEBUG builds [1]. Can you please give more
details how to reproduce build error?

[1]
http://dpdk.org/ml/archives/dev/2017-June/067866.html