From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id A349E324D for ; Mon, 22 May 2017 13:29:13 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 May 2017 04:29:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,377,1491289200"; d="scan'208";a="105397881" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.81]) ([10.237.220.81]) by fmsmga006.fm.intel.com with ESMTP; 22 May 2017 04:29:10 -0700 To: Andrew Rybchenko , dev@dpdk.org References: <1495023908-10977-1-git-send-email-arybchenko@solarflare.com> <1495116004-11761-1-git-send-email-arybchenko@solarflare.com> <1495116004-11761-3-git-send-email-arybchenko@solarflare.com> From: Ferruh Yigit Message-ID: <45b5b0a6-a5be-88d7-734f-c2b1dd1b31be@intel.com> Date: Mon, 22 May 2017 12:29:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1495116004-11761-3-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 3/3] net/sfc: support multi-process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 May 2017 11:29:14 -0000 On 5/18/2017 3:00 PM, Andrew Rybchenko wrote: > Signed-off-by: Andrew Rybchenko > Reviewed-by: Andy Moreton <...> > Linux VFIO = Y > diff --git a/drivers/net/sfc/sfc.h b/drivers/net/sfc/sfc.h > index 772a713..007ed24 100644 > --- a/drivers/net/sfc/sfc.h > +++ b/drivers/net/sfc/sfc.h > @@ -225,7 +225,18 @@ struct sfc_adapter { > uint8_t rss_key[SFC_RSS_KEY_SIZE]; > #endif > > + /* > + * Shared memory copy of the Rx datapath name to be used by > + * the secondary process to find Rx datapath to be used. > + */ > + char *dp_rx_name; Why not use sa->dp_rx->dp.name to find the dp_rx? That variable should be shared between processes already? <...> > diff --git a/drivers/net/sfc/sfc_ef10_rx.c b/drivers/net/sfc/sfc_ef10_rx.c > index 1484bab..60812cb 100644 > --- a/drivers/net/sfc/sfc_ef10_rx.c > +++ b/drivers/net/sfc/sfc_ef10_rx.c > @@ -699,7 +699,7 @@ struct sfc_dp_rx sfc_ef10_rx = { > .type = SFC_DP_RX, > .hw_fw_caps = SFC_DP_HW_FW_CAP_EF10, > }, > - .features = 0, > + .features = SFC_DP_RX_FEAT_MULTI_PROCESS, Why this flag is needed, I mean why multi process support is not always enabled by default? <...>