From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 464B4A0543; Mon, 13 Jun 2022 09:47:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E062B40222; Mon, 13 Jun 2022 09:47:28 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2046.outbound.protection.outlook.com [40.107.243.46]) by mails.dpdk.org (Postfix) with ESMTP id E890840150 for ; Mon, 13 Jun 2022 09:47:27 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f/iT6gOedXidnOoQAFAoexVx/eY1Y6VHA4HID71coERNXTiXubjoBvgtK6xg2t1ur/2xa/u2hEEhkAgPD4YNTklCaercuF4j184B4U1v+yeNFJ5tK2WyNyZSU/AeYmAxbwXVNkZeDjIwNm3mLcoY/1S7sYScNjocSc1drInzldkGkvCaQf+bBNc5BXyKJm0Hgq4O7sQEjQ+DCur8d/w4x4yFvBTBqheDT+uFkDORwVo1XcWPT0HKv4z/aJuD2dbjLkMPnijaAFcG/sCJsHGKbVYTv7y6T+iU1KejerL/bLurmpfu5jFucJIFx8a6BrTY1SuK5A4QwbhgQv4c4nA9iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1GS9Vt69BXyQzZtbpyUiKGAJpzq3Hqgv/3UIOJSXKcY=; b=Zp3B93wgMw7+Qwcn1ZTFkfRh7XNppdl79OhV85xJfGfl9nBumC4w34AOpKohK6VXGMjLLENFU58Pqy3BfZjlrh6IUfPahkZAevyHGDItT9DQ404LCpR4ea5b89ek2kiwgj678Zn3SMfP5XJ9+ujoN9kHuQ44WQzG/9DJ4q0uBu5x6ZUYbD5tuOiDcfcCvO7iaa5MF5yZ0dGuTNqYCs1johWyeq8urSAmZAz3BVbxpOgvrXs2WnwOJM9oEM4xn6n6vum8Mb3hFhYl3+vxpHbiKA0d/rYsaDDVaZubtAleVZuOJTFDPIJ6zE861z/DebnSd/AiiNgupOAvIfDV+qMy+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=canonical.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1GS9Vt69BXyQzZtbpyUiKGAJpzq3Hqgv/3UIOJSXKcY=; b=D/x/MbUVJlmwv6Y973Tj23m8AmgBlmVBpOGSGRC/RkC8CoUt9lkHHYzKfojQMTZVvLHlxA/PAzWjYLM+I9jwl8pUZ2DYu6D7JkC9o8Hjl4vFZIARacd9b/+Pn4S5+VAcdtyPnzCkW8xrjF2J7kjxSnP7awz9UtH9jpgjXPxsPDg= Received: from DM6PR10CA0010.namprd10.prod.outlook.com (2603:10b6:5:60::23) by BN6PR02MB2387.namprd02.prod.outlook.com (2603:10b6:404:2d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.13; Mon, 13 Jun 2022 07:47:24 +0000 Received: from DM3NAM02FT040.eop-nam02.prod.protection.outlook.com (2603:10b6:5:60:cafe::c5) by DM6PR10CA0010.outlook.office365.com (2603:10b6:5:60::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.15 via Frontend Transport; Mon, 13 Jun 2022 07:47:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; pr=C Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by DM3NAM02FT040.mail.protection.outlook.com (10.13.5.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5332.12 via Frontend Transport; Mon, 13 Jun 2022 07:47:24 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Mon, 13 Jun 2022 08:47:23 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Mon, 13 Jun 2022 08:47:23 +0100 Envelope-to: heinrich.schuchardt@canonical.com, dev@dpdk.org, adrien.mazarguil@6wind.com, harry.van.haaren@intel.com, thomas@monjalon.net, john.mcnamara@intel.com, david.marchand@redhat.com Received: from [10.71.119.224] (port=42220) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o0enC-00075U-Tb; Mon, 13 Jun 2022 08:47:23 +0100 Message-ID: <45f33ca8-40f0-1866-5f06-2e9dcaa424c8@xilinx.com> Date: Mon, 13 Jun 2022 08:47:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 1/1] doc: add author name on cc to git fixline alias Content-Language: en-US To: Heinrich Schuchardt , CC: Adrien Mazarguil , Harry van Haaren , Thomas Monjalon , John McNamara , David Marchand References: <20220612114007.23012-1-heinrich.schuchardt@canonical.com> From: Ferruh Yigit In-Reply-To: <20220612114007.23012-1-heinrich.schuchardt@canonical.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7086a3f3-864d-462a-74bb-08da4d10f4b8 X-MS-TrafficTypeDiagnostic: BN6PR02MB2387:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p3yQ/EK+5JfSLxoOtwmpZA1KhbV6DuAxliSIMnOrXCf2eB9vNtUiwCT441m4plgtJEib7E3Gyqk2BAyZbjM51UhbSMp584a95tpQsob8UI7LzeHsNfckZOdvCq42M64XbRXjkHtM4dq94g/YlgUt761ckx6vfj9ZI9u5Q3vMwgPCxFRzryjAdkTKAVvwIdc/FnATcDhVrWkowsv7OpBYKdoJtzpuKNLPq/kHGC4zfio+ToZHW6NXmbDRKvbe6P3BcBcvH20nxnHsTDVuiQgmEEJIM8MLBoznVPk4TiMmZiJFA1aJffT+LC0Lz0yW8EvAUutfvbGomwfz3bIWO64wRrJNbJBaYVRgXz5ewb31A/7kYHoxTg94BKSYbLSsazVA/oyF/+okV0l8xgLQAd8R+fuhc4xb8zq6zmAVF0qQFfvbNP6CPpurT62UHy6PVMMuh72RdcRS34BWdVqnFt5vBxKphO/pRBck38dPGrsY8v2kW1e5L1Qh8h1Hpqc0VheDtz0iutcT2g9xa0HgYzlPB8Ur2HaGbd6PIJjazcArUnQFuxD2Iodj2CSHK+GAkfWMdeGZd1YOvFVRS2XDKonKqiNqWbogB1CB1dMPUyY0QUIcFPME2ROy/54D0i8owtIkahVBXWBbu7hp7Ia4RRc79NZ5xxGrPMXwUyhygo/fNpVbcB1408TBQjMDrWBged3Yzn1zZZxJBvd42iIGB5WhcXx/DqEzJFYezHOOt1iagKU= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(40470700004)(36840700001)(46966006)(316002)(7636003)(36756003)(44832011)(36860700001)(110136005)(54906003)(31686004)(356005)(82310400005)(53546011)(2906002)(26005)(426003)(47076005)(336012)(4326008)(8676002)(83380400001)(186003)(70586007)(70206006)(5660300002)(8936002)(2616005)(508600001)(9786002)(40460700003)(31696002)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2022 07:47:24.4547 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7086a3f3-864d-462a-74bb-08da4d10f4b8 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT040.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB2387 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/12/2022 12:40 PM, Heinrich Schuchardt wrote: > We should add both the author name and the author email address to > the Cc: line of a blamed patch. > > Fixes: f9ef083c6cfe ("doc: add author on cc to git fixline alias") > Cc: Harry van Haaren > Signed-off-by: Heinrich Schuchardt > --- > doc/guides/contributing/patches.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst > index bebcaf3925..aad2429e58 100644 > --- a/doc/guides/contributing/patches.rst > +++ b/doc/guides/contributing/patches.rst > @@ -260,7 +260,7 @@ Here are some guidelines for the body of a commit message: > You can generate the required lines using the following git alias, which prints > the commit SHA and the author of the original code:: > > - git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae'" > + git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %an <%ae>'" > Hi Heinrich, We don't keep the 'Cc: ' lines in commit lines when pushing to repo, it is mainly added to be sure author of the original change is cc'ed since 'git send-email' picks emails from commit log. So although it doesn't hurt, it is also not needed to have full name & email since it will be stripped explicitly. Thanks, ferruh