From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id D7BC3239; Fri, 5 Oct 2018 10:58:48 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Oct 2018 01:58:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,343,1534834800"; d="scan'208";a="94850993" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.252.17.112]) ([10.252.17.112]) by fmsmga004.fm.intel.com with ESMTP; 05 Oct 2018 01:57:50 -0700 To: Darek Stojaczyk , dev@dpdk.org Cc: wuzhouhui250@gmail.com, pawelx.wodkowski@intel.com, gowrishankar.m@linux.vnet.ibm.com, stable@dpdk.org References: <20181003123925.6343-1-dariusz.stojaczyk@intel.com> From: "Burakov, Anatoly" Message-ID: <45f61fc2-ee13-e342-6f4d-0178df40c94d@intel.com> Date: Fri, 5 Oct 2018 09:57:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181003123925.6343-1-dariusz.stojaczyk@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal/vfio: share the default container in multi process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2018 08:58:49 -0000 On 03-Oct-18 1:39 PM, Darek Stojaczyk wrote: > So far each process in MP used to have a separate container > and relied on the primary process to register all memsegs. > > Mapping external memory via rte_vfio_container_dma_map() > in secondary processes was broken, because the default > (process-local) container had no groups bound. There was > even no way to bind any groups to it, because the container > fd was deeply encapsulated within EAL. > > This patch introduces a new SOCKET_REQ_DEFAULT_CONTAINER > message type for MP synchronization, makes all processes > within a MP party use a single default container, and hence > fixes rte_vfio_container_dma_map() for secondary processes. > >>>From what I checked this behavior was always the same, but > started to be invalid/insufficient once mapping external > memory was allowed. > > Fixes: 73a639085938 ("vfio: allow to map other memory regions") > Cc: anatoly.burakov@intel.com > Cc: pawelx.wodkowski@intel.com > Cc: gowrishankar.m@linux.vnet.ibm.com > Cc: stable@dpdk.org > > While here, fix up the comment on rte_vfio_get_container_fd(). > This function always opens a new container, never reuses > an old one. > > Signed-off-by: Darek Stojaczyk > --- > + if (internal_config.process_type == RTE_PROC_PRIMARY) { > + /* if we were secondary process we would try requesting > + * container fd from the primary, but we're the primary > + * process so just exit here > + */ > + return -1; > + } > + > + p->req = SOCKET_REQ_DEFAULT_CONTAINER; > + strcpy(mp_req.name, EAL_VFIO_MP); strlcpy? Otherwise, Reviewed-by: Anatoly Burakov -- Thanks, Anatoly