From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 067B342E9D; Mon, 17 Jul 2023 16:12:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9217D40A80; Mon, 17 Jul 2023 16:12:48 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2063.outbound.protection.outlook.com [40.107.101.63]) by mails.dpdk.org (Postfix) with ESMTP id 5BC7C40698; Mon, 17 Jul 2023 16:12:46 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NdzQt2Emcwl43qL/QudFIJT2SEPsK6EC0/r63CQNFKjAsdQB4P8GlM/Yi0zEMSGQ4BAEANefDt1V9f913ftMxuW6zy9kTp4qEt0IJRQ6o7PSV8yavPZyyXX1BvxvXlETEtQtxDJhSGOC4Y9RE/YM30fJfffWTNxx1lIjqKbeY2a8rhWQZG/1qUnGifNYjk+CGpHqkBhzFTFjh2ZTTKBTz3XxDXojP6leUQNqsZMuC1ypqZWepW46x6LNQcPrS09yvNWTUATGGfrzrYtLs1ATiCjq4a9KI1uFGam9NDkaXun+NIS2SJk6hmIJoXvhjb+pead22xwzU4FRA3oRKdeczQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6eNYFlzoz7AWNWGJyKtyJkYjYvbBRi7m7Zrgjp087MI=; b=VSXEsKKJo4AyH8ZKp0vTQXTZS1sy+32K+lEncN8AndiPNjlf5D2xY/XLAUTXkwLNkAf+pLbFPSAEQwS7xb9bFwMUniuWzT0cj2WrEp5FzSFsrPHD9xKd7IMGPVFmI80JT0TTSp2t1/l3Af9AZRWiknZY2K5myyH+oo+vlJIN5Jm3BxHgA+bNTlzY3xwZpJSeQ3JJwzRVd8SFxQ1oLHELbi3O1U/ayFDKtSxafdAtEhvSB2Ye6GZWTfnA/RWtWeE83fYb+SOHB7e8H5/rcHIa3pEZX+uc13yALi0LlDCaQH3KYs6ohiypu2VxsYZm57+ySx5GTElTosm8xF5cgOt2ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6eNYFlzoz7AWNWGJyKtyJkYjYvbBRi7m7Zrgjp087MI=; b=tCjtkmPmBf6NOeeCbLHSvhMBM2FOmvlsCaswBB/l4KZTgcX7NcKBzhafzvitahKcsCpzcFUENunGmGkNuEDelwjo46RlI9TEbusrfb1EF3a3KcBg6AsftEFbTNgSSeownzqwQ6MbNHnnH7sYHqIHVMQfQuEL5EwnE119EnOAPm0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MN2PR12MB4077.namprd12.prod.outlook.com (2603:10b6:208:1da::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.33; Mon, 17 Jul 2023 14:12:38 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::369d:5f05:aaba:ebd8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::369d:5f05:aaba:ebd8%3]) with mapi id 15.20.6588.031; Mon, 17 Jul 2023 14:12:38 +0000 Message-ID: <45f6ab7e-f086-f0bd-f870-a37793ea674a@amd.com> Date: Mon, 17 Jul 2023 15:12:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/1] net/sfc: add explicit fail path for unknown tunnel flow type Content-Language: en-US To: Andrew Rybchenko , Ivan Malov Cc: stable@dpdk.org, dev@dpdk.org References: <20230714124102.6546-1-ivan.malov@arknetworks.am> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0215.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:33a::15) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MN2PR12MB4077:EE_ X-MS-Office365-Filtering-Correlation-Id: 59d3c37b-0567-4070-f829-08db86cfe01f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +dxCcaTCw9xq+cu2HeNG+iJ+DjjOnA+N50WDMi1RdtAeYjpKRll1fpDOIZ/DOG2Id2Sd/wr3+caqs/eOxLj1kDzIh/XZzrnLtn6m0thpTLXTThjWd4OjdUozPU113xMGElnj8F0htHUZxiUYHQm2RvPk8Yt5NiCd07gbhLDSoz0M7BgWKsOkjYnLMuyaW3YkO4JbVlo+47HNQCeXjqc/RVhuLcXJbONRlBAkXs5Q4fZFnhTYV+sCyxiCMc7lA0KqidmMk6Txws9og8o8foRxT4UXMlb1L26HIFZgXSengeJ32bPG2M1fY0XDZqWGXKHHqJL5zVsODOk2sy/3iAZsZXDNMr0FLIcb6Ji+y1VtMKMMoL3k6ZMdz9Nqt7xo/Wj8VxlnOe9GtUGlVjYFzs+yl00OIZpHQN2lvFoaV4uWAxyCB7zvSMDijc0VjSZx+XTfXps4jaArnZtQKgPWXEqDMUyGdilGnh/+67NY2PO9em8jW0cyZPfIosIDxcy04Re/5a4qyKglWSVYW5hPeN+tYH1xqjeeFPLvB8Mr8FXzBV6Yb6CRzL6H4O6hNYuytrRPiprhtIQq88q4/bBUdB17vDFiDaZJK/ptNstlYmD3PZl1cc5mXkiwHvymaYhHEQ1oQ2cW3NXy6L9nM97EvKi9Yg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(39860400002)(366004)(346002)(136003)(396003)(451199021)(478600001)(6486002)(6666004)(110136005)(186003)(53546011)(6506007)(6512007)(26005)(2906002)(4744005)(44832011)(66476007)(66946007)(41300700001)(4326008)(66556008)(316002)(5660300002)(8936002)(8676002)(38100700002)(86362001)(36756003)(31696002)(2616005)(83380400001)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZHM3SUFlenp3ZW95MXE4aWpXdjh2VFQ5VkwxaGVEYUNXa1BDblRmUGdYaDZE?= =?utf-8?B?aDZkazlndTJhOFo2SFFFVnEybVRZcnBST3hMbjB4Ry9KdGVMYzlzdUUzeGtU?= =?utf-8?B?YjlhUVRpSWtLdHRUSTdKRXdJWFZ4UVZWaTNtU09ZNkI3bHZkZTR3Ymo5dm14?= =?utf-8?B?QkJwbmNaZTdMWkl0ejRhNkVmR1MrZlRBUmdIeHhVYTRBZFMwWXAvd0lFTUpt?= =?utf-8?B?ZUkzSlk3blJKUkxkQnpmSmNRemQ3T1FwWXRhRzdtK1UxbkVjenV3VDBaU0FJ?= =?utf-8?B?UytBOTNSZnN0UlBTaG42UkZMeVJMTVRSanVnWit5WFJwNTBlb1oxQ28zUjBt?= =?utf-8?B?Z2YwSEl5U0ZTQnR0MVI3OHBGdUg5Zmd0bjMzOTdqSDFCMGtTc1FFTjFuN284?= =?utf-8?B?Tk5hTUJXaC9jcjg1S2hPcU9aN3hHTEVMdCsyOFZFNTdMRlU3SXFhNVBQRUJ4?= =?utf-8?B?ZVMzazR1WUszdC9tQ0dwZ0hjOXdFdmVicUlEbmVtN0wwck4yNXVtY1hRVnFX?= =?utf-8?B?M1l5RUJlU0RpVFlBWnNhNDRnZDdUK1hoL0o2bGRYMmQvV2huYUJRTVAvSjNs?= =?utf-8?B?NnFwaTI5OG5YcmZ2TDFIT2w5eVkxZjF3TlQxUHA2ZDJ1Y2hwZmdkNU1PSEJx?= =?utf-8?B?ZElGNmpubS90YVZYcGdvTUdhWTRrVzJLdVl6b004dFNmMS9TeU9iNm05K2xr?= =?utf-8?B?cUtSNUZzQXFSTDhqQVh5MW1lUWptU0FXME42V0NKT2hvczBlY05CYytUZGVO?= =?utf-8?B?eXM0N3ZrYUJpekQvS2dlM1d0Yjk0M0JJNHRaY3dmVFN5Q0Q3QlN5b043dWov?= =?utf-8?B?NFZla3lmeWZsdU56alJRd3VQVS81V1ZsREsxK2UyTGZwVTVTeUxpWFFudVFm?= =?utf-8?B?SjlGdjJ1OWU5ZTNLamdQdmo0SU1EY1F1dFN3UDNzUFRIT1AxTnR0UUl0MG5Q?= =?utf-8?B?alE5Tkg5cEVDVUFjU0VYNmFLM285RVI0TVdnWVA1dUJFSXF4QVl4Q1VzUy9u?= =?utf-8?B?WjcwUE56cU5NNHdtUjN0eUtJVEJvSjQwVGFOQWptUmd1WEZqWnFmaUJPZDA1?= =?utf-8?B?SXk0L0dpdnQ2enBLQ2wwU2hmVW5oeHgzeXVpMm5udjVoQXZuTzhnZ1ZZd3Zw?= =?utf-8?B?VGgyaGZPN2FyanJDbkF2dm1qS0h4YjZtK3YzaU1DM00vQTVVOFhHc2t5TU9z?= =?utf-8?B?TVJiWE9ZR0JtTFdraFRFQTRNU1lVVXZXTkt1YmNZdE1LSzR5RGllMkxFL1Z3?= =?utf-8?B?ejg2SHdpWUZqQU13QnNLdjNNTmRpWFlEVmRuREMvZzFwWnZRa1NzL3hZeUlr?= =?utf-8?B?Z25HQS9mdnpsdXBMK0w1M21lb3lINzFVc2J4SG9MbGxKNUVxNStWOU5xc3Yr?= =?utf-8?B?czB5U1dvVU45SU1zWWlobTBYYkhKUWorblZXN3FMRnBSVlVlbVErUmwrM3V6?= =?utf-8?B?VU1yUW9lNDZyM3NsZVpxOUtRNWhjbUwyc3V0Qm1EVWV2M0p4NFJ6SnFWYlJr?= =?utf-8?B?QjkxZmhkR1ptNE9GdW1PUVJsemozdEVOM2ZwdWIybDV2djR3UnJDb0xnOVFI?= =?utf-8?B?WmF1VXhOc1BkU09pTHFkZUkzMjVDZ3RqWWJJYVRrRUlObm8yVzJYUXR0aTN5?= =?utf-8?B?dmVEUVd2dEp1Z09WMnVTWU5JSHFNQUgxaktqK3VBT0Q1ZDhBS0M0S0J1bjF4?= =?utf-8?B?a0RFY0E0NkgzUG80WWROblJJMFcyUHRMSWhWaWRtSnhuY2V5eVI0MS96ZHQv?= =?utf-8?B?TytOY3I4dmFNUlZTdEFlYURkMnFsY0lVZkx1WVJxNE9vYitkL2tRZWdwTW1B?= =?utf-8?B?YnJzZ2FhZUNZa2w2UzE1NHhkelU1dTZjQmVZQ2lpeDJmbzNUMWZTMmM3THhy?= =?utf-8?B?Z2IwZ093dVgyRGVlMy9NR3NoYWpEcmdLNENUWUJodjBuZWZnbnhSLzdQZ2RJ?= =?utf-8?B?eXZWT1BVczdxc2hUL1FQbCtlSnplcWZ5a2t3dUlIbm04VWRMeDBQM2owb3gx?= =?utf-8?B?ZGlWV1R1dWtXYndFY2MyTkxvd0M1cW43QnhOeHFOemQxQ3B3TlZGZXRDZ0Js?= =?utf-8?B?bWpVdDhkZTE4T3NPS05GSlJnMnppbldHUjc4RVlDUUlmSno2VEhza0QvZVB5?= =?utf-8?Q?n0YSM7fsFdXvjBY+ptq0Do/zH?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59d3c37b-0567-4070-f829-08db86cfe01f X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2023 14:12:38.2302 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OaV5cf4hIiEA+FPjpXKHiw4vumf/puGQ4ZDqoQqqHWPW3FEnTf2nCGxw6pupohF9 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4077 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/17/2023 9:27 AM, Andrew Rybchenko wrote: > On 7/14/23 15:41, Ivan Malov wrote: >> The driver supports flow tunnel offload. When the parsed rule >> type is unknown, which must not happen, the driver does not >> properly indicate the failure in non-debug builds. That >> presumably makes Coverity report possible NULL pointer >> dereference in regard with uninitialised HW match >> specification (which gets properly initialised >> when the rule type check is successful). >> >> In order to fix this, replace the debug >> assert with a proper runtime fail path. >> >> Coverity issue: 393675 >> Fixes: 73e01736868b ("net/sfc: turn MAE flow action rules into >> shareable resources") >> Cc: stable@dpdk.org >> >> Signed-off-by: Ivan Malov > > Acked-by: Andrew Rybchenko > Applied to dpdk-next-net/main, thanks.