From: Thomas Monjalon <thomas@monjalon.net>
To: "Singh, Jasvinder" <jasvinder.singh@intel.com>
Cc: dev@dpdk.org, "Dumitrescu,
Cristian" <cristian.dumitrescu@intel.com>,
"Peng, Yuan" <yuan.peng@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples/qos_meter: fix meter color type conversion
Date: Sun, 11 Aug 2019 00:08:39 +0200 [thread overview]
Message-ID: <4601880.jBeIExCvks@xps> (raw)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E901EA9@IRSMSX108.ger.corp.intel.com>
09/08/2019 13:56, Dumitrescu, Cristian:
> From: Singh, Jasvinder
> > In APP_MODE_SRTCM_COLOR_AWARE mode, sample app compilation fails
> > due to wrong meter color type conversion.
> >
> > Fixes: fc8a10d8527a ("examples/qos_meter: add color policy")
This is not the root cause. Replaced with:
Fixes: c1656328dbc2 ("meter: replace color definitions")
Cc: stable@dpdk.org
> > error log-
> > /qos_meter/main.c:error: conversion to incomplete type
> > (enum rte_meter_color) input_color);
This log should be before "Fixes" line.
> > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > Reported-by: Peng Yuan <yuan.peng@intel.com>
Reported-by should be before SoB line (chronological order).
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Applied
prev parent reply other threads:[~2019-08-10 22:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 9:37 Jasvinder Singh
2019-08-09 11:56 ` Dumitrescu, Cristian
2019-08-10 22:08 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4601880.jBeIExCvks@xps \
--to=thomas@monjalon.net \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=yuan.peng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).