[dpdk-dev] [PATCH] examples/qos_meter: fix meter color type conversion

[dpdk-dev] [PATCH] examples/qos_meter: fix meter color type conversion

[Jasvinder Singh]

In APP_MODE_SRTCM_COLOR_AWARE mode, sample app compilation fails
due to wrong meter color type conversion.

Fixes: fc8a10d8527a ("examples/qos_meter: add color policy")

error log-
/qos_meter/main.c:error: conversion to incomplete type
(enum rte_meter_color) input_color);

Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
Reported-by: Peng Yuan <yuan.peng@intel.com>
---
 examples/qos_meter/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/qos_meter/main.c b/examples/qos_meter/main.c
index ce1f63dc7..da7afe8be 100644
--- a/examples/qos_meter/main.c
+++ b/examples/qos_meter/main.c
@@ -156,7 +156,7 @@ app_pkt_handle(struct rte_mbuf *pkt, uint64_t time)
 		&PROFILE,
 		time,
 		pkt_len,
-		(enum rte_meter_color) input_color);
+		(enum rte_color) input_color);
 
 	/* Apply policing and set the output color */
 	action = policer_table[input_color][output_color];
-- 
2.21.0

Re: [dpdk-dev] [PATCH] examples/qos_meter: fix meter color type conversion

[Dumitrescu, Cristian]

> -----Original Message-----
> From: Singh, Jasvinder
> Sent: Friday, August 9, 2019 10:37 AM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Peng, Yuan
> <yuan.peng@intel.com>
> Subject: [PATCH] examples/qos_meter: fix meter color type conversion
> 
> In APP_MODE_SRTCM_COLOR_AWARE mode, sample app compilation fails
> due to wrong meter color type conversion.
> 
> Fixes: fc8a10d8527a ("examples/qos_meter: add color policy")
> 
> error log-
> /qos_meter/main.c:error: conversion to incomplete type
> (enum rte_meter_color) input_color);
> 
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> Reported-by: Peng Yuan <yuan.peng@intel.com>
> ---
>  examples/qos_meter/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/examples/qos_meter/main.c b/examples/qos_meter/main.c
> index ce1f63dc7..da7afe8be 100644
> --- a/examples/qos_meter/main.c
> +++ b/examples/qos_meter/main.c
> @@ -156,7 +156,7 @@ app_pkt_handle(struct rte_mbuf *pkt, uint64_t time)
>  		&PROFILE,
>  		time,
>  		pkt_len,
> -		(enum rte_meter_color) input_color);
> +		(enum rte_color) input_color);
> 
>  	/* Apply policing and set the output color */
>  	action = policer_table[input_color][output_color];
> --
> 2.21.0

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Re: [dpdk-dev] [PATCH] examples/qos_meter: fix meter color type conversion

[Thomas Monjalon]

09/08/2019 13:56, Dumitrescu, Cristian:
> From: Singh, Jasvinder
> > In APP_MODE_SRTCM_COLOR_AWARE mode, sample app compilation fails
> > due to wrong meter color type conversion.
> > 
> > Fixes: fc8a10d8527a ("examples/qos_meter: add color policy")

This is not the root cause. Replaced with:

Fixes: c1656328dbc2 ("meter: replace color definitions")
Cc: stable@dpdk.org

> > error log-
> > /qos_meter/main.c:error: conversion to incomplete type
> > (enum rte_meter_color) input_color);

This log should be before "Fixes" line.

> > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > Reported-by: Peng Yuan <yuan.peng@intel.com>

Reported-by should be before SoB line (chronological order).

> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied