From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C27BA00E6 for ; Sun, 11 Aug 2019 00:08:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D2D4C231E; Sun, 11 Aug 2019 00:08:44 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 846E8DE3 for ; Sun, 11 Aug 2019 00:08:42 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 123C621B10; Sat, 10 Aug 2019 18:08:42 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sat, 10 Aug 2019 18:08:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=EVVw+lvxs90TAlvYNiqJ67Wvd/ZgEJyLtHX+nXn05bE=; b=e3JXVd1FZGX7 sLKORnsaEBOVBQ4dgvG1SKk1noMq2cCeoJBAetCNPin0Txb6A2uphy8pNKNZEB0q BBdIueQMajNOURRE3BiJhafwhTmBE8YMQ/uW7b61CMzD9z8F/nmfjpFn3YlJSOyc quPv1q2tIayuQXbUL2zXPiiWmGYRGuk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=EVVw+lvxs90TAlvYNiqJ67Wvd/ZgEJyLtHX+nXn05 bE=; b=oYiDVwwmcf1jaUScENrnOp7HcpHBufHrlafiBRwr7vNFL3VioOxQ5Lm2S 7gqpxNq+oMtQQCqTIAG/Ya6c1CIYluWzivyQooqdNzwWw52hZ3g13QVf7opKxaaO B4qIHi5C/Vzf0lmlqR8idv3H8h79JaWtZst9voReUDFVdSeKRhkoBCEu3IbGUM/M j8HW4V1t5sVoPUghuS2kpSPR8QwyenG8M+gcabh2vlYcPk8z2XGTIQAtb4H2xoo+ bh13HxRVgRW7fw9EggxEfW+5OFr9s/fvuXplkP2Ggga8vsDX/xa3z67bLYZI95k3 Hii4a8NOncAY/Wk4nSAoOIHKBcPPg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudduledgudejtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc fkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpeht hhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DC8E4380076; Sat, 10 Aug 2019 18:08:40 -0400 (EDT) From: Thomas Monjalon To: "Singh, Jasvinder" Cc: dev@dpdk.org, "Dumitrescu, Cristian" , "Peng, Yuan" Date: Sun, 11 Aug 2019 00:08:39 +0200 Message-ID: <4601880.jBeIExCvks@xps> In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E901EA9@IRSMSX108.ger.corp.intel.com> References: <20190809093713.25114-1-jasvinder.singh@intel.com> <3EB4FA525960D640B5BDFFD6A3D891268E901EA9@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] examples/qos_meter: fix meter color type conversion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/08/2019 13:56, Dumitrescu, Cristian: > From: Singh, Jasvinder > > In APP_MODE_SRTCM_COLOR_AWARE mode, sample app compilation fails > > due to wrong meter color type conversion. > > > > Fixes: fc8a10d8527a ("examples/qos_meter: add color policy") This is not the root cause. Replaced with: Fixes: c1656328dbc2 ("meter: replace color definitions") Cc: stable@dpdk.org > > error log- > > /qos_meter/main.c:error: conversion to incomplete type > > (enum rte_meter_color) input_color); This log should be before "Fixes" line. > > Signed-off-by: Jasvinder Singh > > Reported-by: Peng Yuan Reported-by should be before SoB line (chronological order). > Acked-by: Cristian Dumitrescu Applied