* [dpdk-dev] [PATCH] examples/qos_meter: fix meter color type conversion
@ 2019-08-09 9:37 Jasvinder Singh
2019-08-09 11:56 ` Dumitrescu, Cristian
0 siblings, 1 reply; 3+ messages in thread
From: Jasvinder Singh @ 2019-08-09 9:37 UTC (permalink / raw)
To: dev; +Cc: cristian.dumitrescu, Peng Yuan
In APP_MODE_SRTCM_COLOR_AWARE mode, sample app compilation fails
due to wrong meter color type conversion.
Fixes: fc8a10d8527a ("examples/qos_meter: add color policy")
error log-
/qos_meter/main.c:error: conversion to incomplete type
(enum rte_meter_color) input_color);
Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
Reported-by: Peng Yuan <yuan.peng@intel.com>
---
examples/qos_meter/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/qos_meter/main.c b/examples/qos_meter/main.c
index ce1f63dc7..da7afe8be 100644
--- a/examples/qos_meter/main.c
+++ b/examples/qos_meter/main.c
@@ -156,7 +156,7 @@ app_pkt_handle(struct rte_mbuf *pkt, uint64_t time)
&PROFILE,
time,
pkt_len,
- (enum rte_meter_color) input_color);
+ (enum rte_color) input_color);
/* Apply policing and set the output color */
action = policer_table[input_color][output_color];
--
2.21.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] examples/qos_meter: fix meter color type conversion
2019-08-09 9:37 [dpdk-dev] [PATCH] examples/qos_meter: fix meter color type conversion Jasvinder Singh
@ 2019-08-09 11:56 ` Dumitrescu, Cristian
2019-08-10 22:08 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Dumitrescu, Cristian @ 2019-08-09 11:56 UTC (permalink / raw)
To: Singh, Jasvinder, dev; +Cc: Peng, Yuan
> -----Original Message-----
> From: Singh, Jasvinder
> Sent: Friday, August 9, 2019 10:37 AM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Peng, Yuan
> <yuan.peng@intel.com>
> Subject: [PATCH] examples/qos_meter: fix meter color type conversion
>
> In APP_MODE_SRTCM_COLOR_AWARE mode, sample app compilation fails
> due to wrong meter color type conversion.
>
> Fixes: fc8a10d8527a ("examples/qos_meter: add color policy")
>
> error log-
> /qos_meter/main.c:error: conversion to incomplete type
> (enum rte_meter_color) input_color);
>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> Reported-by: Peng Yuan <yuan.peng@intel.com>
> ---
> examples/qos_meter/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/qos_meter/main.c b/examples/qos_meter/main.c
> index ce1f63dc7..da7afe8be 100644
> --- a/examples/qos_meter/main.c
> +++ b/examples/qos_meter/main.c
> @@ -156,7 +156,7 @@ app_pkt_handle(struct rte_mbuf *pkt, uint64_t time)
> &PROFILE,
> time,
> pkt_len,
> - (enum rte_meter_color) input_color);
> + (enum rte_color) input_color);
>
> /* Apply policing and set the output color */
> action = policer_table[input_color][output_color];
> --
> 2.21.0
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] examples/qos_meter: fix meter color type conversion
2019-08-09 11:56 ` Dumitrescu, Cristian
@ 2019-08-10 22:08 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2019-08-10 22:08 UTC (permalink / raw)
To: Singh, Jasvinder; +Cc: dev, Dumitrescu, Cristian, Peng, Yuan
09/08/2019 13:56, Dumitrescu, Cristian:
> From: Singh, Jasvinder
> > In APP_MODE_SRTCM_COLOR_AWARE mode, sample app compilation fails
> > due to wrong meter color type conversion.
> >
> > Fixes: fc8a10d8527a ("examples/qos_meter: add color policy")
This is not the root cause. Replaced with:
Fixes: c1656328dbc2 ("meter: replace color definitions")
Cc: stable@dpdk.org
> > error log-
> > /qos_meter/main.c:error: conversion to incomplete type
> > (enum rte_meter_color) input_color);
This log should be before "Fixes" line.
> > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > Reported-by: Peng Yuan <yuan.peng@intel.com>
Reported-by should be before SoB line (chronological order).
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-10 22:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-09 9:37 [dpdk-dev] [PATCH] examples/qos_meter: fix meter color type conversion Jasvinder Singh
2019-08-09 11:56 ` Dumitrescu, Cristian
2019-08-10 22:08 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).