From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 18F76293B for ; Mon, 13 May 2019 16:30:11 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7C5C72387A; Mon, 13 May 2019 10:30:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 13 May 2019 10:30:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=ty5FkfeWnC/4IFeUrIv3Muf0+RXKwVPi8C0S4aoNV2I=; b=mrGMWLYh4dZF zh94pKdpyCjRci/X4+DdWr2ag711T9O3xj4/3Bzf1syq1csMmPIMMyd4uvRCJUu5 e8vxm6NJr/MNM/yAnGb6m992ucDmitgxfCf3cJ7IAEs1cJa4MUiP1ZMawxJhcXl6 xAYpTS5x0f8+gJjB6JGO1GAqk4Zo01E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ty5FkfeWnC/4IFeUrIv3Muf0+RXKwVPi8C0S4aoNV 2I=; b=TcWGTwsS/Ct9Emq4LAKcQkFPuvBtV6U120b0eNahkf3a9ro8BfSC9viY2 aWfq8LIgvXuuDIObQT3GWUvf2UjFMQW4V9dSC6MvqA6jdRL8cGiY2Aew5oLDIBwj X8l3ksHZW2R0oijOZFkXzhqLu9YuWzktAptOMTGMBuyXsW58Vd7XBz1GSr7Zm8h7 7dtQGbKwyWxi9ThRFQIwdDLSqky8T1ocDQRdvNu27txp6P33bt4mclRFfNi7YYHd 9VYNetO860vNwpXNRIq/ItEoeLqmKl/d4cA1TiRL4ZBAOuUK2JcNIM/9NYOwap/4 W2u+Qzyjaf5JrIEDDOflagCArm4mQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrleeggdejiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5C2661037C; Mon, 13 May 2019 10:30:08 -0400 (EDT) From: Thomas Monjalon To: Slava Ovsiienko Cc: dev@dpdk.org, Shahaf Shuler , Yongseok Koh , "ferruh.yigit@intel.com" Date: Mon, 13 May 2019 16:30:04 +0200 Message-ID: <4603169.RcIqrC0etK@xps> In-Reply-To: References: <1557498982-27734-1-git-send-email-viacheslavo@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix device removal handler for multiport device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 May 2019 14:30:11 -0000 12/05/2019 19:17, Shahaf Shuler: > Sunday, May 12, 2019 3:15 PM, Shahaf Shuler: > > Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix device removal handler for > > multiport device > > > > Sunday, May 12, 2019 11:32 AM, Viacheslav Ovsiienko: > > > Subject: [dpdk-dev] [PATCH v2] net/mlx5: fix device removal handler > > > for multiport device > > > > > > IBV_EVENT_DEVICE_FATAL event is generated by the driver once for the > > > entire multiport Infiniband device, not for each existing ports. > > > The port index is zero and it causes dropping the device removal > > > event. We should invoke the removal event processing routine for each > > > port we have installed handler for. > > > > > > Fixes: 028b2a28c3cb ("net/mlx5: update event handler for multiport IB > > > devices") > > > > > > Signed-off-by: Viacheslav Ovsiienko > > > > Acked-by: Shahaf Shuler > > > > Thomas, Ferruh, > > This one is a critical fix for mlx5. w/o it will break the support for failsafe at > > azure. > > > > Can you consider to integrate it? > > Applied it also to next-net-mlx, thanks. Pulled in master From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id AEEC6A00E6 for ; Mon, 13 May 2019 16:30:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 558472BC1; Mon, 13 May 2019 16:30:12 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 18F76293B for ; Mon, 13 May 2019 16:30:11 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7C5C72387A; Mon, 13 May 2019 10:30:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 13 May 2019 10:30:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=ty5FkfeWnC/4IFeUrIv3Muf0+RXKwVPi8C0S4aoNV2I=; b=mrGMWLYh4dZF zh94pKdpyCjRci/X4+DdWr2ag711T9O3xj4/3Bzf1syq1csMmPIMMyd4uvRCJUu5 e8vxm6NJr/MNM/yAnGb6m992ucDmitgxfCf3cJ7IAEs1cJa4MUiP1ZMawxJhcXl6 xAYpTS5x0f8+gJjB6JGO1GAqk4Zo01E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ty5FkfeWnC/4IFeUrIv3Muf0+RXKwVPi8C0S4aoNV 2I=; b=TcWGTwsS/Ct9Emq4LAKcQkFPuvBtV6U120b0eNahkf3a9ro8BfSC9viY2 aWfq8LIgvXuuDIObQT3GWUvf2UjFMQW4V9dSC6MvqA6jdRL8cGiY2Aew5oLDIBwj X8l3ksHZW2R0oijOZFkXzhqLu9YuWzktAptOMTGMBuyXsW58Vd7XBz1GSr7Zm8h7 7dtQGbKwyWxi9ThRFQIwdDLSqky8T1ocDQRdvNu27txp6P33bt4mclRFfNi7YYHd 9VYNetO860vNwpXNRIq/ItEoeLqmKl/d4cA1TiRL4ZBAOuUK2JcNIM/9NYOwap/4 W2u+Qzyjaf5JrIEDDOflagCArm4mQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrleeggdejiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5C2661037C; Mon, 13 May 2019 10:30:08 -0400 (EDT) From: Thomas Monjalon To: Slava Ovsiienko Cc: dev@dpdk.org, Shahaf Shuler , Yongseok Koh , "ferruh.yigit@intel.com" Date: Mon, 13 May 2019 16:30:04 +0200 Message-ID: <4603169.RcIqrC0etK@xps> In-Reply-To: References: <1557498982-27734-1-git-send-email-viacheslavo@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix device removal handler for multiport device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190513143004.YuZpb9FlIJbHP9iJGXUj0nahSqcu6psO3Iy9eOENBGg@z> 12/05/2019 19:17, Shahaf Shuler: > Sunday, May 12, 2019 3:15 PM, Shahaf Shuler: > > Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix device removal handler for > > multiport device > > > > Sunday, May 12, 2019 11:32 AM, Viacheslav Ovsiienko: > > > Subject: [dpdk-dev] [PATCH v2] net/mlx5: fix device removal handler > > > for multiport device > > > > > > IBV_EVENT_DEVICE_FATAL event is generated by the driver once for the > > > entire multiport Infiniband device, not for each existing ports. > > > The port index is zero and it causes dropping the device removal > > > event. We should invoke the removal event processing routine for each > > > port we have installed handler for. > > > > > > Fixes: 028b2a28c3cb ("net/mlx5: update event handler for multiport IB > > > devices") > > > > > > Signed-off-by: Viacheslav Ovsiienko > > > > Acked-by: Shahaf Shuler > > > > Thomas, Ferruh, > > This one is a critical fix for mlx5. w/o it will break the support for failsafe at > > azure. > > > > Can you consider to integrate it? > > Applied it also to next-net-mlx, thanks. Pulled in master