From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82D1FA04AF; Mon, 28 Sep 2020 11:22:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EDD5C1D55B; Mon, 28 Sep 2020 11:22:00 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id E92DD1D554; Mon, 28 Sep 2020 11:21:57 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 34AAA2D0; Mon, 28 Sep 2020 05:21:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 28 Sep 2020 05:21:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= gKERrNOjXseJW47A6buO+/CIz3gNM8/jA93hrPOtOMM=; b=mGRlQObG4wytECZ+ jGe19bp35rPf6wZTqn0jAaRNouYp2M2xL6S83lDJ8mYyBxlcmqPPcGFb4lcecQgj GGoZfJ6kKt0Qf0mSJkhkV/5Jvad2DorzcwzdOrrg3SCXHzCxIKcYc2bVg1x10YCG mkZXf7rcjyC+8IarYAmnAY2czg2AwiLag7CNPjLQtF7dfMoYwo5LGeLImlxcbO8v /j1y9Zx7HRXRoVGSUWhktsuynRauwAP2UnKQkQ5opX4cji8t769/twmf47/xZQqw 5rcNfClfBg7zDdKieurB89ewOjASS+/KnlFOdJGtSHhNRzTPl6zIExgk9OCf4Y9h qXDbfw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=gKERrNOjXseJW47A6buO+/CIz3gNM8/jA93hrPOtO MM=; b=FgSR4MEX8g9yC281vX5+QP75AXh8BRMZhOueilyAN+IkrDhmDdO7ufjIv P/cEZE1G2iVzf0B+nIec83LtijJsXTsIhm1JrcGsFf74oGWxh8DHPTlJHVrIzm/Z rk4+3yePpURET21jGoScAkBnfrDmhgoA5BaGASedkM28PDtcOlM9utkqhXp2BBP5 5IFJ1hIhRrSWlRJQTsUhk2jb7aPu5FdegkJHLpHh2EVMIMHsvhc82gfRDayip3Bi GOvM2wMdWTJnuhHABq6jMzm7ivbpRFULoukVvtk4VO8p/tju2OZTuLSk+JqQ+jQK BbtwUF2qc2JLse40AFVe2mN2cLYzg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdeigdduiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8CBB63064674; Mon, 28 Sep 2020 05:21:53 -0400 (EDT) From: Thomas Monjalon To: "Min Hu (Connor)" , Ferruh Yigit Cc: "techboard@dpdk.org" , stephen@networkplumber.org, bruce.richardson@intel.com, "jerinj@marvell.com" , dev@dpdk.org Date: Mon, 28 Sep 2020 11:21:51 +0200 Message-ID: <4609355.k5e1dzZlXI@thomas> In-Reply-To: <64be8517-6c26-6185-fb2e-981105225d90@intel.com> References: <1598845317-55956-1-git-send-email-humin29@huawei.com> <1601176596-29900-3-git-send-email-humin29@huawei.com> <64be8517-6c26-6185-fb2e-981105225d90@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-techboard] [PATCH V5 2/2] ethdev: change data type in TC rxq and TC txq X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/09/2020 11:04, Ferruh Yigit: > On 9/27/2020 4:16 AM, Min Hu (Connor) wrote: > > From: Huisong Li > > > > Currently, base and nb_queue in the tc_rxq and tc_txq information > > of queue and TC mapping on both TX and RX paths are uint8_t. > > However, these data will be truncated when queue number under a TC > > is greater than 256. So it is necessary for base and nb_queue to > > change from uint8_t to uint16_t. [...] > > --- a/lib/librte_ethdev/rte_ethdev.h > > +++ b/lib/librte_ethdev/rte_ethdev.h > > struct rte_eth_dcb_tc_queue_mapping { > > /** rx queues assigned to tc per Pool */ > > struct { > > - uint8_t base; > > - uint8_t nb_queue; > > + uint16_t base; > > + uint16_t nb_queue; > > } tc_rxq[ETH_MAX_VMDQ_POOL][ETH_DCB_NUM_TCS]; > > /** rx queues assigned to tc per Pool */ > > struct { > > - uint8_t base; > > - uint8_t nb_queue; > > + uint16_t base; > > + uint16_t nb_queue; > > } tc_txq[ETH_MAX_VMDQ_POOL][ETH_DCB_NUM_TCS]; > > }; > > > > > > cc'ed tech-board, > > The patch breaks the ethdev ABI without a deprecation notice from previous > release(s). > > It is increasing the storage size of the fields to support more than 255 queues. Yes queues are in 16-bit range. > Since the ethdev library already heavily breaks the ABI this release, I am for > getting this patch, instead of waiting for one more year for the update. > > Can you please review the patch, is there any objection to proceed with it? Acked-by: Thomas Monjalon