From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 447E043AAF; Wed, 7 Feb 2024 23:57:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 18BDD402A9; Wed, 7 Feb 2024 23:57:19 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2064.outbound.protection.outlook.com [40.107.243.64]) by mails.dpdk.org (Postfix) with ESMTP id 4F3824027D for ; Wed, 7 Feb 2024 23:57:17 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DpV4pkw8iamyGwfC6n9cJelMQk2kpJQ8UGo14itaZqh1vnO3iDuPsWh+rrg6q1T9GtyjW6TGxO4NgQctBHT9yV1SQD3YLEfdtiii+vixuMelSS3HLj4HQPk3mC69Apjv9olpf2j3H5drLuZaVa2Tl68JgPpSNfsG6YLMHNOqAej1iDhzkRF7o60U+TJOWzBCkeULuPrVgJhxA2tFHm+TgPVIuZHZeBjL6d3s/nwNpiUYuh16FBHFX9feXaEBpBqW7QErBUNJfTzQZGx63EkHvKhcaAD9gofta2ktdxFMg1YIdOrigz0l4U0E82aPDB6B7DSsSc02Rw3dnGJcYKEqUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5jv38XhZ/fsDPokRnnzbycd0gNXL7CbrGB58oVq3sBw=; b=N2kq2x/ITRTHz1IunCx00OiLZD+KQZLlQHB+rJ6mxe17lJCrTifATRocwAg00FfezkJpC8Oarqcn/q9QL5MFaO8uEE/p7UqPugZuxsj0oTgMUtqayN4uazlQm/gfEjbdvihZbYRNOMkeKVqlwjeLnH7kmaY4dwEkkoXPR3l9v77xgIjzcSxFNXA2uycWbsga9rWvsRqQVUQjpA7YRPofzAmQcl8TxTRzoVgPb93vHeotzbR85FMAhXdmA01SYBU2lWQLTlZQtrUjA51YcAp4cExS0mG4PuKZkMHQ3rKhbEmTnhtmCBn293CEAyeeWUKLdYkcEutT/4qOJG2At7d7iQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5jv38XhZ/fsDPokRnnzbycd0gNXL7CbrGB58oVq3sBw=; b=jlYhT1hGsB2LuXI4tlMlw4KGIwglipM7ITd7MNCF3pBGdc3CchkkCPHQ/BBbPqVEEL8uulDzthfcEVfB/loA8RGIzRR1AdcYY5eQV4UZF4SdeaAdtzWtDeXRQroogg+MtblTG8RbXw6Ndq3w0UV02oUFKwGB1y3oO9Z9NSjaLmk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) by IA1PR12MB7592.namprd12.prod.outlook.com (2603:10b6:208:428::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.14; Wed, 7 Feb 2024 22:57:14 +0000 Received: from MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::716d:e3ce:141a:f22d]) by MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::716d:e3ce:141a:f22d%6]) with mapi id 15.20.7270.016; Wed, 7 Feb 2024 22:57:14 +0000 Message-ID: <460c72b5-0b6f-440f-99bd-251f5ce3713e@amd.com> Date: Wed, 7 Feb 2024 22:57:10 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] gro : packets not getting flushed in heavy-weight mode API Content-Language: en-US To: Kumara Parameshwaran , hujiayu.hu@foxmail.com Cc: dev@dpdk.org References: <20240117195228.423261-1-kumaraparamesh92@gmail.com> <20240118083626.432048-1-kumaraparamesh92@gmail.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240118083626.432048-1-kumaraparamesh92@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0018.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ad::11) To MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB4301:EE_|IA1PR12MB7592:EE_ X-MS-Office365-Filtering-Correlation-Id: ad4106ff-7fe9-44f4-941d-08dc28301fd8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i8JlM3kElxB4cR2yr4ADzmTi2OwHMKI4Xj+OaD1NBvzHlT9rdp5rvrZj12UVEJAea6DzconbT0pft7TD7uwfIzySihoVBlMzoPo8u/SKsxIQ5UIB5GpVtkcrWfCLPmhFVPZ9rFsjOxk7Zu9/iBQZhNqXsysDTv8Cc6xn9Yijwqok1ofkBTd+xM6mmivptqqotLb4x+IwBJkVl0IvNTjeZ29wwYZ3KnAz0VLLVcp+Tvsrno5+sNKEssQuGj4UtgGZf0ec2DQ8lIp24JRAU4BeWVQSx/zg8ogBo6dXNdF5KTNhXfYaMvlrSjto55NEEr7iT1RbNO218E9mhqFy/K0oeQpeDTE7T6FAGL9UzPG9yhlP89VKGKzbjrlY3Dyg5wYFkmgmddLxKFqMW7lNnBtzoMJvsHfx1fkr7VEimBPAUXytzW/hpKUNAdKmqThQ1ejRJ4WHtpW5zGHhcheHWdyvzgnccfsYOnAvwud7fL9AnbqG7KBLPUh4t+l03PtFl7g/fELX8Zo2HuG2bbaWEycKvtKA84DpNlnjLReXUlVVW97QRc567/CPlBCfJCffCBZU X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4301.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(376002)(39860400002)(346002)(136003)(396003)(230273577357003)(230922051799003)(64100799003)(1800799012)(451199024)(186009)(6506007)(53546011)(6666004)(8936002)(6512007)(66476007)(31696002)(2616005)(66556008)(5660300002)(36756003)(26005)(2906002)(4326008)(66946007)(316002)(44832011)(8676002)(41300700001)(6486002)(478600001)(86362001)(31686004)(83380400001)(38100700002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YVcyeHZtZDF6ZzhVdDA4clVxaDFWcXVhSHRsMzRRU2RtdStEVjRXc3RnYlhE?= =?utf-8?B?b1RMbGp1RFE4Q1RQYkxqMFRoUVZKMnM0ek8xR3ljOUVwczBlYnEyNE0vNWZN?= =?utf-8?B?T2lnMzU2dnFDZkpRWjFYYmp0MGRmQktpbzgxMGc1Q0x1V3hFcWd4U0pmbFZF?= =?utf-8?B?VkdJUkd6N2ZUaU5BTlNjdE9kQllreUdaWER2VTlLWldWS0k3Q1FtNGFZRWE5?= =?utf-8?B?M3ZjeDlWQWE4VmlZS3hqbmxPUDVPSGN1NHQ1Wi81UlRSYlg3cmo1UC9MUWU4?= =?utf-8?B?aVFPSXNrYUtFSTVKMnpvZ3lGYWRhRFJPNXJ3aERXUVhZd1plTzhTUmlDUUs4?= =?utf-8?B?blNtTEVjL0x2YjhUeC9qMERvK2xTS0E5d1Q1VnN6V0dJZHVRNjFoNXVjeWxs?= =?utf-8?B?aFFrK1J6Zy91QWJVd3JodXZ5VzFHMzJtOUZtR1lOUUN4UFBMMnYvSzYzNFVp?= =?utf-8?B?SEhscXBKMXhXUjVhRkY2RkV6cTJVcG5FS0dWaWxUWUdObE1lZkZCK3ZiM2JG?= =?utf-8?B?MDJoMmZ5SzBqRi9xZWF1MUlhNWdBTGhmaHpYVVJNdDkvRHRqYmZVVW9JSVgy?= =?utf-8?B?MHhLZnhRUk8xVERScjFpcU9Ldld4TEltb1VQTGd2V1hwdUJhR05FeElXWUs5?= =?utf-8?B?UVlWTVVRN0tHT0s2TVZmQ0NqWWVid1BtR2pVRU93T3ZYcWlIak9oY2lpcHZP?= =?utf-8?B?dVpEUkl3Mkl1b1o0cjV0TW0vQmMwY1JKQ0NVc2dtTUswVStqcEJ4dVZYdTNZ?= =?utf-8?B?WlBzQ3RpNkxpdUorZGdxUVZrS3ZsakRhVTkxcWF1dk10QUVnV3E2Q0YrRnVF?= =?utf-8?B?KzVSdnZkZCtxU3JPeG5pbTJJS0M3alJsS0Z1Rzg0TGpscFlTMUxCMm1HcmhU?= =?utf-8?B?am1pemZkWkwyZEFqa0dhSU5hTjFYS0lzb2U3UFpOcVRNV1h3cS81cW1XcUlR?= =?utf-8?B?UE5yK2hYUVdWUFZCanZqandJWHh2bUJZOVBIQUszaGxtTk16VXR3NnpzbnU0?= =?utf-8?B?cHJrcDlXSzNhRUdiZGxlSXNUYjVKcEVUYVF3blpXWEhhQkI2U0NaWEs5d1pJ?= =?utf-8?B?QXlPbCtxRHZFZnVGU3ZiaHpRclhkMEUvbnNqcFVseERtdGZrajJScnRySDk1?= =?utf-8?B?ZWVSZFhvRTg5SVExNy9zUXR1eGRIVVIyeThqOEVrTHZrM21TdnFzSjFtdzFY?= =?utf-8?B?Q3JVekZ0VnJsWVVDRFVzbUJQS1RRRUFTZGN2S0piaWxuWnhNZ1BOZ2ZXRisy?= =?utf-8?B?d21KWUZGQmZrcktUQmtnMDEzaVB1QUcvYzd1RUFaU2R1cEl2UndmZHVCYWVk?= =?utf-8?B?T0tRa1BoLzNVN0Vuc0ZKcFpqODlJTkVIaDl1QVloYjRxVWNVRzNHY1pWY1ZY?= =?utf-8?B?eE1LY0k5bzVqMDczSDRBcDZ2YklBRWwzbGx3Z3VVSWtlZkx3RHRIWUdKT2pH?= =?utf-8?B?KzMwblhYWGlBSGVmbXNMWHR1ZkZYK3UwVFZyK2FnWHhoN2oxOHZRVGJ1K2xY?= =?utf-8?B?UldkeTF1OGhZd0N3V3VQTnd4VGFqd0p4SG8zWWxqZGwzUWh0Tk1JcUo0bVQ2?= =?utf-8?B?N3RiampXUHg3VGs1Z2kvVVllazJyZzRnVTgwQVp1bUtxSUxvdjdETkxjZ1RI?= =?utf-8?B?TFdQQk12OEU1a3N2S2VUVWtQamR1S0s0QWpFK1dreE00anBSUUtmVVNjUTJt?= =?utf-8?B?TWJnQitRTHl0YXFJamZOaGJIdGNYakZoTmxhYlhHQ21RUFozLzhwUVA5Q2h2?= =?utf-8?B?ZmVnTEtJSjRNN3NJYU9Ra1FMOHI5eGdPbEJHZzljTWl2Y1lqRncwMUNkTFdj?= =?utf-8?B?UkUzK0daRXJ6YzkvZThTZVZLa2VXdjVPTGUwSUMxVTZONTRBK1RFSnMxSFNa?= =?utf-8?B?eDNqYnlDUU5Sbm1FRVNJdmFvSnVnWVdFWE5sOERxNkxDZUlDVUF6VThRMk0z?= =?utf-8?B?bnBRSmFwN1grdkIzcVhlRWU1SmJiOFovM2hxYmFudkRKL1ljMTNDOFN2OWFX?= =?utf-8?B?YWtwdS91UWtUa1dCNCt3WkZURnBVSWNjWGFacmkvU2dvOVpSMW16MDN6UWJZ?= =?utf-8?B?WmVibkd1K1lHcEhlM3o5UVgrWFVoZFZOSUZzenBndjlXaUx1dklRc253WGxZ?= =?utf-8?Q?EceN0TrA7Lypa2WbuU7yF1yR6?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad4106ff-7fe9-44f4-941d-08dc28301fd8 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4301.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2024 22:57:14.0831 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MCWF11sa+p2GDA8aNFiEgfi/cC/Y2U5GSUB7IJraiBT7Gw4eLUfLUedpO8d4Rvih X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7592 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/18/2024 8:36 AM, Kumara Parameshwaran wrote: > In heavy-weight mode GRO which is based on timer, the GRO packets > will not be flushed in spite of timer expiry if there is no packet > in the current poll. If timer mode GRO is enabled the > rte_gro_timeout_flush API should be invoked. > Agree on the problem, need a way to flush existing packets in GRO context when no more packet receiving. > Signed-off-by: Kumara Parameshwaran > --- > v1: > Changes to make sure that the GRO flush API is invoked if there are no packets in > current poll and timer expiry. > > v2: > Fix code organisation issue > > v3: > Fix warnings > > v4: > Fix error and warnings > > v5: > Fix compilation issue when GRO is not defined > > app/test-pmd/csumonly.c | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c > index c103e54111..6d9ce99500 100644 > --- a/app/test-pmd/csumonly.c > +++ b/app/test-pmd/csumonly.c > @@ -863,16 +863,23 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) > > /* receive a burst of packet */ > nb_rx = common_fwd_stream_receive(fs, pkts_burst, nb_pkt_per_burst); > +#ifndef RTE_LIB_GRO > if (unlikely(nb_rx == 0)) > return false; > - > +#else > + gro_enable = gro_ports[fs->rx_port].enable; > + if (unlikely(nb_rx == 0)) { > + if (gro_enable && (gro_flush_cycles != GRO_DEFAULT_FLUSH_CYCLES)) > + goto init; > Rest of the function expects 'nb_rx' non zero, so I am concerned about unexpected side effects, like: - GRO reassembles packets and flush, how reassembles behaves with zero nb_rx? - If there is no packet in GRO context, what happens to call with zero nb_rx? To address above issue, what about add 'rte_gro_get_pkt_count()' check and only continue if it return not zero. Also in below GRO block, call 'rte_gro_reassemble()' only when 'nb_rx' is not zero. > + else > + return false; > 'goto' can be prevented by changing the condition in if block. > + } > +init: > Label name 'init' is not a good name. > +#endif > rx_bad_ip_csum = 0; > rx_bad_l4_csum = 0; > rx_bad_outer_l4_csum = 0; > rx_bad_outer_ip_csum = 0; > -#ifdef RTE_LIB_GRO > - gro_enable = gro_ports[fs->rx_port].enable; > -#endif > > txp = &ports[fs->tx_port]; > tx_offloads = txp->dev_conf.txmode.offloads;